Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-445

THRIFT-236 inadvertently reorders constructors and struct method parameters

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Blocker
    • Resolution: Fixed
    • 0.1
    • 0.1
    • Compiler (General)
    • None

    Description

      The way we implemented THRIFT-236 resulted in the argument order of some libraries' constructors and service method definitions. This is really bad. We need to switch that back to IDL order.

      Attachments

        1. thrift-445.patch
          5 kB
          Bryan Duxbury
        2. thrift-445-v2.patch
          7 kB
          Bryan Duxbury

        Issue Links

        relates to

        Improvement - An improvement or enhancement to an existing feature or task. THRIFT-236 Structs should be serialized in a consistent order

        • Major - Major loss of function.
        • Closed

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            dreiss David Reiss
            bryanduxbury Bryan Duxbury
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment