[THRIFT-236] Structs should be serialized in a consistent order

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.1
• Assignee: Alexander Shigin
• Reporter: Bryan Duxbury
• Created: 17/Dec/08 23:31
• Updated: 10/Apr/09 21:51
• Resolved: 10/Apr/09 21:51

Description

As it stands right now, Ruby generated structs will be serialized in arbitrary order (due to storage of metadata in a hash). This leads to different binary encoding for the same struct values. Ideally, it should be the same for any two serializations of equivalent structs, and between languages if possible.

The two approaches that seem to make the most sense are in lowest-to-highest field id order, and in IDL-defined order. What do people think of this idea, and which approach would be preferred?

Issue Links

• is related to: THRIFT-445 THRIFT-236 inadvertently reorders constructors and struct method parameters