[THRIFT-4261] Go context generation issue: breaking change in generated code regarding thrift.TProcessorFunction interface

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Not A Problem
• Fix Version/s: 0.11.0
• Component/s: Go - Compiler, Go - Library

Environment

generated code for Golang

• Assignee: Jens Geyer
• Reporter: Yicheng Qin
• Created: 25/Jul/17 19:42
• Updated: 27/Jul/17 04:42
• Resolved: 26/Jul/17 20:30

Description

I observe the breaking change in `thrift.TProcessorFunction` interface that adds a `Context` parameter, and corresponded breaking change in the generated client code.

So the generated code from v0.9 thrift compiler can no longer run with the master thrift library.

I understand you expect that we should use the same version of compiler and library for the same repository. But this is super hard in reality:
1. Lots of repos store the generated code, e.g., https://github.com/uber/jaeger-client-go/blob/master/thrift-gen/jaeger/agent.go . So it could use either old interface or new interface.
2. Go projects always use `glide` as version management, which uses single version for one library across the repository. If one dep relies on old interface, and one dep relies on new interface, the project will totally break.

Issue Links

• duplicates: THRIFT-4260 Go context generation issue. Context is parameter in Interface not in implementation