Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-4261

Go context generation issue: breaking change in generated code regarding thrift.TProcessorFunction interface

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Not A Problem
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: Go - Compiler, Go - Library
    • Labels:
      None
    • Environment:

      generated code for Golang

      Description

      I observe the breaking change in `thrift.TProcessorFunction` interface that adds a `Context` parameter, and corresponded breaking change in the generated client code.

      So the generated code from v0.9 thrift compiler can no longer run with the master thrift library.

      I understand you expect that we should use the same version of compiler and library for the same repository. But this is super hard in reality:
      1. Lots of repos store the generated code, e.g., https://github.com/uber/jaeger-client-go/blob/master/thrift-gen/jaeger/agent.go . So it could use either old interface or new interface.
      2. Go projects always use `glide` as version management, which uses single version for one library across the repository. If one dep relies on old interface, and one dep relies on new interface, the project will totally break.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                jensg Jens Geyer
                Reporter:
                qycqycqycqycqyc Yicheng Qin
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: