[THRIFT-4260] Go context generation issue. Context is parameter in Interface not in implementation

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 0.11.0
• Fix Version/s: 0.11.0
• Component/s: Go - Compiler
• External issue URL: https://github.com/openzipkin/zipkin-go-opentracing/issues/68
• Assignee: taozle
• Reporter: Bas van Beek
• Created: 23/Jul/17 09:28
• Updated: 14/Dec/17 13:55
• Resolved: 24/Jul/17 22:33

Description

Unfortunately the Go library was updated before a new Compiler was released. Having thrift compiled code be part in a project prior to the thrift context library addition breaks due to the dependency on the thrift go library. See: https://github.com/openzipkin/zipkin-go-opentracing/issues/68

I tried to resolve be installing compiler from latest source but found the generated source to be incorrect. The generated Go interface for the service client includes context.Context as the first parameter of the service method. The generated client implementation however does not.

The following thrift code:

enum ResultCode
{
  OK,
  TRY_LATER
}

struct LogEntry
{
  1:  string category,
  2:  string message
}

service Scribe
{
  ResultCode Log(1: list<LogEntry> messages);
}

Generated the following Go code:

type Scribe interface {
	// Parameters:
	//  - Messages
	Log(ctx context.Context, messages []*LogEntry) (r ResultCode, err error)
}

...

// Parameters:
//  - Messages
func (p *ScribeClient) Log(messages []*LogEntry) (r ResultCode, err error) {
	if err = p.sendLog(messages); err != nil {
		return
	}
	return p.recvLog()
}

Issue Links

• is broken by: THRIFT-4236 Support context in go generated code.
• is duplicated by: THRIFT-4261 Go context generation issue: breaking change in generated code regarding thrift.TProcessorFunction interface
• links to: GitHub Pull Request #1312