Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-4037

[CMake] Use a single build system for thrift to make development easier

    XMLWordPrintableJSON

Details

    • Wish
    • Status: Open
    • Major
    • Resolution: Unresolved
    • 0.10.0
    • None
    • Build Process

    • All

    Description

      Background

      The thrift project currently carries two build systems. The original build system is based on autoconf and is used to build a complete deliverable including extensive cross-language testing.

      The other build system was introduced a few years ago, with roots tracing back to THRIFT-797. CMake allows thrift to build natively on multiple platforms - unix and windows. Autoconf is no longer under active development with the last release in 2012, and it does not allow for native windows builds using native tools that are used by a majority of consumers.

      Maintaining two build systems for a project incurs a lot of overhead. Every change that touches the build system needs to be done twice, in two completely different ways. We need twice as many CI jobs to verify that all of the builds are working, whereas with a single cmake build environment we could likely use a single CI build job per platform that does everything using the docker image on linux and appveyor on windows.

      Proposal

      We should officially deprecate autoconf in favor of cmake, and continue (more aggressively) the effort to make the cmake build environment as functional as the autoconf build environment. During this transition, folks will be required to make changes to both build systems (which are proven out mostly through the Travis CI build jobs; only CMake is used on AppVeyor).

      Acceptance Criteria

      1. All existing platforms, targets, and tests are converted to use cmake
        1. Including cross-compilation
      2. All CI builds are converted to use cmake
      3. autoconf build environment is removed

      Attachments

        Issue Links

          incorporates

          Improvement - An improvement or enhancement to an existing feature or task. THRIFT-2850 Have the cmake build system run make cross

          • Major - Major loss of function.
          • Open

          Task - A task that needs to be done. THRIFT-4754 Prove the CMake out-of-tree build is really out-of-tree

          • Major - Major loss of function.
          • Open

          Task - A task that needs to be done. THRIFT-4755 Create a "make dist" target for cmake

          • Major - Major loss of function.
          • Open
          relates to

          Improvement - An improvement or enhancement to an existing feature or task. THRIFT-5575 Create a GitHub workflow using CMake

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          supercedes

          Bug - A problem which impairs or prevents the functions of the product. THRIFT-381 Fail fast if configure detects C++ problems

          • Trivial - Cosmetic problem like misspelt words or misaligned text.
          • Closed

          Test - A new unit, integration or system test. THRIFT-797 Converting to cmake from autotools

          • Major - Major loss of function.
          • Closed
          links to

          Web Link GitHub Pull Request #1733

          Activity

            People

              jking3 James E. King III
              jking3 James E. King III
              Votes:
              4 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

                Created:
                Updated:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m