[THRIFT-352] Implicit Enum Values should still be valid.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Component/s: Ruby - Compiler
• Patch Info: Patch Available
• Assignee: Gary Tsang
• Reporter: Gary Tsang
• Created: 04/Mar/09 18:58
• Updated: 04/Mar/09 21:43
• Resolved: 04/Mar/09 21:43

Description

Currently only explicitly set enum values are added to the ValidValues set. This makes thrift interfaces like scribe fail

Example:

#scribe thrift interface
enum ResultCode
{
  OK,
  TRY_LATER
}

# generated ruby code
module ResultCode
  OK = 0
  TRY_LATER = 1
  VALID_VALUES = Set.new([]).freeze
end

My patch removes the check to see if the value was explicilty set, so all enumerated types get added to the ValidValues set.

Issue Links

• is related to: THRIFT-224 Validate method should check that enum types are assigned valid values