[THRIFT-224] Validate method should check that enum types are assigned valid values

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Component/s: Ruby - Compiler
• Patch Info: Patch Available
• Assignee: Piotr Kozikowski
• Reporter: Nathan Marz
• Created: 04/Dec/08 19:46
• Updated: 01/Nov/11 02:52
• Resolved: 16/Jan/09 22:35

Description

The validate method generated currently checks that required fields are set. It would be nice if it were to enforce more parts of the schema. One example of this are the values assigned to enum types. For example, if I have this enum:

enum MyEnum {
FOO = 1;
BAR = 3;
BAZ = 4;
BIZ = 5;
}

and this struct:

struct MyStruct {
MyEnum e;
}

The validate method would ensure that MyStruct#e is either 1, 3, 4, or 5.

The naive way of implementing this would be to generate a conditional statement for every value, aka

"e==1 || e==3 || e==4 || e==5"

A better implementation would generate something like:

"e==1 || (e>=3 && e<=5)"

Since the common case seems to be having large ranges of contiguous values, this is the difference between having N conditionals execute versus 2.

Issue Links

• incorporates: THRIFT-187 Generated enums should have a set of their attributes as well
• relates to: THRIFT-352 Implicit Enum Values should still be valid.
• relates to: THRIFT-245 FIELDS constant should contain name of enumerated type for enum fields