[THRIFT-3028] Regression caused by THRIFT-2180

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.3
• Fix Version/s: 0.9.3
• Component/s: Cocoa - Library
• Labels: endianness

Environment

Reported against ios-arm64.

• Patch Info: Patch Available
• Assignee: Jens Geyer
• Reporter: Jeremy W. Sherman
• Created: 06/Mar/15 15:12
• Updated: 30/Apr/15 18:57
• Resolved: 17/Apr/15 16:48

Description

Changes made in THRIFT-2180 to TBinaryProtocol broke little-endian message reading. Message-writing was also affected.

This was not caught by tests, because the cross-tests appear not to include the Cocoa platform.

A minimal patch is attached to address this.

I wrote a local test using a StreamTransport, which lets me use NSStream to read/write via in-memory buffers easily (or file handles - the existing transports probably should have been written in terms of this standard Foundation abstraction) to verify that write/read of a message agree on how to read-write.

gurubook: Would you be so kind as to apply the attached patch, and verify it addresses the issue you reported on THRIFT-2180?

Issue Links

• is related to: THRIFT-2180 Integer types issues in Cocoa lib on ARM64