Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-3028

Regression caused by THRIFT-2180

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.9.3
    • 0.9.3
    • Cocoa - Library
    • Reported against ios-arm64.

    • Patch Available

    Description

      Changes made in THRIFT-2180 to TBinaryProtocol broke little-endian message reading. Message-writing was also affected.

      This was not caught by tests, because the cross-tests appear not to include the Cocoa platform.

      A minimal patch is attached to address this.

      I wrote a local test using a StreamTransport, which lets me use NSStream to read/write via in-memory buffers easily (or file handles - the existing transports probably should have been written in terms of this standard Foundation abstraction) to verify that write/read of a message agree on how to read-write.

      gurubook: Would you be so kind as to apply the attached patch, and verify it addresses the issue you reported on THRIFT-2180?

      Attachments

        1. 3028.patch
          2 kB
          Jeremy W. Sherman

        Issue Links

          Activity

            People

              jensg Jens Geyer
              jeremyw.sherman Jeremy W. Sherman
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: