[THRIFT-2844] Nodejs support broken when running under Browserify

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.2
• Fix Version/s: 0.9.3
• Component/s: Node.js - Library

Environment

Browserify

• Patch Info: Patch Available
• Assignee: Randy Abernethy
• Reporter: Cameron Ring
• Created: 20/Nov/14 08:55
• Updated: 26/Jan/15 02:26
• Resolved: 02/Dec/14 13:48

Description

When running under Browserify, the NodeJS binding fails when using the HTTP transport. This happens because Browserify is returning the response as a Uint8Array rather than a Buffer. The fix is straightforward: in response.on('data', wrap any Uint8Arrays in a buffer so the types are as expected.