Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-2844

Nodejs support broken when running under Browserify

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.9.2
    • Fix Version/s: 0.9.3
    • Component/s: Node.js - Library
    • Labels:
      None
    • Environment:

      Browserify

    • Patch Info:
      Patch Available

      Description

      When running under Browserify, the NodeJS binding fails when using the HTTP transport. This happens because Browserify is returning the response as a Uint8Array rather than a Buffer. The fix is straightforward: in response.on('data', wrap any Uint8Arrays in a buffer so the types are as expected.

        Attachments

          Activity

            People

            • Assignee:
              codesf Randy Abernethy
              Reporter:
              cameronr Cameron Ring
            • Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: