[THRIFT-2746] Compiler C++98 conformance

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.2
• Fix Version/s: 0.9.2
• Component/s: C++ - Compiler, Haskell - Compiler

Environment

all

• Patch Info: Patch Available
• Assignee: Randy Abernethy
• Reporter: Randy Abernethy
• Created: 30/Sep/14 20:49
• Updated: 05/Nov/14 04:49
• Resolved: 30/Sep/14 22:15

Description

This is the piece of the CentOS 6.5 patch that cleans up the compiler build errors due to C + + 11 code in the Haskell and C++ generators.

C + + 11 elements replaced:

• Ranged for loops: for ( auto x : container )
• Type deduction: auto
• NULL assignment to boost::shared_ptr: replaced with .reset()
• Constructor initialization of boost::shared_ptr with 0: replaced with ""
• Nondeterministic compiler dependent for loop scoping: changed iterators to inner scope

Issue Links

• is part of: THRIFT-2744 Vagrantfile for Centos 6.5
• is related to: THRIFT-2711 Travis reports false possitive while building with mingw