[THRIFT-2395] thrift Ruby gem requires development dependency 'thin' regardless of environment

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.1
• Fix Version/s: 0.9.2
• Component/s: Ruby - Library

Environment

Ruby 1.9.3-p484, Rails 3.0.20

• Assignee: Jake Farrell
• Reporter: Tim Schmelmer
• Created: 10/Mar/14 17:40
• Updated: 10/Mar/14 17:56
• Resolved: 10/Mar/14 17:56

Description

The thrift library requires the thin (HTTP webserver) uncoditionally, see thrift-0.9.1/lib/thrift.rb (ll. 59 - 65):

1. server
   require 'thrift/server/base_server'
   require 'thrift/server/nonblocking_server'
   require 'thrift/server/simple_server'
   require 'thrift/server/threaded_server'
   require 'thrift/server/thread_pool_server'
   require 'thrift/server/thin_http_server'

As there is no gemspec to require the thin gem (in development group or other), bundler will not find this gem dependency.
Additionally, this dependency should only be required in development mode (as listed on rubygems: https://rubygems.org/gems/thrift/versions/0.9.1), so applications running in a production mode / environment should not need to depend on Thin at all, even if they use thrift.

Issue Links

• duplicates: THRIFT-2145 Rack and Thin are not just development dependencies