[THRIFT-236] Structs should be serialized in a consistent order - ASF JIRA

XML

Word

Printable

JSON

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 0.1
Component/s: None
Labels:
None

Description

As it stands right now, Ruby generated structs will be serialized in arbitrary order (due to storage of metadata in a hash). This leads to different binary encoding for the same struct values. Ideally, it should be the same for any two serializations of equivalent structs, and between languages if possible.

The two approaches that seem to make the most sense are in lowest-to-highest field id order, and in IDL-defined order. What do people think of this idea, and which approach would be preferred?

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending

thrift-236-v7.patch
10/Apr/09 20:41
13 kB
Bryan Duxbury
thrift-236-v6.patch
09/Apr/09 23:03
12 kB
Bryan Duxbury
thrift-236-v5.patch
09/Apr/09 21:56
11 kB
Bryan Duxbury
thrift-236-v4.patch
09/Apr/09 21:47
7 kB
Bryan Duxbury
thrift-consistent-order-v3.patch
27/Mar/09 20:29
6 kB
Alexander Shigin
thrift-consistent-order-v2.patch
27/Mar/09 16:27
6 kB
Alexander Shigin
sort-fields.diff
26/Mar/09 20:13
0.9 kB
David Reiss
thrift-consistent-order.patch
22/Mar/09 20:52
4 kB
Alexander Shigin
thrift-236.patch
18/Dec/08 00:37
6 kB
Bryan Duxbury

Issue Links

is related to

THRIFT-445 THRIFT-236 inadvertently reorders constructors and struct method parameters

Closed

Activity

People

Assignee:: Alexander Shigin

Reporter:: Bryan Duxbury

Votes:: 0 Vote for this issue

Watchers:: 0 Start watching this issue

Dates

Created:: 17/Dec/08 23:31

Updated:: 10/Apr/09 21:51

Resolved:: 10/Apr/09 21:51