[THRIFT-1973] TCompactProtocol in C# lib does not serialize and deserialize negative int32 and int64 number correctly

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9
• Fix Version/s: 0.9.1
• Component/s: C# - Library
• Labels: PatchAvailable

Environment

Windows

• Patch Info: Patch Available
• Assignee: Henrique Mendonca
• Reporter: Eric Ding
• Created: 17/May/13 23:29
• Updated: 20/Feb/21 15:27
• Resolved: 08/Jun/13 03:15

Description

longToZigzag and ZigzagToLong in TCompactProtocol does not perform corresponding operations to serialize and deserialize negative int32 and int64 number correctly. Purpose to change longToZigzag from (ulong)(((ulong)n << 1) ^ ((ulong)n >> 63)) to (ulong)(n << 1) ^ (ulong)(n >> 63).

Will need to do same for intToZigZag. The reason is that we want arithmetic shift not logic shift.

The test case in the project shows this, the output on server and client are different even though client received the same number back.

Issue Links

• is duplicated by: THRIFT-2047 Thrift.Protocol.TCompactProtocol, intToZigZag data lost (TCompactProtocol.cs)