[THRIFT-2047] Thrift.Protocol.TCompactProtocol, intToZigZag data lost (TCompactProtocol.cs)

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 0.9
• Fix Version/s: 0.9.1
• Component/s: C# - Library
• Labels: TCompactProtocol intToZigZag

Environment

Win7, amd64

• Assignee: Unassigned
• Reporter: LuHan
• Created: 19/Jun/13 05:13
• Updated: 13/Aug/13 09:12
• Resolved: 13/Aug/13 09:12

Description

In TCompactProtocol.cs, the function:
/**

• Convert n into a zigzag int. This allows negative numbers to be
• represented compactly as a varint.
  */
  private uint intToZigZag(int n) { return (uint)(((uint)n << 1) ^ ((uint)n >> 31)); }
  will make wrong number while the integer is negative. Check the test code below: (so do longToZigZag.)
  
  ===============
  using System;
  using System.Collections.Generic;
  using System.Linq;
  using System.Text;
  
  namespace Test
  {
  class Program
  {
  static void Main(string[] args)
  {
  unchecked
  {
  int num = -1;
  if (num != zigzagToInt(intToZigZag(num)))
  { Console.WriteLine("Transform failed!"); }
  else
  { Console.WriteLine("Transform passed!"); }
  
  if (num != zigzagToInt(intToZigZagNew(num)))
  { Console.WriteLine("Transform failed!"); }
  else
  { Console.WriteLine("Transform passed!"); }
  
  Console.ReadLine();
  }
  }
  
  static int zigzagToInt(uint n)
  { return (int)(n >> 1) ^ (-(int)(n & 1)); }
  
  
  static uint intToZigZag(int n)
  { return (uint)(((uint)n << 1) ^ ((uint)n >> 31)); }

static uint intToZigZagNew(int n)

{ return (uint)((n << 1) ^ (n >> 31)); }

}
}

Issue Links

• duplicates: THRIFT-1973 TCompactProtocol in C# lib does not serialize and deserialize negative int32 and int64 number correctly