[THRIFT-1957] NodeJS TFramedTransport and TBufferedTransport read bytes as unsigned

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9
• Fix Version/s: 0.9.1
• Component/s: Node.js - Library
• Labels: patch

Environment

NodeJS 10.4, Thrift 0.9

• Patch Info: Patch Available
• Assignee: Henrique Mendonca
• Reporter: Matthew Imrie
• Created: 02/May/13 18:45
• Updated: 08/Jun/13 03:15
• Resolved: 08/Jun/13 03:15

Description

Thrift for NodeJS is reading bytes as unsigned. The Apache Thrift specification describes them as signed.

I changed the readByte function in both TFramedTransport and TBufferedTransport to call a new readByte method in binary.js that properly converts to a signed byte. Unit test for the method is included in binary.test.js