Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1957

NodeJS TFramedTransport and TBufferedTransport read bytes as unsigned

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.9
    • Fix Version/s: 0.9.1
    • Component/s: Node.js - Library
    • Labels:
    • Environment:

      NodeJS 10.4, Thrift 0.9

    • Patch Info:
      Patch Available

      Description

      Thrift for NodeJS is reading bytes as unsigned. The Apache Thrift specification describes them as signed.

      I changed the readByte function in both TFramedTransport and TBufferedTransport to call a new readByte method in binary.js that properly converts to a signed byte. Unit test for the method is included in binary.test.js

        Attachments

          Activity

            People

            • Assignee:
              henrique Henrique Mendonca
              Reporter:
              mjrimrie Matthew Imrie
            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: