[THRIFT-1866] java compiler generates non-compiling code with const's defined in a thrift file whose name includes non-identifier chars

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9
• Fix Version/s: 0.9.3
• Component/s: Java - Compiler

Environment

Mac OS X 10.7.5

• Assignee: Unassigned
• Reporter: Bekir Oguz
• Created: 27/Feb/13 14:18
• Updated: 21/Jul/15 04:34
• Resolved: 21/Jul/15 04:34

Description

Thrift-0.9 Java compiler generates non-compiling code when both the following conditions happen:

• thrift file name includes a character which is not a valid java identifier (i.e. '-')
• thrift file includes 'const' fields

Thrift generates the Java file named <thriftFileName>Constants.java which is not compiling because of the non-identifier in the thriftFileName.

Earlier thrift versions are fine because they generate only Constants.java file without prefixing thrift file name to it.

Please find attached an example thrift file.

Issue Links

• relates to: THRIFT-1383 Spaces in thrift input file lead to incorrectly generated code
• relates to: THRIFT-1916 Compiled ruby code generates warning if field with name "fields" is present
• relates to: THRIFT-1895 Delphi: reserved variable name "result" not detected properly