[THRIFT-1847] TSSLSocket.cpp and TFileTransport.cpp incorrectly excluded from Visual Studio project file

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.9
• Fix Version/s: 0.9.2
• Component/s: C++ - Library
• Labels: cpp msvc

Environment

MSVC 2010 (Windows 7) and MSVC 2012 (Windows 8)

• Patch Info: Patch Available
• Assignee: Jens Geyer
• Reporter: Chris Stylianou
• Created: 31/Jan/13 00:17
• Updated: 05/Nov/14 04:48
• Resolved: 01/Oct/14 20:07

Description

Both TSSLSocket.cpp and TFileTransport.cpp are incorrectly excluded from Visual Studio project file, so they are not built. I've attached a patch to include them again.

TSSLSocket.cpp also has an issue due to the use of 'snprintf' which is a C99 feature that isn't provided by MSVC compilers. I've also included a fix for this in the attached patch which uses '_snprintf_s' for MSVC instead.