Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1847

TSSLSocket.cpp and TFileTransport.cpp incorrectly excluded from Visual Studio project file

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 0.9
    • 0.9.2
    • C++ - Library

    • MSVC 2010 (Windows 7) and MSVC 2012 (Windows 8)

    • Patch Available

    Description

      Both TSSLSocket.cpp and TFileTransport.cpp are incorrectly excluded from Visual Studio project file, so they are not built. I've attached a patch to include them again.

      TSSLSocket.cpp also has an issue due to the use of 'snprintf' which is a C99 feature that isn't provided by MSVC compilers. I've also included a fix for this in the attached patch which uses '_snprintf_s' for MSVC instead.

      Attachments

        1. thrift-msvc.patch
          4 kB
          Chris Stylianou

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            jensg Jens Geyer
            chris5287 Chris Stylianou
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment