Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1671

Cocoa code generator does not put keywords into generated method calls

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.9
    • 0.9
    • Cocoa - Compiler
    • None
    • Patch Available

    Description

      In THRIFT-541 keywords where introduced to method declarations. But the actual call to the method omits them. That leads to errors as:

      pages.m:2558:3: warning: instance method '-send_deletePage::' not found (return type defaults to 'id')
        [self send_deletePage: websiteId : pageId];
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      pages.m:2764:23: warning: instance method '-getPage::' not found (return type defaults to 'id')
        [result setSuccess: [mService getPage: [args websiteId]: [args pageId]]];
                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      pages.m:2781:3: warning: instance method '-deletePage::' not found (return type defaults to 'id')
        [mService deletePage: [args websiteId]: [args pageId]];
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      

      The attached patch fixes that.

      Attachments

        Activity

          People

            bracki Jan Brauer
            bracki Jan Brauer
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: