Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1330

PHP Namespaces no longer generated

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • 0.7, 0.8
    • 0.8
    • PHP - Compiler
    • None
    • Mac OS X 10.6.8, CentOS 5.6, Ubuntu 11.04

    Description

      PHP namespaces are not being generated, ever. PHP 5.3 namespace aren't generated either.

      The following will illustrate the bug. This works in Thrift 0.6.*

      $ thrift -version
      Thrift version 0.7.0
      $ cat > test.thrift
      namespace php TestNamespace
      struct ItemX {}
      $ thrift --gen php test.thrift
      $ grep "TestNamespace" gen-php/test/test_types.php && echo "Has namespace" || echo "NO NAMESPACE FOUND"
      NO NAMESPACE FOUND

      $ thrift -version
      Thrift version 0.8.0-dev
      $ thrift -gen php test.thrift
      $ grep "TestNamespace" gen-php/test/test_types.php && echo "Has namespace" || echo "NO NAMESPACE FOUND"
      NO NAMESPACE FOUND

      Attachments

        1. thrift-1392-1330r1.patch
          7 kB
          Mike Riley
        2. thrift-1392-1330.patch
          7 kB
          Mike Riley

        Issue Links

          Activity

            People

              yelirekim Mike Riley
              barmstrong@qualtrics.com B Armstrong
              Votes:
              2 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: