[THRIFT-1392] Enabling both namespaces and autoloading in generated PHP code won't work.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.7
• Fix Version/s: 0.8
• Component/s: PHP - Compiler

Environment

PHP 5.3.2

• Patch Info: Patch Available
• Assignee: Mike Riley
• Reporter: Mike Riley
• Created: 17/Oct/11 00:00
• Updated: 26/Nov/11 18:32
• Resolved: 26/Nov/11 18:32

Description

Using --gen php:autoload=1,namespace=1 won't work because the generated types don't have namespaces declared and the autoloader pulls in the individual files.

I've attached a simple patch from the latest SVN trunk that will do two things inside t_php_generator::generate_php_struct_definition:

• Append namespaces to the top of the file
• Use the non-backslash-prefixed namespace declaration for the autoloader key

I'm a little confused as to why there were even namespaces being written into the autoloader array at all when they were prefixed with a backslash, and __autoload receives class names without a leading backslash.

Issue Links

• relates to: THRIFT-1330 PHP Namespaces no longer generated