[THRIFT-1279] type set is handled incorrectly when writing object

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.7
• Fix Version/s: 0.8
• Component/s: PHP - Compiler, PHP - Library
• Patch Info: Patch Available
• Assignee: Unassigned
• Reporter: Darius Staisiunas
• Created: 22/Aug/11 15:19
• Updated: 06/Sep/11 15:50
• Resolved: 06/Sep/11 15:19

Description

Patch provided in https://issues.apache.org/jira/browse/THRIFT-342 doesn't handle object writing correctly:
if one of the parameters is set

struct MyStruct {
10: string id,
20: string name,
30: set<string> setOfIDs
}

in generated file de-serialization of object is
public function read($input)
...
$xfer += $input->readString($elem5);
if (is_scalar($elem5)) {
$this->setOfIDs[$elem5] = true;
} else {
$this->setOfIDs []= $elem5;
}
...

but when serializing, we are looping only through values of array:
public function write($input)
...
foreach ($this->setOfIDs as $iter6)
{
if (is_scalar($iter6))

{ $this->setOfIDs[$iter6] = true; }

$xfer += $output->writeString($iter6);
}
}
...

But if our element is scalar - we should be iterating through keys.

it should look like:
foreach ($this->terminalIds as $iter6 => $iter7)
{
if (is_scalar($iter7))

{ $xfer += $output->writeString($iter6); }

else

{ $xfer += $output->writeString($iter7); }

}