[THRIFT-342] PHP: can't have sets of complex types

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.7
• Component/s: PHP - Compiler, PHP - Library

Environment

SVN trunk r743881

• Assignee: JCF
• Reporter: David Sklar
• Created: 17/Feb/09 22:50
• Updated: 12/Apr/11 22:03
• Resolved: 12/Apr/11 22:03

Description

A setup like this:

struct alice {
1: string bob
}

and another like this:

struct charlie {
1: set<alice> david
}

causes problems because the generated PHP code looks like:

==
case 1:
if ($ftype == TType::SET) {
$this->david = array();
$_size0 = 0;
$_etype3 = 0;
$xfer += $input->readSetBegin($_etype3, $_size0);
for ($_i4 = 0; $_i4 < $_size0; ++$_i4)

{ $elem5 = null; $elem5 = new alice(); $xfer += $elem5->read($input); $this->david[$elem5] = true; }

$xfer += $input->readSetEnd();
} else

{ $xfer += $input->skip($ftype); }

break;
===

Using objects as array keys makes PHP cranky and the values can not be properly set. I think the solution to this is either:

1. Document that the PHP bindings do not support sets of complex types. (boooo!)

2. Modify the generated code so that the values are stored in array values not keys. (With some additional checks to ensure uniqueness, or perhaps just using spl_object_hash($theObject) as the array key.

This seems similar to the issues raised in THRIFT-231 and THRIFT-162
$this->david[$elem5] = true;