Uploaded image for project: 'Tapestry 5'
  1. Tapestry 5
  2. TAP5-407

DocumentLinker should not use the deprecated practice of HTML commenting out the <script> block

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 5.1.0.0, 5.1, 5.0.15, 5.0.16, 5.0.17, 5.0.18
    • 5.1.0.0
    • tapestry-core
    • None

    Description

      The DocumentLinker is not commenting the javascript block properly. It needs to open with "<!-- //" instead of just "<!--". (patch attached)

      even a wiki on tapestry shows how to use the javascript comments properly, and says to please pay attention to how they are done...

      http://wiki.apache.org/tapestry/Tapestry5HowToIncludeJavaScript

      Attachments

        1. doc-js.diff
          0.7 kB
          Fernando Padilla

        Activity

          easy line liner.

          fern Fernando Padilla added a comment - easy line liner.

          Question: why is it relevant whether the JavaScript is in a comment block or not? That was important 5+ years ago before browsers universally supports the <script> tag.

          hlship Howard Lewis Ship added a comment - Question: why is it relevant whether the JavaScript is in a comment block or not? That was important 5+ years ago before browsers universally supports the <script> tag.

          I was just correcting the proper way to comment out the javascript..

          So you can either accept this patch, or create another one to remove the current attempt at commenting out the javascript, and leave it bare. that should be good too.

          fern Fernando Padilla added a comment - I was just correcting the proper way to comment out the javascript.. So you can either accept this patch, or create another one to remove the current attempt at commenting out the javascript, and leave it bare. that should be good too.

          As per Douglas Crockford, http://javascript.crockford.com/script.html, this practice should now be avoided entirely.

          hlship Howard Lewis Ship added a comment - As per Douglas Crockford, http://javascript.crockford.com/script.html , this practice should now be avoided entirely.

          People

            hlship Howard Lewis Ship
            fern Fernando Padilla
            Votes:
            2 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: