Tapestry 5
  1. Tapestry 5
  2. TAP5-407

DocumentLinker should not use the deprecated practice of HTML commenting out the <script> block

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.1.0.0, 5.1, 5.0.15, 5.0.16, 5.0.17, 5.0.18
    • Fix Version/s: 5.1.0.0
    • Component/s: tapestry-core
    • Labels:
      None

      Description

      The DocumentLinker is not commenting the javascript block properly. It needs to open with "<Unable to render embedded object: File (-- //" instead of just "<) not found.--". (patch attached)

      even a wiki on tapestry shows how to use the javascript comments properly, and says to please pay attention to how they are done...

      http://wiki.apache.org/tapestry/Tapestry5HowToIncludeJavaScript

      1. doc-js.diff
        0.7 kB
        Fernando Padilla

        Activity

        Howard M. Lewis Ship made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Fix Version/s 5.1.0.0 [ 12313428 ]
        Howard M. Lewis Ship made changes -
        Assignee Howard M. Lewis Ship [ hlship ]
        Summary DocumentLinker not commenting Javascript block properly DocumentLinker should not use the deprecated practice of HTML commenting out the <script> block
        Fernando Padilla made changes -
        Field Original Value New Value
        Attachment doc-js.diff [ 12395672 ]
        Fernando Padilla created issue -

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            Fernando Padilla
          • Votes:
            2 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development