Uploaded image for project: 'Tapestry 5'
  1. Tapestry 5
  2. TAP5-2264

ResponseCompressionAnalyzerImpl ignores 'tapestry.supress-compression' request attribute for assets and modules

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 5.4
    • Fix Version/s: 5.4
    • Component/s: tapestry-core
    • Labels:
      None

      Description

      version: 5.4 alpha29

      for pages and component rendering requests tapestry respects the request attribute org.apache.tapestry5.internal.InternalConstants.SUPPRESS_COMPRESSION.

      for modules and assets the request attribute is not being checked in org.apache.tapestry5.internal.services.ResponseCompressionAnalyzerImpl.isGZipSupported().

      quick fix: provide a service override for ResponseCompressionAnalyzer with a additional check for this.request.getAttribute(InternalConstants.SUPPRESS_COMPRESSION) != null

      reason why we need this: android video playback is crashing when sending gzipped java script files / and or other content. so we want to disable gzip compression for android, even when android supports gzip compression in the Accept-Encoding header.

        Attachments

          Activity

            People

            • Assignee:
              jkemnade Jochen Kemnade
              Reporter:
              felixgonschorek Felix Gonschorek
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: