Uploaded image for project: 'Tapestry 5'
  1. Tapestry 5
  2. TAP5-2264

ResponseCompressionAnalyzerImpl ignores 'tapestry.supress-compression' request attribute for assets and modules

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 5.4
    • 5.4
    • tapestry-core
    • None

    Description

      version: 5.4 alpha29

      for pages and component rendering requests tapestry respects the request attribute org.apache.tapestry5.internal.InternalConstants.SUPPRESS_COMPRESSION.

      for modules and assets the request attribute is not being checked in org.apache.tapestry5.internal.services.ResponseCompressionAnalyzerImpl.isGZipSupported().

      quick fix: provide a service override for ResponseCompressionAnalyzer with a additional check for this.request.getAttribute(InternalConstants.SUPPRESS_COMPRESSION) != null

      reason why we need this: android video playback is crashing when sending gzipped java script files / and or other content. so we want to disable gzip compression for android, even when android supports gzip compression in the Accept-Encoding header.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            jkemnade Jochen Kemnade
            felixgonschorek Felix Gonschorek
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment