Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-693

StatusUpdateTransition in QueryUnitAttempt handles TA_UPDATE incorrectly

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0, 0.9.0
    • Component/s: QueryMaster
    • Labels:
      None

      Description

      I missed some bug in TAJO-638. This patch fixes the bug essentially. StatusUpdateTransition is a multiple-arc transition class. It should return ONLY RUNNING. But, the current implementation can result in wrong state which not described in state machine.

      1. TAJO-693_2.patch
        0.9 kB
        Hyunsik Choi
      2. TAJO-693.patch
        3 kB
        Hyunsik Choi

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-0.8.0-build #30 (See https://builds.apache.org/job/Tajo-0.8.0-build/30/)
        TAJO-693: StatusUpdateTransition in QueryUnitAttempt handles TA_UPDATE incorrectly. (hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=8853acdd3e3f36bb1e070cb9e07851367c841993)

        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryUnitAttempt.java
        • CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.8.0-build #30 (See https://builds.apache.org/job/Tajo-0.8.0-build/30/ ) TAJO-693 : StatusUpdateTransition in QueryUnitAttempt handles TA_UPDATE incorrectly. (hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=8853acdd3e3f36bb1e070cb9e07851367c841993 ) tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryUnitAttempt.java CHANGES.txt
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed it to branch-0.8.0 and master.

        Show
        hyunsik Hyunsik Choi added a comment - committed it to branch-0.8.0 and master.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #125 (See https://builds.apache.org/job/Tajo-master-build/125/)
        TAJO-693: StatusUpdateTransition in QueryUnitAttempt handles TA_UPDATE incorrectly. (hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=7283c586af5d0df675373b25d19c5eabb527e303)

        • CHANGES.txt
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryUnitAttempt.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #125 (See https://builds.apache.org/job/Tajo-master-build/125/ ) TAJO-693 : StatusUpdateTransition in QueryUnitAttempt handles TA_UPDATE incorrectly. (hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=7283c586af5d0df675373b25d19c5eabb527e303 ) CHANGES.txt tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryUnitAttempt.java
        Hide
        jhkim Jinho Kim added a comment -

        +1

        Show
        jhkim Jinho Kim added a comment - +1
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12635753/TAJO-693_2.patch
        against master revision 5f7934e.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 183 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/235//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/235//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/235//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12635753/TAJO-693_2.patch against master revision 5f7934e. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 183 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/235//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/235//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/235//console This message is automatically generated.
        Hide
        hyunsik Hyunsik Choi added a comment -

        Thank you for Jaehwa. I found some problem in the previous patch. So, I submit the updated patch.

        Show
        hyunsik Hyunsik Choi added a comment - Thank you for Jaehwa. I found some problem in the previous patch. So, I submit the updated patch.
        Hide
        blrunner Jaehwa Jung added a comment -

        +1
        'mvn clean install' finished successfully.
        Push it.

        Show
        blrunner Jaehwa Jung added a comment - +1 'mvn clean install' finished successfully. Push it.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12635511/TAJO-693.patch
        against master revision 5f7934e.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 183 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-server tajo-core/tajo-core-backend.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/228//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/228//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/228//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12635511/TAJO-693.patch against master revision 5f7934e. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 183 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-server tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/228//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/228//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/228//console This message is automatically generated.

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development