Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-638

QueryUnitAttempt causes Invalid event error: TA_UPDATE at TA_ASSIGNED

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.8.0, 0.9.0
    • Fix Version/s: 0.8.0, 0.9.0
    • Component/s: None
    • Labels:
      None

      Description

      In TAJO-630, Hyoungjun reported the following error message. According to QueryUnitAttempt class, TA_UPDATE event at TA_ASSIGNED should not incur error. We need to investigate it.

      2014-02-23 22:25:55,617 ERROR querymaster.QueryUnitAttempt (QueryUnitAttempt.java:handle(425)) - Can't handle this event at current state of ta_1393161894205_0001_000004_000101_00)
      org.apache.hadoop.yarn.state.InvalidStateTransitonException: Invalid event: TA_UPDATE at TA_ASSIGNED
              at org.apache.hadoop.yarn.state.StateMachineFactory$MultipleInternalArc.doTransition(StateMachineFactory.java:388)
              at org.apache.hadoop.yarn.state.StateMachineFactory.doTransition(StateMachineFactory.java:302)
              at org.apache.hadoop.yarn.state.StateMachineFactory.access$300(StateMachineFactory.java:46)
              at org.apache.hadoop.yarn.state.StateMachineFactory$InternalStateMachine.doTransition(StateMachineFactory.java:448)
              at org.apache.tajo.master.querymaster.QueryUnitAttempt.handle(QueryUnitAttempt.java:423)
              at org.apache.tajo.master.querymaster.QueryMasterTask$TaskAttemptEventDispatcher.handle(QueryMasterTask.java:241)
              at org.apache.tajo.master.querymaster.QueryMasterTask$TaskAttemptEventDispatcher.handle(QueryMasterTask.java:233)
              at org.apache.tajo.master.TajoAsyncDispatcher.dispatch(TajoAsyncDispatcher.java:137)
              at org.apache.tajo.master.TajoAsyncDispatcher$1.run(TajoAsyncDispatcher.java:79)
      
      1. TAJO-638_2.patch
        1 kB
        Hyunsik Choi
      2. TAJO-638.patch
        2 kB
        Hyunsik Choi

        Activity

        Hide
        hyunsik Hyunsik Choi added a comment -

        Created a review request against branch master in reviewboard

        Show
        hyunsik Hyunsik Choi added a comment - Created a review request against branch master in reviewboard
        Hide
        hyunsik Hyunsik Choi added a comment -

        I've attached the updated patch. In QueryUnitAttempt, the state machine already deals with TA_UPDATE event at TA_ASSIGNED. So, this error must not be incurred at that situation. I don't know the exact problem. I'll continue to observe this problem.

        Regardless of the above issue, this report includes additional issue for error handling. If QueryUnitAttempt faces such a situation, Query will be hang. In order to eliminate the problem, in this patch, I've added some error handling code to QueryUnitAttempt::handle. When a exception occurs in the situation, it will abort the query without hanging.

        Show
        hyunsik Hyunsik Choi added a comment - I've attached the updated patch. In QueryUnitAttempt, the state machine already deals with TA_UPDATE event at TA_ASSIGNED. So, this error must not be incurred at that situation. I don't know the exact problem. I'll continue to observe this problem. Regardless of the above issue, this report includes additional issue for error handling. If QueryUnitAttempt faces such a situation, Query will be hang. In order to eliminate the problem, in this patch, I've added some error handling code to QueryUnitAttempt::handle. When a exception occurs in the situation, it will abort the query without hanging.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12631444/TAJO-638_2.patch
        against master revision 56fbd99.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 178 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/166//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/166//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/166//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12631444/TAJO-638_2.patch against master revision 56fbd99. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 178 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/166//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/166//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/166//console This message is automatically generated.
        Hide
        hyunsik Hyunsik Choi added a comment -

        This issue got +1 on RB. committed to master and 0.8.0.

        Show
        hyunsik Hyunsik Choi added a comment - This issue got +1 on RB. committed to master and 0.8.0.
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Tajo-master-build #92 (See https://builds.apache.org/job/Tajo-master-build/92/)
        TAJO-638: QueryUnitAttempt causes Invalid event error: TA_UPDATE at TA_ASSIGNED. (hyunsik: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=cf27e05724969f6894b169037628d9f50e986948)

        • CHANGES.txt
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryUnitAttempt.java
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Tajo-master-build #92 (See https://builds.apache.org/job/Tajo-master-build/92/ ) TAJO-638 : QueryUnitAttempt causes Invalid event error: TA_UPDATE at TA_ASSIGNED. (hyunsik: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=cf27e05724969f6894b169037628d9f50e986948 ) CHANGES.txt tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryUnitAttempt.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-0.8.0-build #3 (See https://builds.apache.org/job/Tajo-0.8.0-build/3/)
        TAJO-638: ExecutionBlock must be sorted by start time in querydetail.jsp. (hyoungjunkim via hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=f607d882cee6321cb161b8d1e3b95bc110469ea4)

        • CHANGES.txt
        • tajo-core/tajo-core-backend/src/main/resources/webapps/worker/querytasks.jsp
        • tajo-core/tajo-core-backend/src/main/resources/webapps/admin/cluster.jsp
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/util/JSPUtil.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.8.0-build #3 (See https://builds.apache.org/job/Tajo-0.8.0-build/3/ ) TAJO-638 : ExecutionBlock must be sorted by start time in querydetail.jsp. (hyoungjunkim via hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=f607d882cee6321cb161b8d1e3b95bc110469ea4 ) CHANGES.txt tajo-core/tajo-core-backend/src/main/resources/webapps/worker/querytasks.jsp tajo-core/tajo-core-backend/src/main/resources/webapps/admin/cluster.jsp tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/util/JSPUtil.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #96 (See https://builds.apache.org/job/Tajo-master-build/96/)
        TAJO-638: ExecutionBlock must be sorted by start time in querydetail.jsp. (hyoungjunkim via hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=4238dd22d524d87ebbc0200d9a538f2b3f131ca9)

        • CHANGES.txt
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/util/JSPUtil.java
        • tajo-core/tajo-core-backend/src/main/resources/webapps/worker/querytasks.jsp
        • tajo-core/tajo-core-backend/src/main/resources/webapps/admin/cluster.jsp
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #96 (See https://builds.apache.org/job/Tajo-master-build/96/ ) TAJO-638 : ExecutionBlock must be sorted by start time in querydetail.jsp. (hyoungjunkim via hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=4238dd22d524d87ebbc0200d9a538f2b3f131ca9 ) CHANGES.txt tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/util/JSPUtil.java tajo-core/tajo-core-backend/src/main/resources/webapps/worker/querytasks.jsp tajo-core/tajo-core-backend/src/main/resources/webapps/admin/cluster.jsp

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development