Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: Catalog
    • Labels:
      None

      Description

      I renamed JDBC variables in CatalogConstants at TAJO-297. But I think that some users may use deprecated JDBC variables. So, Tajo should supports deprecated JDBC variables in CatalogConstants.

      1. TAJO-313_2.patch
        9 kB
        Jaehwa Jung
      2. TAJO-313_3.patch
        10 kB
        Jaehwa Jung
      3. TAJO-313_4.patch
        10 kB
        Jaehwa Jung
      4. TAJO-313.patch
        8 kB
        Jaehwa Jung

        Activity

        Hide
        blrunner Jaehwa Jung added a comment -

        I've uploaded the patch.
        Please, Check the patch.

        Show
        blrunner Jaehwa Jung added a comment - I've uploaded the patch. Please, Check the patch.
        Hide
        blrunner Jaehwa Jung added a comment -

        I updated the patch.

        Show
        blrunner Jaehwa Jung added a comment - I updated the patch.
        Hide
        blrunner Jaehwa Jung added a comment -

        I added warning log as follows:

        Configuration parameter tajo.catalog.jdbc.connection.id is deprecated. Use tajo.catalog.connection.id instead.
        
        Show
        blrunner Jaehwa Jung added a comment - I added warning log as follows: Configuration parameter tajo.catalog.jdbc.connection.id is deprecated. Use tajo.catalog.connection.id instead.
        Hide
        hyunsik Hyunsik Choi added a comment -

        This patch gone stale. Could you rebase the patch against the recent revision?

        Show
        hyunsik Hyunsik Choi added a comment - This patch gone stale. Could you rebase the patch against the recent revision?
        Hide
        blrunner Jaehwa Jung added a comment -

        I think that a file named 'CHANGES.txt' is in a conflicted state. I updated the patch again. Please, Check the patch.

        Show
        blrunner Jaehwa Jung added a comment - I think that a file named 'CHANGES.txt' is in a conflicted state. I updated the patch again. Please, Check the patch.
        Hide
        jihoonson Jihoon Son added a comment -

        +1.
        This patch looks good to me.

        Show
        jihoonson Jihoon Son added a comment - +1. This patch looks good to me.
        Hide
        blrunner Jaehwa Jung added a comment -

        Thanks Jihoon.
        I've committed now.

        Show
        blrunner Jaehwa Jung added a comment - Thanks Jihoon. I've committed now.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-trunk-postcommit #557 (See https://builds.apache.org/job/Tajo-trunk-postcommit/557/)
        TAJO-313: Support deprecated variables in CatalogConstants. (jaehwa) (jhjung: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=4b12aaafcee7b8849fb9147f0b5b56f0c67d2220)

        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
        • tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestDBStore.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogConstants.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java
        • tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalogConstants.java
        • CHANGES.txt
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-trunk-postcommit #557 (See https://builds.apache.org/job/Tajo-trunk-postcommit/557/ ) TAJO-313 : Support deprecated variables in CatalogConstants. (jaehwa) (jhjung: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=4b12aaafcee7b8849fb9147f0b5b56f0c67d2220 ) tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestDBStore.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogConstants.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalogConstants.java CHANGES.txt tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java

          People

          • Assignee:
            blrunner Jaehwa Jung
            Reporter:
            blrunner Jaehwa Jung
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development