Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: Catalog
    • Labels:
      None

      Description

      Current Catalog supports only jdbc client. But some systems use thrift client to support their meta informations. So, we should support another client besides jdbc client. Therefore, I want to update property names of CatalogConstants.

      1. TAJO-297_2.patch
        13 kB
        Jaehwa Jung
      2. TAJO-297.patch
        13 kB
        Jaehwa Jung

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-trunk-postcommit #551 (See https://builds.apache.org/job/Tajo-trunk-postcommit/551/)
        TAJO-297: Rename JDBC variables in CatalogConstants to be more generic. (jaehwa) (jhjung: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=f4672e10466b361f020c26bad752ca12dc0adf3a)

        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogConstants.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java
        • tajo-core/tajo-core-backend/src/main/resources/catalog-default.xml
        • tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestDBStore.java
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/TajoTestingCluster.java
        • tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java
        • CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-trunk-postcommit #551 (See https://builds.apache.org/job/Tajo-trunk-postcommit/551/ ) TAJO-297 : Rename JDBC variables in CatalogConstants to be more generic. (jaehwa) (jhjung: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=f4672e10466b361f020c26bad752ca12dc0adf3a ) tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogConstants.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java tajo-core/tajo-core-backend/src/main/resources/catalog-default.xml tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestDBStore.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/TajoTestingCluster.java tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java CHANGES.txt
        Hide
        blrunner Jaehwa Jung added a comment -

        I committed the patch yesterday.
        Apache hudson didn't send mail me for building source.
        But my patch applied apache repository successfully and it passed 'mvn clean install'.

        Show
        blrunner Jaehwa Jung added a comment - I committed the patch yesterday. Apache hudson didn't send mail me for building source. But my patch applied apache repository successfully and it passed 'mvn clean install'.
        Hide
        blrunner Jaehwa Jung added a comment -

        Jihoon, Thank you for your review.
        I modified CHANGES.txt, too.

        Show
        blrunner Jaehwa Jung added a comment - Jihoon, Thank you for your review. I modified CHANGES.txt, too.
        Hide
        jihoonson Jihoon Son added a comment -

        Thanks, JaeHwa.
        It passed 'mvn clean verify', and Here is my +1.
        Before you submit the patch, please change the issue title in CHANGES.txt, too.

        Show
        jihoonson Jihoon Son added a comment - Thanks, JaeHwa. It passed 'mvn clean verify', and Here is my +1. Before you submit the patch, please change the issue title in CHANGES.txt, too.
        Hide
        blrunner Jaehwa Jung added a comment -

        Thanks Jihoon.

        I agree with you. I modified the title.

        Show
        blrunner Jaehwa Jung added a comment - Thanks Jihoon. I agree with you. I modified the title.
        Hide
        jihoonson Jihoon Son added a comment -

        I think that the issue title is too comprehensive.
        How about modify the title to represent the changes like "Rename JDBC variables in CatalogConstants to be more generic"?

        Show
        jihoonson Jihoon Son added a comment - I think that the issue title is too comprehensive. How about modify the title to represent the changes like "Rename JDBC variables in CatalogConstants to be more generic"?
        Hide
        blrunner Jaehwa Jung added a comment -

        I've uploaded patch for the issue.

        • changed CatalogConstant property names
          • JDBC_URI : CATALOG_URI
          • JDBC_DRIVER : CATALOG_DRIVER
        • updated CatalogStore and CatalogStoreTest classes
        Show
        blrunner Jaehwa Jung added a comment - I've uploaded patch for the issue. changed CatalogConstant property names JDBC_URI : CATALOG_URI JDBC_DRIVER : CATALOG_DRIVER updated CatalogStore and CatalogStoreTest classes

          People

          • Assignee:
            blrunner Jaehwa Jung
            Reporter:
            blrunner Jaehwa Jung
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development