Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1113

SubQuery in KILLED state should handle unexpected events.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: QueryMaster
    • Labels:
      None

      Description

      Currently, KILLED state in SubQuery does not handle any event. As I mentioned in TAJO-1111, QueryUnit in even terminal states may receive additional unexpected events from a running tasks because a running task reporter sends a progress periodically; that is the report is not synchronized with a task life cycle. As a result, When a killed QueryUnit receives unexpected events, it can cause some event towards SubQuery. But, SubQuery does not handle any addition events if SubQuery is already in KILLED.

      This patch adds some transitions to SubQuery in order to fix the above problem.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hyunsik opened a pull request:

        https://github.com/apache/tajo/pull/199

        TAJO-1113: SubQuery in KILLED state should handle unexpected events.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hyunsik/tajo TAJO-1113

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/199.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #199


        commit 01d8d1a09a2cb7317c6a53f94be18f5d55c47248
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2014-10-11T22:14:04Z

        TAJO-1113: SubQuery in KILLED state should handle unexpected events.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/199 TAJO-1113 : SubQuery in KILLED state should handle unexpected events. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-1113 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/199.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #199 commit 01d8d1a09a2cb7317c6a53f94be18f5d55c47248 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2014-10-11T22:14:04Z TAJO-1113 : SubQuery in KILLED state should handle unexpected events.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user jinossy commented on the pull request:

        https://github.com/apache/tajo/pull/199#issuecomment-58771058

        +1
        The change looks straightforward. Ship it!

        Show
        githubbot ASF GitHub Bot added a comment - Github user jinossy commented on the pull request: https://github.com/apache/tajo/pull/199#issuecomment-58771058 +1 The change looks straightforward. Ship it!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/199#issuecomment-58773588

        Thanks!

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/199#issuecomment-58773588 Thanks!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/199

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/199
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed.

        Show
        hyunsik Hyunsik Choi added a comment - committed.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-CODEGEN-build #52 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/52/)
        TAJO-1113: SubQuery in KILLED state should handle unexpected events. (hyunsik: rev 3d334f3f45443b4d39a4d029de2482e5629a6e10)

        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-CODEGEN-build #52 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/52/ ) TAJO-1113 : SubQuery in KILLED state should handle unexpected events. (hyunsik: rev 3d334f3f45443b4d39a4d029de2482e5629a6e10) CHANGES tajo-core/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #410 (See https://builds.apache.org/job/Tajo-master-build/410/)
        TAJO-1113: SubQuery in KILLED state should handle unexpected events. (hyunsik: rev 3d334f3f45443b4d39a4d029de2482e5629a6e10)

        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #410 (See https://builds.apache.org/job/Tajo-master-build/410/ ) TAJO-1113 : SubQuery in KILLED state should handle unexpected events. (hyunsik: rev 3d334f3f45443b4d39a4d029de2482e5629a6e10) CHANGES tajo-core/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-block_iteration-branch-build #15 (See https://builds.apache.org/job/Tajo-block_iteration-branch-build/15/)
        TAJO-1113: SubQuery in KILLED state should handle unexpected events. (hyunsik: rev 3d334f3f45443b4d39a4d029de2482e5629a6e10)

        • tajo-core/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-block_iteration-branch-build #15 (See https://builds.apache.org/job/Tajo-block_iteration-branch-build/15/ ) TAJO-1113 : SubQuery in KILLED state should handle unexpected events. (hyunsik: rev 3d334f3f45443b4d39a4d029de2482e5629a6e10) tajo-core/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java CHANGES

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development