Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1021

Remove the member variable Builder from all classes inherited from ProtoObject.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: None
    • Labels:
      None

      Description

      Please see TAJO-1020. The member variable Builder can cause some concurrency problem. This is a potential bug. We should remove them in all classes inherited from ProtoObject interface.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user hyunsik opened a pull request:

          https://github.com/apache/tajo/pull/188

          TAJO-1021: Remove the member variable Builder from all classes inherited...

          ... from ProtoObject.

          This patch does not all uses of Builder. A few of classes which are frequently updated during query processing still require proto instance reuses.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/hyunsik/tajo TAJO-1021

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/tajo/pull/188.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #188


          commit 6054ba3b5565e2d5695f4c40cf7e87eadb82954c
          Author: Hyunsik Choi <hyunsik@apache.org>
          Date: 2014-10-07T22:28:48Z

          TAJO-1021: Remove the member variable Builder from all classes inherited from ProtoObject.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/188 TAJO-1021 : Remove the member variable Builder from all classes inherited... ... from ProtoObject. This patch does not all uses of Builder. A few of classes which are frequently updated during query processing still require proto instance reuses. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-1021 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/188.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #188 commit 6054ba3b5565e2d5695f4c40cf7e87eadb82954c Author: Hyunsik Choi <hyunsik@apache.org> Date: 2014-10-07T22:28:48Z TAJO-1021 : Remove the member variable Builder from all classes inherited from ProtoObject.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user blrunner commented on the pull request:

          https://github.com/apache/tajo/pull/188#issuecomment-58308881

          +1

          Thanks @hyunsik
          'mvn clean install' finished successfully.

          Show
          githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/188#issuecomment-58308881 +1 Thanks @hyunsik 'mvn clean install' finished successfully.
          Hide
          hyunsik Hyunsik Choi added a comment -

          I just committed to master branch.

          Show
          hyunsik Hyunsik Choi added a comment - I just committed to master branch.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/tajo/pull/188

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/188
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-master-build #401 (See https://builds.apache.org/job/Tajo-master-build/401/)
          TAJO-1021: Remove the member variable Builder from all classes inherited from ProtoObject. (hyunsik: rev d94727f893bcac2866da4232ee71fe1b435d4759)

          • CHANGES
          • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/ColumnStats.java
          • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/IndexDesc.java
          • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/AlterTableDesc.java
          • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableDesc.java
          • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionMethodDesc.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #401 (See https://builds.apache.org/job/Tajo-master-build/401/ ) TAJO-1021 : Remove the member variable Builder from all classes inherited from ProtoObject. (hyunsik: rev d94727f893bcac2866da4232ee71fe1b435d4759) CHANGES tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/ColumnStats.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/IndexDesc.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/AlterTableDesc.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableDesc.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionMethodDesc.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-master-CODEGEN-build #43 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/43/)
          TAJO-1021: Remove the member variable Builder from all classes inherited from ProtoObject. (hyunsik: rev d94727f893bcac2866da4232ee71fe1b435d4759)

          • CHANGES
          • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableDesc.java
          • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/AlterTableDesc.java
          • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionMethodDesc.java
          • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/ColumnStats.java
          • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/IndexDesc.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-CODEGEN-build #43 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/43/ ) TAJO-1021 : Remove the member variable Builder from all classes inherited from ProtoObject. (hyunsik: rev d94727f893bcac2866da4232ee71fe1b435d4759) CHANGES tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableDesc.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/AlterTableDesc.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionMethodDesc.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/ColumnStats.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/IndexDesc.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-block_iteration-branch-build #15 (See https://builds.apache.org/job/Tajo-block_iteration-branch-build/15/)
          TAJO-1021: Remove the member variable Builder from all classes inherited from ProtoObject. (hyunsik: rev d94727f893bcac2866da4232ee71fe1b435d4759)

          • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/ColumnStats.java
          • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/AlterTableDesc.java
          • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionMethodDesc.java
          • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableDesc.java
          • CHANGES
          • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/IndexDesc.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-block_iteration-branch-build #15 (See https://builds.apache.org/job/Tajo-block_iteration-branch-build/15/ ) TAJO-1021 : Remove the member variable Builder from all classes inherited from ProtoObject. (hyunsik: rev d94727f893bcac2866da4232ee71fe1b435d4759) tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/ColumnStats.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/AlterTableDesc.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionMethodDesc.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableDesc.java CHANGES tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/IndexDesc.java

            People

            • Assignee:
              hyunsik Hyunsik Choi
              Reporter:
              hyunsik Hyunsik Choi
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development