Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-1020

TajoContainerProxy::assignExecutionBlock causes NPE by race condition.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: None
    • Labels:
      None

      Description

      When some classes using KeyValueSet is being used for a concurrent manner. The member variable 'builder' in KeyValueSet causes race condition. As a result, builder can cause NPE.

      This is an urgent issue. Please review it as soon as possible.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hyunsik opened a pull request:

        https://github.com/apache/tajo/pull/127

        TAJO-1020: TajoContainerProxy::assignExecutionBlock causes NPE by race c...

        ...ondition.

        This is an urgent issue. Please review it as soon as possible.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hyunsik/tajo TAJO-1020

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/127.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #127


        commit 7c73116d35a48580fcf25860d5f610c96572b243
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2014-08-27T09:27:07Z

        TAJO-1020: TajoContainerProxy::assignExecutionBlock causes NPE by race condition.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/127 TAJO-1020 : TajoContainerProxy::assignExecutionBlock causes NPE by race c... ...ondition. This is an urgent issue. Please review it as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-1020 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/127.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #127 commit 7c73116d35a48580fcf25860d5f610c96572b243 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2014-08-27T09:27:07Z TAJO-1020 : TajoContainerProxy::assignExecutionBlock causes NPE by race condition.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user babokim commented on the pull request:

        https://github.com/apache/tajo/pull/127#issuecomment-53555888

        +1
        Thanks your contribution, it looks good overall.
        I've tested on the real cluster and All tasks run successfully.

        Show
        githubbot ASF GitHub Bot added a comment - Github user babokim commented on the pull request: https://github.com/apache/tajo/pull/127#issuecomment-53555888 +1 Thanks your contribution, it looks good overall. I've tested on the real cluster and All tasks run successfully.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/127#issuecomment-53556064

        Thank you for the review. I'll commit it shortly.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/127#issuecomment-53556064 Thank you for the review. I'll commit it shortly.
        Hide
        hyunsik Hyunsik Choi added a comment - - edited

        committed. Please update the source code if you work in master branch.

        Show
        hyunsik Hyunsik Choi added a comment - - edited committed. Please update the source code if you work in master branch.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/127

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/127
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #348 (See https://builds.apache.org/job/Tajo-master-build/348/)
        TAJO-1020: TajoContainerProxy::assignExecutionBlock causes NPE by race condition. (hyunsik: rev d3727c73560f4d4c0fd3d2ead84b577e6f3a51b1)

        • tajo-common/src/main/java/org/apache/tajo/util/KeyValueSet.java
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #348 (See https://builds.apache.org/job/Tajo-master-build/348/ ) TAJO-1020 : TajoContainerProxy::assignExecutionBlock causes NPE by race condition. (hyunsik: rev d3727c73560f4d4c0fd3d2ead84b577e6f3a51b1) tajo-common/src/main/java/org/apache/tajo/util/KeyValueSet.java CHANGES

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development