[SVN-4760] Missing children when svnadmin dump --include/exclude converts copy-dir to add-dir

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.10.0
• Component/s: libsvn_repos

Environment

CentOS 6.5

• Assignee: Julian Foad
• Reporter: Nathan.qian
• Created: 04/Jul/18 05:07
• Updated: 05/Oct/23 08:20
• Resolved: 13/Feb/19 10:38

Description

During I am testing the '--include' and '--exclude' options on 'svnadmin dump'  ,  I found that if I copy a non-include file, the  dump result is to add a file with file content; But if the copy is a non-include directory, the dump only adds this directory.

I think, this may be wrong, it should be copy of the directory and all the files under the directory .

 

[root@RD-230 subversion]# svnadmin dump /data1/svnroot/Dev --incremental -r 13386 --include "/CM Action/Tools" > /tmp/test.dmp
 * 已转存版本 13386。

[root@RD-230 subversion]# cat /tmp/test.dmp
 SVN-fs-dump-format-version: 2UUID: 313b818e-f7ce-944b-8d5d-4aca2895b6b9

Revision-number: 13386
 Prop-content-length: 89
 Content-length: 89

K 10
 svn:author
 V 11
 qianhaiyuan
 K 8
 svn:date
 V 27
 2018-07-04T04:18:48.877124Z
 PROPS-END

Node-path: CM Action/Tools/diffcount
 Node-kind: dir
 Node-action: add
 Prop-content-length: 10
 Content-length: 10

PROPS-END

 

In fact, the copy directory has many files. But the dump file is only add a new dir.

Issue Links

• relates to: SVN-4672 Fix svnrdump to handle subtree references
• relates to: SVN-4729 Add '--include' and '--exclude' options to 'svnadmin dump'