Uploaded image for project: 'Subversion'
  1. Subversion
  2. SVN-1908

API: URLs should always be passed around encoded

    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • all
    • 1.6.0
    • unknown
    • None

    Description

      There is no such thing as a "decoded URL" in the real world; part of the point
      of URL encoding is to protect special characters in URL components from being
      interpreted as component separators.  For example,
      svn+ssh://svn%2fuser@foo.bar/path should be interpreted as having a username
      component of "svn/user" when decoded.  If we "decode the whole URL", that fails.
      
      Since we don't really expect cases like this, it's not really a big deal if we
      use "decoded URLs" in our internal processing.  But our API should be more careful.
      
      svn_repos_get_commit_editor is only immediately obvious example of an API which
      violates this property.
      

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              ghudson Greg Hudson
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: