[SUREFIRE-2082] Huge test sets may open too many files

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-M6
• Fix Version/s: 3.0.0-M8
• Component/s: Maven Surefire Plugin
• Labels: patch performance pull-request-available
• Assignee: Tibor Digana
• Reporter: Markus Spann
• Created: 06/May/22 09:22
• Updated: 08/Mar/23 23:49
• Resolved: 09/Jun/22 21:26

Description

Test sets with a very large number of tests (such as a JUnit ParameterizedTest with a large number of test inputs) cause surefire to open a file for stdout and another file for stderr as soon as a test method prints to either of these output streams.

Surefire captures stdout and stderr in temporary files.

These file handles are kept until the very end of the test set (TestSetRunListener.testSetCompleted) which may cause the limit of open files to be reached on a system, resulting in test errors (java.nio.file.FileSystemException, too many open files).

This behavior may have been introduced with the performance improvements of SUREFIRE-1845.

To reproduce, set the maximum allowed open files to a value lower than test iterations in a test class:
ulimit -n <limit>
where limit is the maximum number of open files for a user (Linux).

Issue Links

• duplicates: SUREFIRE-2094 Leaked file descriptors
• is duplicated by: SUREFIRE-2094 Leaked file descriptors
• links to: GitHub Pull Request #531
• links to: GitHub Pull Request #534