Uploaded image for project: 'Maven Surefire'
  1. Maven Surefire
  2. SUREFIRE-1217

Differentiate XML schema for failsafe and surefire

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.19.1
    • Fix Version/s: 2.20
    • Component/s: None
    • Labels:
      None

      Description

      The XML schema introduced in SUREFIRE-964 does not differentiate between surefire and failsafe. Currently they are not different, but in the future they might be.

      Tibor Digana suggested to adapt StatelessXmlReporter in SUREFIRE-1216.

        Activity

        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in maven-surefire #1576 (See https://builds.apache.org/job/maven-surefire/1576/)
        SUREFIRE-1217 Differentiate XML schema for failsafe and surefire (tibor17: rev 71b00149392475a43bef2f0e618e3f5b5a64cdaa)

        • maven-surefire-plugin/src/site/apt/index.apt.vm
        • maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java
        • maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java
        • maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
        • maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporterTest.java
        • maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/StartupReportConfiguration.java
        • maven-surefire-plugin/src/main/java/org/apache/maven/plugin/surefire/SurefirePlugin.java
        • maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/report/DefaultReporterFactoryTest.java
        • maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/DefaultReporterFactory.java
        • maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/CommonReflector.java
        • maven-failsafe-plugin/pom.xml
        Show
        hudson Hudson added a comment - ABORTED: Integrated in maven-surefire #1576 (See https://builds.apache.org/job/maven-surefire/1576/ ) SUREFIRE-1217 Differentiate XML schema for failsafe and surefire (tibor17: rev 71b00149392475a43bef2f0e618e3f5b5a64cdaa) maven-surefire-plugin/src/site/apt/index.apt.vm maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporterTest.java maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/StartupReportConfiguration.java maven-surefire-plugin/src/main/java/org/apache/maven/plugin/surefire/SurefirePlugin.java maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/report/DefaultReporterFactoryTest.java maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/DefaultReporterFactory.java maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/CommonReflector.java maven-failsafe-plugin/pom.xml
        Hide
        mfriedenhagen Mirko Friedenhagen added a comment -

        Sorry, this week was rather busy. Sure thing, I deleted my branch on asf.

        Show
        mfriedenhagen Mirko Friedenhagen added a comment - Sorry, this week was rather busy. Sure thing, I deleted my branch on asf.
        Hide
        tibor17 Tibor Digana added a comment -

        commit 71b00149392475a43bef2f0e618e3f5b5a64cdaa

        Show
        tibor17 Tibor Digana added a comment - commit 71b00149392475a43bef2f0e618e3f5b5a64cdaa
        Hide
        tibor17 Tibor Digana added a comment -

        Mirko Friedenhagen
        I have done it and assigned to me. Is it ok for you?

        Show
        tibor17 Tibor Digana added a comment - Mirko Friedenhagen I have done it and assigned to me. Is it ok for you?
        Hide
        tibor17 Tibor Digana added a comment -

        It's only one in sources maven-surefire-plugin/src/site/resources/xsd/, but two links on the web - surefire and failsafe links.
        yeah, duplicating the file in sources?

        Show
        tibor17 Tibor Digana added a comment - It's only one in sources maven-surefire-plugin/src/site/resources/xsd/, but two links on the web - surefire and failsafe links. yeah, duplicating the file in sources?
        Hide
        mfriedenhagen Mirko Friedenhagen added a comment -

        Strangely enough, I do not find where the XSD is copied for failsafe.

        Show
        mfriedenhagen Mirko Friedenhagen added a comment - Strangely enough, I do not find where the XSD is copied for failsafe.
        Hide
        tibor17 Tibor Digana added a comment -

        yeah, in the future we will maybe split surefire, failsafe, report in three different plugins under maven-plugins repo. Unfortunately maven-plugins repo is GitHub mirror of real SVN repo. Surefire project is already git based project as a mirror at GitHub, so it would be wise to split the projects when possible. Meanwhile we can make this fix and then continue with release of 2.19.2 and 3.0.

        Show
        tibor17 Tibor Digana added a comment - yeah, in the future we will maybe split surefire, failsafe, report in three different plugins under maven-plugins repo. Unfortunately maven-plugins repo is GitHub mirror of real SVN repo. Surefire project is already git based project as a mirror at GitHub, so it would be wise to split the projects when possible. Meanwhile we can make this fix and then continue with release of 2.19.2 and 3.0.

          People

          • Assignee:
            tibor17 Tibor Digana
            Reporter:
            mfriedenhagen Mirko Friedenhagen
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development