[STORM-3580] Config overrides supplied using -c in storm.py not passed to all commands

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0, 2.1.0
• Fix Version/s: 2.2.0, 2.1.1
• Component/s: storm-core
• Labels: pull-request-available
• Assignee: Bipin Prasad
• Reporter: Bipin Prasad
• Created: 10/Feb/20 21:55
• Updated: 01/Jul/20 14:08
• Resolved: 12/Feb/20 22:54

Description

-c is used to supply configuration overide options. Storm.py in the client code converts these overrides into one -Dstorm.options system property. However, this jvm option is not handled properly when the actual command is executed. For example, Rebalance command completely ignores this setting.

Commands that currently process "-c" options:

• Activate - Not Needed
• AdminCommands - Yes
• BasicDrpcClient - Not Needed
• Blobstore - Not Needed
• CLI - Not Needed
• ConfigValue - Yes
• Deactivate - Not Needed
• DevZookeeper - Yes
• DRPCServer - Yes
• GetErrors - Not Needed
• HealthCheck - Yes
• Heartbeats - Yes
• KillTopology - Not Needed
• KillWorkers - Yes
• ListTopologies - Not Needed
• LogViewerServer - Yes
• LocalCluster - Yes
• Monitor - Not Needed
• Nimbus - Yes
• Pacemaker - Yes
• Rebalance - Added as part of this Jira
• SetLogLevel - Not Needed
• ShellSubmission - Yes
• StormSqlRunner - Yes
• Supervisor -Not Needed
• UI - Yes
• UploadCredentials - Yes, but specific options
• VersionsInfo - Not Needed

 

Issue Links

• fixes: STORM-3574 Rebalance should re-computeExecutors so metrics consumers can be added
• links to: GitHub Pull Request #3207