[STORM-3574] Rebalance should re-computeExecutors so metrics consumers can be added

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Not A Problem
• Affects Version/s: 2.1.0
• Component/s: storm-server
• Labels: pull-request-available
• Assignee: Bipin Prasad
• Reporter: Bipin Prasad
• Created: 06/Feb/20 14:44
• Updated: 23/Apr/20 19:16
• Resolved: 23/Apr/20 19:16

Description

Since metrics consumers are a system component and dynamically adding them should be possible with simple configuration change topology.metrics.consumer.register. Currently the computeExecutors or more precisely - StormCommon#startTaskInfo which evaluates this variable is only invoked during startTopology , the rebalance functionality is not starting newer tasks.

We need to ensure rebalance recalculates the idToExecutors again - hopefully only adding new tasks for added executors without removing old ids.

Issue Links

• is fixed by: STORM-3580 Config overrides supplied using -c in storm.py not passed to all commands
• links to: GitHub Pull Request #3203