Uploaded image for project: 'Apache Storm'
  1. Apache Storm
  2. STORM-3094

Topology name needs to be validated at storm-client

    Details

      Description

      Current Behavior : Execute topology with invalid topology name is throwing exception after uploading the jar.

      Improvement : Validating topology name at client side before uploading the jar.

       

       

      2018-06-05 16:16:19.461 o.a.s.d.n.Nimbus pool-21-thread-53 [INFO] Uploading file from client to /manu/Git/storm/storm-dist/binary/final-package/target/apache-storm-2.0.0-SNAPSHOT/storm-local/nimbus/inbox/stormjar-22979659-5176-46fd-9027-ffdde13f595a.jar
      2018-06-05 16:16:20.596 o.a.s.d.n.Nimbus pool-21-thread-35 [INFO] Finished uploading file from client: /manu/Git/storm/storm-dist/binary/final-package/target/apache-storm-2.0.0-SNAPSHOT/storm-local/nimbus/inbox/stormjar-22979659-5176-46fd-9027-ffdde13f595a.jar
      2018-06-05 16:16:20.624 o.a.s.d.n.Nimbus pool-21-thread-29 [INFO] Received topology submission for test-[123] (storm-2.0.0-SNAPSHOT JDK-1.8.0_162) with conf {topology.users=[null], topology.acker.executors=null, storm.zookeeper.superACL=null, topology.workers=3, topology.submitter.principal=, topology.debug=true, topology.name=test-[123], topology.kryo.register={}, storm.id=test-[123]-7-1528195580, topology.kryo.decorators=[], topology.eventlogger.executors=0, topology.submitter.user=mvanam, topology.max.task.parallelism=null}
      2018-06-05 16:16:20.624 o.a.s.d.n.Nimbus pool-21-thread-29 [INFO] uploadedJar /manu/Git/storm/storm-dist/binary/final-package/target/apache-storm-2.0.0-SNAPSHOT/storm-local/nimbus/inbox/stormjar-22979659-5176-46fd-9027-ffdde13f595a.jar
      2018-06-05 16:16:20.624 o.a.s.b.BlobStore pool-21-thread-29 [ERROR] 'test-[123]-7-1528195580-stormjar.jar' does not appear to be valid. It must match ^[\w \t\._-]+$. And it can't be ".", "..", null or empty string.
      2018-06-05 16:16:20.625 o.a.s.b.BlobStore pool-21-thread-29 [ERROR] 'test-[123]-7-1528195580-stormconf.ser' does not appear to be valid. It must match ^[\w \t\._-]+$. And it can't be ".", "..", null or empty string.
      2018-06-05 16:16:20.626 o.a.s.d.n.Nimbus pool-21-thread-29 [WARN] Topology submission exception. (topology name='test-[123]')
      java.lang.IllegalArgumentException: test-[123]-7-1528195580-stormconf.ser does not appear to be a valid blob key
       at org.apache.storm.blobstore.BlobStore.validateKey(BlobStore.java:66) ~[storm-client-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]

       

       

        Attachments

        1. patch.diff
          5 kB
          Manohar Vanam

          Activity

            People

            • Assignee:
              ManoharVanam Manohar Vanam
              Reporter:
              ManoharVanam Manohar Vanam
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 2h
                2h