[STORM-3094] Topology name needs to be validated at storm-client

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.0, 1.1.3, 1.2.2
• Fix Version/s: 2.0.0, 1.2.3, 1.1.4
• Component/s: storm-client
• Labels: pull-request-available
• Assignee: Manohar Vanam
• Reporter: Manohar Vanam
• Created: 05/Jun/18 11:27
• Updated: 17/Jun/18 16:25
• Resolved: 13/Jun/18 13:00

Description

Current Behavior : Execute topology with invalid topology name is throwing exception after uploading the jar.

Improvement : Validating topology name at client side before uploading the jar.

 

 

2018-06-05 16:16:19.461 o.a.s.d.n.Nimbus pool-21-thread-53 [INFO] Uploading file from client to /manu/Git/storm/storm-dist/binary/final-package/target/apache-storm-2.0.0-SNAPSHOT/storm-local/nimbus/inbox/stormjar-22979659-5176-46fd-9027-ffdde13f595a.jar
2018-06-05 16:16:20.596 o.a.s.d.n.Nimbus pool-21-thread-35 [INFO] Finished uploading file from client: /manu/Git/storm/storm-dist/binary/final-package/target/apache-storm-2.0.0-SNAPSHOT/storm-local/nimbus/inbox/stormjar-22979659-5176-46fd-9027-ffdde13f595a.jar
2018-06-05 16:16:20.624 o.a.s.d.n.Nimbus pool-21-thread-29 [INFO] Received topology submission for test-[123] (storm-2.0.0-SNAPSHOT JDK-1.8.0_162) with conf {topology.users=[null], topology.acker.executors=null, storm.zookeeper.superACL=null, topology.workers=3, topology.submitter.principal=, topology.debug=true, topology.name=test-[123], topology.kryo.register={}, storm.id=test-[123]-7-1528195580, topology.kryo.decorators=[], topology.eventlogger.executors=0, topology.submitter.user=mvanam, topology.max.task.parallelism=null}
2018-06-05 16:16:20.624 o.a.s.d.n.Nimbus pool-21-thread-29 [INFO] uploadedJar /manu/Git/storm/storm-dist/binary/final-package/target/apache-storm-2.0.0-SNAPSHOT/storm-local/nimbus/inbox/stormjar-22979659-5176-46fd-9027-ffdde13f595a.jar
2018-06-05 16:16:20.624 o.a.s.b.BlobStore pool-21-thread-29 [ERROR] 'test-[123]-7-1528195580-stormjar.jar' does not appear to be valid. It must match ^[\w \t\._-]+$. And it can't be ".", "..", null or empty string.
2018-06-05 16:16:20.625 o.a.s.b.BlobStore pool-21-thread-29 [ERROR] 'test-[123]-7-1528195580-stormconf.ser' does not appear to be valid. It must match ^[\w \t\._-]+$. And it can't be ".", "..", null or empty string.
2018-06-05 16:16:20.626 o.a.s.d.n.Nimbus pool-21-thread-29 [WARN] Topology submission exception. (topology name='test-[123]')
java.lang.IllegalArgumentException: test-[123]-7-1528195580-stormconf.ser does not appear to be a valid blob key
 at org.apache.storm.blobstore.BlobStore.validateKey(BlobStore.java:66) ~[storm-client-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]

 

 

Issue Links

• links to: GitHub Pull Request #2703
• links to: GitHub Pull Request #2713