Uploaded image for project: 'Apache Storm'
  1. Apache Storm
  2. STORM-1842

Forward references in storm.thrift cause tooling issues

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Critical
    • Resolution: Fixed
    • 1.0.0, 1.0.1
    • 2.0.0, 1.0.2, 1.1.0
    • storm-core
    • None

    Description

      In recent versions of Storm (starting with version 1.0.0, I believe), storm.thrift uses several types before they are declared:

      • HBPulse
      • HBRecords
      • HBNodes

      These types are used in the definition of HBMessageData.

      This causes issues with downstream tools. For example, generating Python wrappers for the Storm Thrift types creates a module that will not import successfully.

      Would it be possible to reorder this code to define the types before using them? This appears to be a simple change.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            kabhwan Jungtaek Lim
            barrywhart Barry Hart
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Issue deployment