[STORM-1842] Forward references in storm.thrift cause tooling issues

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.0.0, 1.0.1
• Fix Version/s: 2.0.0, 1.0.2, 1.1.0
• Component/s: storm-core
• Epic Link: Release Apache Storm 1.0.2
• Assignee: Jungtaek Lim
• Reporter: Barry Hart
• Created: 17/May/16 01:03
• Updated: 23/May/16 04:19
• Resolved: 20/May/16 18:15

Description

In recent versions of Storm (starting with version 1.0.0, I believe), storm.thrift uses several types before they are declared:

• HBPulse
• HBRecords
• HBNodes

These types are used in the definition of HBMessageData.

This causes issues with downstream tools. For example, generating Python wrappers for the Storm Thrift types creates a module that will not import successfully.

Would it be possible to reorder this code to define the types before using them? This appears to be a simple change.

Issue Links

• relates to: STORM-1846 Need a smoke test for the generated Python code
• links to: GitHub Pull Request #1423
• links to: GitHub Pull Request #1424
• links to: GitHub Pull Request #1425
• links to: GitHub Pull Request #1434