Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4.0-incubating
    • Component/s: None
    • Labels:
      None

      Description

      Refer to SQOOP-371 for details.

      1. SQOOP-377-2.patch
        222 kB
        Arvind Prabhakar

        Activity

        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2589/
        -----------------------------------------------------------

        Review request for Sqoop and Bilung Lee.

        Summary
        -------

        Migrated the mapreduce.db package to org.apache.sqoop namespace.

        This addresses bug SQOOP-377.
        https://issues.apache.org/jira/browse/SQOOP-377

        Diffs


        /src/java/com/cloudera/sqoop/mapreduce/db/BigDecimalSplitter.java 1189822
        /src/java/com/cloudera/sqoop/mapreduce/db/BooleanSplitter.java 1189822
        /src/java/com/cloudera/sqoop/mapreduce/db/DBConfiguration.java 1189822
        /src/java/com/cloudera/sqoop/mapreduce/db/DBInputFormat.java 1189822
        /src/java/com/cloudera/sqoop/mapreduce/db/DBOutputFormat.java 1189822
        /src/java/com/cloudera/sqoop/mapreduce/db/DBRecordReader.java 1189822
        /src/java/com/cloudera/sqoop/mapreduce/db/DBSplitter.java 1189822
        /src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBInputFormat.java 1189822
        /src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBRecordReader.java 1189822
        /src/java/com/cloudera/sqoop/mapreduce/db/DateSplitter.java 1189822
        /src/java/com/cloudera/sqoop/mapreduce/db/FloatSplitter.java 1189822
        /src/java/com/cloudera/sqoop/mapreduce/db/IntegerSplitter.java 1189822
        /src/java/com/cloudera/sqoop/mapreduce/db/OracleDBRecordReader.java 1189822
        /src/java/com/cloudera/sqoop/mapreduce/db/OracleDataDrivenDBInputFormat.java 1189822
        /src/java/com/cloudera/sqoop/mapreduce/db/OracleDataDrivenDBRecordReader.java 1189822
        /src/java/com/cloudera/sqoop/mapreduce/db/OracleDateSplitter.java 1189822
        /src/java/com/cloudera/sqoop/mapreduce/db/TextSplitter.java 1189822
        /src/java/org/apache/sqoop/mapreduce/db/BigDecimalSplitter.java PRE-CREATION
        /src/java/org/apache/sqoop/mapreduce/db/BooleanSplitter.java PRE-CREATION
        /src/java/org/apache/sqoop/mapreduce/db/DBConfiguration.java PRE-CREATION
        /src/java/org/apache/sqoop/mapreduce/db/DBInputFormat.java PRE-CREATION
        /src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java PRE-CREATION
        /src/java/org/apache/sqoop/mapreduce/db/DBRecordReader.java PRE-CREATION
        /src/java/org/apache/sqoop/mapreduce/db/DBSplitter.java PRE-CREATION
        /src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java PRE-CREATION
        /src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBRecordReader.java PRE-CREATION
        /src/java/org/apache/sqoop/mapreduce/db/DateSplitter.java PRE-CREATION
        /src/java/org/apache/sqoop/mapreduce/db/FloatSplitter.java PRE-CREATION
        /src/java/org/apache/sqoop/mapreduce/db/IntegerSplitter.java PRE-CREATION
        /src/java/org/apache/sqoop/mapreduce/db/OracleDBRecordReader.java PRE-CREATION
        /src/java/org/apache/sqoop/mapreduce/db/OracleDataDrivenDBInputFormat.java PRE-CREATION
        /src/java/org/apache/sqoop/mapreduce/db/OracleDataDrivenDBRecordReader.java PRE-CREATION
        /src/java/org/apache/sqoop/mapreduce/db/OracleDateSplitter.java PRE-CREATION
        /src/java/org/apache/sqoop/mapreduce/db/TextSplitter.java PRE-CREATION
        /src/test/com/cloudera/sqoop/mapreduce/db/TestIntegerSplitter.java 1189822
        /src/test/com/cloudera/sqoop/mapreduce/db/TestTextSplitter.java 1189822
        /src/test/org/apache/sqoop/mapreduce/db/TestIntegerSplitter.java PRE-CREATION
        /src/test/org/apache/sqoop/mapreduce/db/TestTextSplitter.java PRE-CREATION

        Diff: https://reviews.apache.org/r/2589/diff

        Testing
        -------

        Ran all unit and thirdparty tests.

        Thanks,

        Arvind

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2589/ ----------------------------------------------------------- Review request for Sqoop and Bilung Lee. Summary ------- Migrated the mapreduce.db package to org.apache.sqoop namespace. This addresses bug SQOOP-377 . https://issues.apache.org/jira/browse/SQOOP-377 Diffs /src/java/com/cloudera/sqoop/mapreduce/db/BigDecimalSplitter.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/BooleanSplitter.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/DBConfiguration.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/DBInputFormat.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/DBOutputFormat.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/DBRecordReader.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/DBSplitter.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBInputFormat.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBRecordReader.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/DateSplitter.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/FloatSplitter.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/IntegerSplitter.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/OracleDBRecordReader.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/OracleDataDrivenDBInputFormat.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/OracleDataDrivenDBRecordReader.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/OracleDateSplitter.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/TextSplitter.java 1189822 /src/java/org/apache/sqoop/mapreduce/db/BigDecimalSplitter.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/BooleanSplitter.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/DBConfiguration.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/DBInputFormat.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/DBRecordReader.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/DBSplitter.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBRecordReader.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/DateSplitter.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/FloatSplitter.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/IntegerSplitter.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/OracleDBRecordReader.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/OracleDataDrivenDBInputFormat.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/OracleDataDrivenDBRecordReader.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/OracleDateSplitter.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/TextSplitter.java PRE-CREATION /src/test/com/cloudera/sqoop/mapreduce/db/TestIntegerSplitter.java 1189822 /src/test/com/cloudera/sqoop/mapreduce/db/TestTextSplitter.java 1189822 /src/test/org/apache/sqoop/mapreduce/db/TestIntegerSplitter.java PRE-CREATION /src/test/org/apache/sqoop/mapreduce/db/TestTextSplitter.java PRE-CREATION Diff: https://reviews.apache.org/r/2589/diff Testing ------- Ran all unit and thirdparty tests. Thanks, Arvind
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2589/#review2901
        -----------------------------------------------------------

        Thanks for the patch, Arvind! Only two comments.

        /src/java/com/cloudera/sqoop/mapreduce/db/BooleanSplitter.java
        <https://reviews.apache.org/r/2589/#comment6481>

        Remove copyright notice.

        /src/java/com/cloudera/sqoop/mapreduce/db/DBOutputFormat.java
        <https://reviews.apache.org/r/2589/#comment6482>

        Add @deprecated tag.

        • Bilung

        On 2011-10-27 20:41:29, Arvind Prabhakar wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2589/

        -----------------------------------------------------------

        (Updated 2011-10-27 20:41:29)

        Review request for Sqoop and Bilung Lee.

        Summary

        -------

        Migrated the mapreduce.db package to org.apache.sqoop namespace.

        This addresses bug SQOOP-377.

        https://issues.apache.org/jira/browse/SQOOP-377

        Diffs

        -----

        /src/java/com/cloudera/sqoop/mapreduce/db/BigDecimalSplitter.java 1189822

        /src/java/com/cloudera/sqoop/mapreduce/db/BooleanSplitter.java 1189822

        /src/java/com/cloudera/sqoop/mapreduce/db/DBConfiguration.java 1189822

        /src/java/com/cloudera/sqoop/mapreduce/db/DBInputFormat.java 1189822

        /src/java/com/cloudera/sqoop/mapreduce/db/DBOutputFormat.java 1189822

        /src/java/com/cloudera/sqoop/mapreduce/db/DBRecordReader.java 1189822

        /src/java/com/cloudera/sqoop/mapreduce/db/DBSplitter.java 1189822

        /src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBInputFormat.java 1189822

        /src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBRecordReader.java 1189822

        /src/java/com/cloudera/sqoop/mapreduce/db/DateSplitter.java 1189822

        /src/java/com/cloudera/sqoop/mapreduce/db/FloatSplitter.java 1189822

        /src/java/com/cloudera/sqoop/mapreduce/db/IntegerSplitter.java 1189822

        /src/java/com/cloudera/sqoop/mapreduce/db/OracleDBRecordReader.java 1189822

        /src/java/com/cloudera/sqoop/mapreduce/db/OracleDataDrivenDBInputFormat.java 1189822

        /src/java/com/cloudera/sqoop/mapreduce/db/OracleDataDrivenDBRecordReader.java 1189822

        /src/java/com/cloudera/sqoop/mapreduce/db/OracleDateSplitter.java 1189822

        /src/java/com/cloudera/sqoop/mapreduce/db/TextSplitter.java 1189822

        /src/java/org/apache/sqoop/mapreduce/db/BigDecimalSplitter.java PRE-CREATION

        /src/java/org/apache/sqoop/mapreduce/db/BooleanSplitter.java PRE-CREATION

        /src/java/org/apache/sqoop/mapreduce/db/DBConfiguration.java PRE-CREATION

        /src/java/org/apache/sqoop/mapreduce/db/DBInputFormat.java PRE-CREATION

        /src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java PRE-CREATION

        /src/java/org/apache/sqoop/mapreduce/db/DBRecordReader.java PRE-CREATION

        /src/java/org/apache/sqoop/mapreduce/db/DBSplitter.java PRE-CREATION

        /src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java PRE-CREATION

        /src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBRecordReader.java PRE-CREATION

        /src/java/org/apache/sqoop/mapreduce/db/DateSplitter.java PRE-CREATION

        /src/java/org/apache/sqoop/mapreduce/db/FloatSplitter.java PRE-CREATION

        /src/java/org/apache/sqoop/mapreduce/db/IntegerSplitter.java PRE-CREATION

        /src/java/org/apache/sqoop/mapreduce/db/OracleDBRecordReader.java PRE-CREATION

        /src/java/org/apache/sqoop/mapreduce/db/OracleDataDrivenDBInputFormat.java PRE-CREATION

        /src/java/org/apache/sqoop/mapreduce/db/OracleDataDrivenDBRecordReader.java PRE-CREATION

        /src/java/org/apache/sqoop/mapreduce/db/OracleDateSplitter.java PRE-CREATION

        /src/java/org/apache/sqoop/mapreduce/db/TextSplitter.java PRE-CREATION

        /src/test/com/cloudera/sqoop/mapreduce/db/TestIntegerSplitter.java 1189822

        /src/test/com/cloudera/sqoop/mapreduce/db/TestTextSplitter.java 1189822

        /src/test/org/apache/sqoop/mapreduce/db/TestIntegerSplitter.java PRE-CREATION

        /src/test/org/apache/sqoop/mapreduce/db/TestTextSplitter.java PRE-CREATION

        Diff: https://reviews.apache.org/r/2589/diff

        Testing

        -------

        Ran all unit and thirdparty tests.

        Thanks,

        Arvind

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2589/#review2901 ----------------------------------------------------------- Thanks for the patch, Arvind! Only two comments. /src/java/com/cloudera/sqoop/mapreduce/db/BooleanSplitter.java < https://reviews.apache.org/r/2589/#comment6481 > Remove copyright notice. /src/java/com/cloudera/sqoop/mapreduce/db/DBOutputFormat.java < https://reviews.apache.org/r/2589/#comment6482 > Add @deprecated tag. Bilung On 2011-10-27 20:41:29, Arvind Prabhakar wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2589/ ----------------------------------------------------------- (Updated 2011-10-27 20:41:29) Review request for Sqoop and Bilung Lee. Summary ------- Migrated the mapreduce.db package to org.apache.sqoop namespace. This addresses bug SQOOP-377 . https://issues.apache.org/jira/browse/SQOOP-377 Diffs ----- /src/java/com/cloudera/sqoop/mapreduce/db/BigDecimalSplitter.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/BooleanSplitter.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/DBConfiguration.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/DBInputFormat.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/DBOutputFormat.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/DBRecordReader.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/DBSplitter.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBInputFormat.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBRecordReader.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/DateSplitter.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/FloatSplitter.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/IntegerSplitter.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/OracleDBRecordReader.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/OracleDataDrivenDBInputFormat.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/OracleDataDrivenDBRecordReader.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/OracleDateSplitter.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/TextSplitter.java 1189822 /src/java/org/apache/sqoop/mapreduce/db/BigDecimalSplitter.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/BooleanSplitter.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/DBConfiguration.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/DBInputFormat.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/DBRecordReader.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/DBSplitter.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBRecordReader.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/DateSplitter.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/FloatSplitter.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/IntegerSplitter.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/OracleDBRecordReader.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/OracleDataDrivenDBInputFormat.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/OracleDataDrivenDBRecordReader.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/OracleDateSplitter.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/TextSplitter.java PRE-CREATION /src/test/com/cloudera/sqoop/mapreduce/db/TestIntegerSplitter.java 1189822 /src/test/com/cloudera/sqoop/mapreduce/db/TestTextSplitter.java 1189822 /src/test/org/apache/sqoop/mapreduce/db/TestIntegerSplitter.java PRE-CREATION /src/test/org/apache/sqoop/mapreduce/db/TestTextSplitter.java PRE-CREATION Diff: https://reviews.apache.org/r/2589/diff Testing ------- Ran all unit and thirdparty tests. Thanks, Arvind
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2589/
        -----------------------------------------------------------

        (Updated 2011-10-28 15:38:03.522052)

        Review request for Sqoop and Bilung Lee.

        Changes
        -------

        Thanks for the review Bilung. Attaching the updated diff.

        Summary
        -------

        Migrated the mapreduce.db package to org.apache.sqoop namespace.

        This addresses bug SQOOP-377.
        https://issues.apache.org/jira/browse/SQOOP-377

        Diffs (updated)


        /src/java/com/cloudera/sqoop/mapreduce/db/BigDecimalSplitter.java 1189822
        /src/java/com/cloudera/sqoop/mapreduce/db/BooleanSplitter.java 1189822
        /src/java/com/cloudera/sqoop/mapreduce/db/DBConfiguration.java 1189822
        /src/java/com/cloudera/sqoop/mapreduce/db/DBInputFormat.java 1189822
        /src/java/com/cloudera/sqoop/mapreduce/db/DBOutputFormat.java 1189822
        /src/java/com/cloudera/sqoop/mapreduce/db/DBRecordReader.java 1189822
        /src/java/com/cloudera/sqoop/mapreduce/db/DBSplitter.java 1189822
        /src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBInputFormat.java 1189822
        /src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBRecordReader.java 1189822
        /src/java/com/cloudera/sqoop/mapreduce/db/DateSplitter.java 1189822
        /src/java/com/cloudera/sqoop/mapreduce/db/FloatSplitter.java 1189822
        /src/java/com/cloudera/sqoop/mapreduce/db/IntegerSplitter.java 1189822
        /src/java/com/cloudera/sqoop/mapreduce/db/OracleDBRecordReader.java 1189822
        /src/java/com/cloudera/sqoop/mapreduce/db/OracleDataDrivenDBInputFormat.java 1189822
        /src/java/com/cloudera/sqoop/mapreduce/db/OracleDataDrivenDBRecordReader.java 1189822
        /src/java/com/cloudera/sqoop/mapreduce/db/OracleDateSplitter.java 1189822
        /src/java/com/cloudera/sqoop/mapreduce/db/TextSplitter.java 1189822
        /src/java/org/apache/sqoop/mapreduce/db/BigDecimalSplitter.java PRE-CREATION
        /src/java/org/apache/sqoop/mapreduce/db/BooleanSplitter.java PRE-CREATION
        /src/java/org/apache/sqoop/mapreduce/db/DBConfiguration.java PRE-CREATION
        /src/java/org/apache/sqoop/mapreduce/db/DBInputFormat.java PRE-CREATION
        /src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java PRE-CREATION
        /src/java/org/apache/sqoop/mapreduce/db/DBRecordReader.java PRE-CREATION
        /src/java/org/apache/sqoop/mapreduce/db/DBSplitter.java PRE-CREATION
        /src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java PRE-CREATION
        /src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBRecordReader.java PRE-CREATION
        /src/java/org/apache/sqoop/mapreduce/db/DateSplitter.java PRE-CREATION
        /src/java/org/apache/sqoop/mapreduce/db/FloatSplitter.java PRE-CREATION
        /src/java/org/apache/sqoop/mapreduce/db/IntegerSplitter.java PRE-CREATION
        /src/java/org/apache/sqoop/mapreduce/db/OracleDBRecordReader.java PRE-CREATION
        /src/java/org/apache/sqoop/mapreduce/db/OracleDataDrivenDBInputFormat.java PRE-CREATION
        /src/java/org/apache/sqoop/mapreduce/db/OracleDataDrivenDBRecordReader.java PRE-CREATION
        /src/java/org/apache/sqoop/mapreduce/db/OracleDateSplitter.java PRE-CREATION
        /src/java/org/apache/sqoop/mapreduce/db/TextSplitter.java PRE-CREATION
        /src/test/com/cloudera/sqoop/mapreduce/db/TestIntegerSplitter.java 1189822
        /src/test/com/cloudera/sqoop/mapreduce/db/TestTextSplitter.java 1189822
        /src/test/org/apache/sqoop/mapreduce/db/TestIntegerSplitter.java PRE-CREATION
        /src/test/org/apache/sqoop/mapreduce/db/TestTextSplitter.java PRE-CREATION

        Diff: https://reviews.apache.org/r/2589/diff

        Testing
        -------

        Ran all unit and thirdparty tests.

        Thanks,

        Arvind

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2589/ ----------------------------------------------------------- (Updated 2011-10-28 15:38:03.522052) Review request for Sqoop and Bilung Lee. Changes ------- Thanks for the review Bilung. Attaching the updated diff. Summary ------- Migrated the mapreduce.db package to org.apache.sqoop namespace. This addresses bug SQOOP-377 . https://issues.apache.org/jira/browse/SQOOP-377 Diffs (updated) /src/java/com/cloudera/sqoop/mapreduce/db/BigDecimalSplitter.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/BooleanSplitter.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/DBConfiguration.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/DBInputFormat.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/DBOutputFormat.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/DBRecordReader.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/DBSplitter.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBInputFormat.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBRecordReader.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/DateSplitter.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/FloatSplitter.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/IntegerSplitter.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/OracleDBRecordReader.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/OracleDataDrivenDBInputFormat.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/OracleDataDrivenDBRecordReader.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/OracleDateSplitter.java 1189822 /src/java/com/cloudera/sqoop/mapreduce/db/TextSplitter.java 1189822 /src/java/org/apache/sqoop/mapreduce/db/BigDecimalSplitter.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/BooleanSplitter.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/DBConfiguration.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/DBInputFormat.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/DBRecordReader.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/DBSplitter.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBRecordReader.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/DateSplitter.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/FloatSplitter.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/IntegerSplitter.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/OracleDBRecordReader.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/OracleDataDrivenDBInputFormat.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/OracleDataDrivenDBRecordReader.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/OracleDateSplitter.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/db/TextSplitter.java PRE-CREATION /src/test/com/cloudera/sqoop/mapreduce/db/TestIntegerSplitter.java 1189822 /src/test/com/cloudera/sqoop/mapreduce/db/TestTextSplitter.java 1189822 /src/test/org/apache/sqoop/mapreduce/db/TestIntegerSplitter.java PRE-CREATION /src/test/org/apache/sqoop/mapreduce/db/TestTextSplitter.java PRE-CREATION Diff: https://reviews.apache.org/r/2589/diff Testing ------- Ran all unit and thirdparty tests. Thanks, Arvind
        Hide
        Hudson added a comment -

        Integrated in Sqoop-jdk-1.6 #47 (See https://builds.apache.org/job/Sqoop-jdk-1.6/47/)
        SQOOP-377 Migrate mapreduce.db package to new name space

        blee : http://svn.apache.org/viewvc/?view=rev&rev=1190441
        Files :

        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/db/BigDecimalSplitter.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/db/BooleanSplitter.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/db/DBConfiguration.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/db/DBInputFormat.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/db/DBOutputFormat.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/db/DBRecordReader.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/db/DBSplitter.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBInputFormat.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBRecordReader.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/db/DateSplitter.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/db/FloatSplitter.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/db/IntegerSplitter.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/db/OracleDBRecordReader.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/db/OracleDataDrivenDBInputFormat.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/db/OracleDataDrivenDBRecordReader.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/db/OracleDateSplitter.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/db/TextSplitter.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/BigDecimalSplitter.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/BooleanSplitter.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/DBConfiguration.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/DBInputFormat.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/DBRecordReader.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/DBSplitter.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBRecordReader.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/DateSplitter.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/FloatSplitter.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/IntegerSplitter.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/OracleDBRecordReader.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/OracleDataDrivenDBInputFormat.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/OracleDataDrivenDBRecordReader.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/OracleDateSplitter.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/TextSplitter.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/mapreduce/db/TestIntegerSplitter.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/mapreduce/db/TestTextSplitter.java
        • /incubator/sqoop/trunk/src/test/org/apache/sqoop
        • /incubator/sqoop/trunk/src/test/org/apache/sqoop/mapreduce
        • /incubator/sqoop/trunk/src/test/org/apache/sqoop/mapreduce/db
        • /incubator/sqoop/trunk/src/test/org/apache/sqoop/mapreduce/db/TestIntegerSplitter.java
        • /incubator/sqoop/trunk/src/test/org/apache/sqoop/mapreduce/db/TestTextSplitter.java
        Show
        Hudson added a comment - Integrated in Sqoop-jdk-1.6 #47 (See https://builds.apache.org/job/Sqoop-jdk-1.6/47/ ) SQOOP-377 Migrate mapreduce.db package to new name space blee : http://svn.apache.org/viewvc/?view=rev&rev=1190441 Files : /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/db/BigDecimalSplitter.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/db/BooleanSplitter.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/db/DBConfiguration.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/db/DBInputFormat.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/db/DBOutputFormat.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/db/DBRecordReader.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/db/DBSplitter.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBInputFormat.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBRecordReader.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/db/DateSplitter.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/db/FloatSplitter.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/db/IntegerSplitter.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/db/OracleDBRecordReader.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/db/OracleDataDrivenDBInputFormat.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/db/OracleDataDrivenDBRecordReader.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/db/OracleDateSplitter.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/db/TextSplitter.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/BigDecimalSplitter.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/BooleanSplitter.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/DBConfiguration.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/DBInputFormat.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/DBRecordReader.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/DBSplitter.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBRecordReader.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/DateSplitter.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/FloatSplitter.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/IntegerSplitter.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/OracleDBRecordReader.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/OracleDataDrivenDBInputFormat.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/OracleDataDrivenDBRecordReader.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/OracleDateSplitter.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/TextSplitter.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/mapreduce/db/TestIntegerSplitter.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/mapreduce/db/TestTextSplitter.java /incubator/sqoop/trunk/src/test/org/apache/sqoop /incubator/sqoop/trunk/src/test/org/apache/sqoop/mapreduce /incubator/sqoop/trunk/src/test/org/apache/sqoop/mapreduce/db /incubator/sqoop/trunk/src/test/org/apache/sqoop/mapreduce/db/TestIntegerSplitter.java /incubator/sqoop/trunk/src/test/org/apache/sqoop/mapreduce/db/TestTextSplitter.java
        Hide
        Bilung Lee added a comment -

        Patch committed. Thanks, Arvind!

        Show
        Bilung Lee added a comment - Patch committed. Thanks, Arvind!

          People

          • Assignee:
            Arvind Prabhakar
            Reporter:
            Bilung Lee
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development