Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4.0-incubating
    • Component/s: None
    • Labels:
      None

      Description

      1. Namespace migration ( see https://cwiki.apache.org/confluence/display/SQOOP/Namespace+Migration for details ):

      • Create the new package under org.apache.sqoop namespace.
      • Move logics from com.cloudera.sqoop classes to org.apache.sqoop classes.
      • Let com.cloudera.sqoop classes inherit logics from org.apache.sqoop classes.
      • Deprecate classes under com.cloudera.sqoop namespace.

      2. Remove copyright notice in the header ( as dictated in http://www.apache.org/legal/src-headers.html ):

      • Remove this line "Copyright 2011 The Apache Software Foundation" in the license header.
      • NOTE that checkstyle is revised to accommodate the license header without copyright.
        As a result, it will complain all other files until they are also migrated with
        the new license header (without copyright).
      1. SQOOP-371.patch
        143 kB
        Bilung Lee

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        4d 22h 15m 1 Arvind Prabhakar 25/Oct/11 22:17
        Bilung Lee made changes -
        Description 1. Namespace migration (see https://cwiki.apache.org/confluence/display/SQOOP/Namespace+Migration for details):
           - Create the new package under org.apache.sqoop namespace.
           - Move logics from com.cloudera.sqoop classes to org.apache.sqoop classes.
           - Let com.cloudera.sqoop classes inherit logics from org.apache.sqoop classes.
           - Deprecate classes under com.cloudera.sqoop namespace.

        2. Remove copyright notice in the header (as dictated in http://www.apache.org/legal/src-headers.html):
           - Remove this line "Copyright 2011 The Apache Software Foundation" in the license header.
           - NOTE that checkstyle is revised to accommodate the license header without copyright.
             As a result, it will complain all other files until they are also migrated with
             the new license header (without copyright).
        1. Namespace migration ( see https://cwiki.apache.org/confluence/display/SQOOP/Namespace+Migration for details ):
           - Create the new package under org.apache.sqoop namespace.
           - Move logics from com.cloudera.sqoop classes to org.apache.sqoop classes.
           - Let com.cloudera.sqoop classes inherit logics from org.apache.sqoop classes.
           - Deprecate classes under com.cloudera.sqoop namespace.

        2. Remove copyright notice in the header ( as dictated in http://www.apache.org/legal/src-headers.html ):
           - Remove this line "Copyright 2011 The Apache Software Foundation" in the license header.
           - NOTE that checkstyle is revised to accommodate the license header without copyright.
             As a result, it will complain all other files until they are also migrated with
             the new license header (without copyright).
        Bilung Lee made changes -
        Description 1. Create the new package under org.apache.sqoop namespace.
        2. Move logics from com.cloudera.sqoop classes to org.apache.sqoop classes.
        3. Let com.cloudera.sqoop classes inherit logics from org.apache.sqoop classes.
        4. Deprecate classes under com.cloudera.sqoop namespace.

        Also remove copyright notice in the header (http://www.apache.org/legal/src-headers.html). I.e. remove this line "Copyright 2011 The Apache Software Foundation" in the license header. NOTE that checkstyle is revised to accommodate the license header without copyright. As a result, it will complain all other files until they are also migrated with the new license header (without copyright).
        1. Namespace migration (see https://cwiki.apache.org/confluence/display/SQOOP/Namespace+Migration for details):
           - Create the new package under org.apache.sqoop namespace.
           - Move logics from com.cloudera.sqoop classes to org.apache.sqoop classes.
           - Let com.cloudera.sqoop classes inherit logics from org.apache.sqoop classes.
           - Deprecate classes under com.cloudera.sqoop namespace.

        2. Remove copyright notice in the header (as dictated in http://www.apache.org/legal/src-headers.html):
           - Remove this line "Copyright 2011 The Apache Software Foundation" in the license header.
           - NOTE that checkstyle is revised to accommodate the license header without copyright.
             As a result, it will complain all other files until they are also migrated with
             the new license header (without copyright).
        Bilung Lee made changes -
        Description 1. Create the new package under org.apache.sqoop namespace.
        2. Move logics from com.cloudera.sqoop classes to org.apache.sqoop classes.
        3. Let com.cloudera.sqoop classes inherit logics from org.apache.sqoop classes.
        4. Deprecate classes under com.cloudera.sqoop namespace.

        Also remove copyright notice in the header (http://www.apache.org/legal/src-headers.html). I.e. remove this line "Copyright 2011 The Apache Software Foundation" in the license header. NOTE that checkstyle is revised to accommodate the license header without copyright. As a result, it will complain all other files until
        they are also migrated with the new license header (without copyright).
        1. Create the new package under org.apache.sqoop namespace.
        2. Move logics from com.cloudera.sqoop classes to org.apache.sqoop classes.
        3. Let com.cloudera.sqoop classes inherit logics from org.apache.sqoop classes.
        4. Deprecate classes under com.cloudera.sqoop namespace.

        Also remove copyright notice in the header (http://www.apache.org/legal/src-headers.html). I.e. remove this line "Copyright 2011 The Apache Software Foundation" in the license header. NOTE that checkstyle is revised to accommodate the license header without copyright. As a result, it will complain all other files until they are also migrated with the new license header (without copyright).
        Hide
        Hudson added a comment -

        Integrated in Sqoop-jdk-1.6 #46 (See https://builds.apache.org/job/Sqoop-jdk-1.6/46/)
        SQOOP-371. Migrate util package to new namespace.

        (Bilung Lee via Arvind Prabhakar)

        arvind : http://svn.apache.org/viewvc/?view=rev&rev=1188921
        Files :

        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/AppendUtils.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/AsyncSink.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/ClassLoaderStack.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/DirectImportUtils.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/ErrorableAsyncSink.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/ErrorableThread.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/Executor.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/ExitSecurityException.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/ExportException.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/FileListing.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/ImportException.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/Jars.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/JdbcUrl.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/LoggingAsyncSink.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/LoggingUtils.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/NullAsyncSink.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/OptionsFileUtil.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/PerfCounters.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/RandomHash.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/ResultSetPrinter.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/StoredAsProperty.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/SubprocessSecurityManager.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/TaskId.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/util
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/AppendUtils.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/AsyncSink.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/ClassLoaderStack.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/DirectImportUtils.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/ErrorableAsyncSink.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/ErrorableThread.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/Executor.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/ExitSecurityException.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/ExportException.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/FileListing.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/ImportException.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/Jars.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/JdbcUrl.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/LoggingAsyncSink.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/LoggingUtils.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/NullAsyncSink.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/OptionsFileUtil.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/PerfCounters.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/RandomHash.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/ResultSetPrinter.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/StoredAsProperty.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/SubprocessSecurityManager.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/TaskId.java
        • /incubator/sqoop/trunk/src/test/checkstyle-java-header.txt
        Show
        Hudson added a comment - Integrated in Sqoop-jdk-1.6 #46 (See https://builds.apache.org/job/Sqoop-jdk-1.6/46/ ) SQOOP-371 . Migrate util package to new namespace. (Bilung Lee via Arvind Prabhakar) arvind : http://svn.apache.org/viewvc/?view=rev&rev=1188921 Files : /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/AppendUtils.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/AsyncSink.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/ClassLoaderStack.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/DirectImportUtils.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/ErrorableAsyncSink.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/ErrorableThread.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/Executor.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/ExitSecurityException.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/ExportException.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/FileListing.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/ImportException.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/Jars.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/JdbcUrl.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/LoggingAsyncSink.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/LoggingUtils.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/NullAsyncSink.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/OptionsFileUtil.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/PerfCounters.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/RandomHash.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/ResultSetPrinter.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/StoredAsProperty.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/SubprocessSecurityManager.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/TaskId.java /incubator/sqoop/trunk/src/java/org/apache/sqoop /incubator/sqoop/trunk/src/java/org/apache/sqoop/util /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/AppendUtils.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/AsyncSink.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/ClassLoaderStack.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/DirectImportUtils.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/ErrorableAsyncSink.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/ErrorableThread.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/Executor.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/ExitSecurityException.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/ExportException.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/FileListing.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/ImportException.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/Jars.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/JdbcUrl.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/LoggingAsyncSink.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/LoggingUtils.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/NullAsyncSink.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/OptionsFileUtil.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/PerfCounters.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/RandomHash.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/ResultSetPrinter.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/StoredAsProperty.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/SubprocessSecurityManager.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/util/TaskId.java /incubator/sqoop/trunk/src/test/checkstyle-java-header.txt
        Arvind Prabhakar made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 1.4.0-incubating [ 12317345 ]
        Resolution Fixed [ 1 ]
        Hide
        Arvind Prabhakar added a comment -

        Patch committed. Thanks Bilung!

        Show
        Arvind Prabhakar added a comment - Patch committed. Thanks Bilung!
        Bilung Lee made changes -
        Description 1. Create the new package under org.apache.sqoop namespace.
        2. Move logics from com.cloudera.sqoop classes to org.apache.sqoop classes.
        3. Let com.cloudera.sqoop classes inherit logics from org.apache.sqoop classes.
        4. Deprecate classes under com.cloudera.sqoop namespace.

        Also remove copyright notice in the header.
        (http://www.apache.org/legal/src-headers.html)
        NOTE that checkstyle is revised to accommodate the license header
        without copyright. As a result, it will complain all other files until
        they are also migrated with the new license header (without copyright).
        1. Create the new package under org.apache.sqoop namespace.
        2. Move logics from com.cloudera.sqoop classes to org.apache.sqoop classes.
        3. Let com.cloudera.sqoop classes inherit logics from org.apache.sqoop classes.
        4. Deprecate classes under com.cloudera.sqoop namespace.

        Also remove copyright notice in the header (http://www.apache.org/legal/src-headers.html). I.e. remove this line "Copyright 2011 The Apache Software Foundation" in the license header. NOTE that checkstyle is revised to accommodate the license header without copyright. As a result, it will complain all other files until
        they are also migrated with the new license header (without copyright).
        Bilung Lee made changes -
        Attachment SQOOP-371.patch [ 12500565 ]
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2519/#review2807
        -----------------------------------------------------------

        Ship it!

        +1

        • Arvind

        On 2011-10-24 21:51:42, Bilung Lee wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2519/

        -----------------------------------------------------------

        (Updated 2011-10-24 21:51:42)

        Review request for Sqoop and Arvind Prabhakar.

        Summary

        -------

        1. Create the new package under org.apache.sqoop namespace.

        2. Move logics from com.cloudera.sqoop classes to org.apache.sqoop classes.

        3. Let com.cloudera.sqoop classes inherit logics from org.apache.sqoop classes.

        4. Deprecate classes under com.cloudera.sqoop namespace.

        This addresses bug SQOOP-371.

        https://issues.apache.org/jira/browse/SQOOP-371

        Diffs

        -----

        ./src/java/com/cloudera/sqoop/util/AppendUtils.java 1187591

        ./src/java/com/cloudera/sqoop/util/AsyncSink.java 1187591

        ./src/java/com/cloudera/sqoop/util/ClassLoaderStack.java 1187591

        ./src/java/com/cloudera/sqoop/util/DirectImportUtils.java 1187591

        ./src/java/com/cloudera/sqoop/util/ErrorableAsyncSink.java 1187591

        ./src/java/com/cloudera/sqoop/util/ErrorableThread.java 1187591

        ./src/java/com/cloudera/sqoop/util/Executor.java 1187591

        ./src/java/com/cloudera/sqoop/util/ExitSecurityException.java 1187591

        ./src/java/com/cloudera/sqoop/util/ExportException.java 1187591

        ./src/java/com/cloudera/sqoop/util/FileListing.java 1187591

        ./src/java/com/cloudera/sqoop/util/ImportException.java 1187591

        ./src/java/com/cloudera/sqoop/util/Jars.java 1187591

        ./src/java/com/cloudera/sqoop/util/JdbcUrl.java 1187591

        ./src/java/com/cloudera/sqoop/util/LoggingAsyncSink.java 1187591

        ./src/java/com/cloudera/sqoop/util/LoggingUtils.java 1187591

        ./src/java/com/cloudera/sqoop/util/NullAsyncSink.java 1187591

        ./src/java/com/cloudera/sqoop/util/OptionsFileUtil.java 1187591

        ./src/java/com/cloudera/sqoop/util/PerfCounters.java 1187591

        ./src/java/com/cloudera/sqoop/util/RandomHash.java 1187591

        ./src/java/com/cloudera/sqoop/util/ResultSetPrinter.java 1187591

        ./src/java/com/cloudera/sqoop/util/StoredAsProperty.java 1187591

        ./src/java/com/cloudera/sqoop/util/SubprocessSecurityManager.java 1187591

        ./src/java/com/cloudera/sqoop/util/TaskId.java 1187591

        ./src/java/org/apache/sqoop/util/AppendUtils.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/AsyncSink.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/ClassLoaderStack.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/DirectImportUtils.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/ErrorableAsyncSink.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/ErrorableThread.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/Executor.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/ExitSecurityException.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/ExportException.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/FileListing.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/ImportException.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/Jars.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/JdbcUrl.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/LoggingAsyncSink.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/LoggingUtils.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/NullAsyncSink.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/OptionsFileUtil.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/PerfCounters.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/RandomHash.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/ResultSetPrinter.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/StoredAsProperty.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/SubprocessSecurityManager.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/TaskId.java PRE-CREATION

        ./src/test/checkstyle-java-header.txt 1187139

        Diff: https://reviews.apache.org/r/2519/diff

        Testing

        -------

        Thanks,

        Bilung

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2519/#review2807 ----------------------------------------------------------- Ship it! +1 Arvind On 2011-10-24 21:51:42, Bilung Lee wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2519/ ----------------------------------------------------------- (Updated 2011-10-24 21:51:42) Review request for Sqoop and Arvind Prabhakar. Summary ------- 1. Create the new package under org.apache.sqoop namespace. 2. Move logics from com.cloudera.sqoop classes to org.apache.sqoop classes. 3. Let com.cloudera.sqoop classes inherit logics from org.apache.sqoop classes. 4. Deprecate classes under com.cloudera.sqoop namespace. This addresses bug SQOOP-371 . https://issues.apache.org/jira/browse/SQOOP-371 Diffs ----- ./src/java/com/cloudera/sqoop/util/AppendUtils.java 1187591 ./src/java/com/cloudera/sqoop/util/AsyncSink.java 1187591 ./src/java/com/cloudera/sqoop/util/ClassLoaderStack.java 1187591 ./src/java/com/cloudera/sqoop/util/DirectImportUtils.java 1187591 ./src/java/com/cloudera/sqoop/util/ErrorableAsyncSink.java 1187591 ./src/java/com/cloudera/sqoop/util/ErrorableThread.java 1187591 ./src/java/com/cloudera/sqoop/util/Executor.java 1187591 ./src/java/com/cloudera/sqoop/util/ExitSecurityException.java 1187591 ./src/java/com/cloudera/sqoop/util/ExportException.java 1187591 ./src/java/com/cloudera/sqoop/util/FileListing.java 1187591 ./src/java/com/cloudera/sqoop/util/ImportException.java 1187591 ./src/java/com/cloudera/sqoop/util/Jars.java 1187591 ./src/java/com/cloudera/sqoop/util/JdbcUrl.java 1187591 ./src/java/com/cloudera/sqoop/util/LoggingAsyncSink.java 1187591 ./src/java/com/cloudera/sqoop/util/LoggingUtils.java 1187591 ./src/java/com/cloudera/sqoop/util/NullAsyncSink.java 1187591 ./src/java/com/cloudera/sqoop/util/OptionsFileUtil.java 1187591 ./src/java/com/cloudera/sqoop/util/PerfCounters.java 1187591 ./src/java/com/cloudera/sqoop/util/RandomHash.java 1187591 ./src/java/com/cloudera/sqoop/util/ResultSetPrinter.java 1187591 ./src/java/com/cloudera/sqoop/util/StoredAsProperty.java 1187591 ./src/java/com/cloudera/sqoop/util/SubprocessSecurityManager.java 1187591 ./src/java/com/cloudera/sqoop/util/TaskId.java 1187591 ./src/java/org/apache/sqoop/util/AppendUtils.java PRE-CREATION ./src/java/org/apache/sqoop/util/AsyncSink.java PRE-CREATION ./src/java/org/apache/sqoop/util/ClassLoaderStack.java PRE-CREATION ./src/java/org/apache/sqoop/util/DirectImportUtils.java PRE-CREATION ./src/java/org/apache/sqoop/util/ErrorableAsyncSink.java PRE-CREATION ./src/java/org/apache/sqoop/util/ErrorableThread.java PRE-CREATION ./src/java/org/apache/sqoop/util/Executor.java PRE-CREATION ./src/java/org/apache/sqoop/util/ExitSecurityException.java PRE-CREATION ./src/java/org/apache/sqoop/util/ExportException.java PRE-CREATION ./src/java/org/apache/sqoop/util/FileListing.java PRE-CREATION ./src/java/org/apache/sqoop/util/ImportException.java PRE-CREATION ./src/java/org/apache/sqoop/util/Jars.java PRE-CREATION ./src/java/org/apache/sqoop/util/JdbcUrl.java PRE-CREATION ./src/java/org/apache/sqoop/util/LoggingAsyncSink.java PRE-CREATION ./src/java/org/apache/sqoop/util/LoggingUtils.java PRE-CREATION ./src/java/org/apache/sqoop/util/NullAsyncSink.java PRE-CREATION ./src/java/org/apache/sqoop/util/OptionsFileUtil.java PRE-CREATION ./src/java/org/apache/sqoop/util/PerfCounters.java PRE-CREATION ./src/java/org/apache/sqoop/util/RandomHash.java PRE-CREATION ./src/java/org/apache/sqoop/util/ResultSetPrinter.java PRE-CREATION ./src/java/org/apache/sqoop/util/StoredAsProperty.java PRE-CREATION ./src/java/org/apache/sqoop/util/SubprocessSecurityManager.java PRE-CREATION ./src/java/org/apache/sqoop/util/TaskId.java PRE-CREATION ./src/test/checkstyle-java-header.txt 1187139 Diff: https://reviews.apache.org/r/2519/diff Testing ------- Thanks, Bilung
        Bilung Lee made changes -
        Description 1. Create the new package under org.apache.sqoop namespace.
        2. Move logics from com.cloudera.sqoop classes to org.apache.sqoop classes.
        3. Let com.cloudera.sqoop classes inherit logics from org.apache.sqoop classes.
        4. Deprecate classes under com.cloudera.sqoop namespace.

        Also remove copyright notice in the header.
        (http://www.apache.org/legal/src-headers.html)
        1. Create the new package under org.apache.sqoop namespace.
        2. Move logics from com.cloudera.sqoop classes to org.apache.sqoop classes.
        3. Let com.cloudera.sqoop classes inherit logics from org.apache.sqoop classes.
        4. Deprecate classes under com.cloudera.sqoop namespace.

        Also remove copyright notice in the header.
        (http://www.apache.org/legal/src-headers.html)
        NOTE that checkstyle is revised to accommodate the license header
        without copyright. As a result, it will complain all other files until
        they are also migrated with the new license header (without copyright).
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2519/
        -----------------------------------------------------------

        (Updated 2011-10-24 21:51:42.925324)

        Review request for Sqoop and Arvind Prabhakar.

        Changes
        -------

        1. Update license header checkstyle to exclude copyright.
        2. Keep static methods in util classes.

        Summary
        -------

        1. Create the new package under org.apache.sqoop namespace.
        2. Move logics from com.cloudera.sqoop classes to org.apache.sqoop classes.
        3. Let com.cloudera.sqoop classes inherit logics from org.apache.sqoop classes.
        4. Deprecate classes under com.cloudera.sqoop namespace.

        This addresses bug SQOOP-371.
        https://issues.apache.org/jira/browse/SQOOP-371

        Diffs (updated)


        ./src/java/com/cloudera/sqoop/util/AppendUtils.java 1187591
        ./src/java/com/cloudera/sqoop/util/AsyncSink.java 1187591
        ./src/java/com/cloudera/sqoop/util/ClassLoaderStack.java 1187591
        ./src/java/com/cloudera/sqoop/util/DirectImportUtils.java 1187591
        ./src/java/com/cloudera/sqoop/util/ErrorableAsyncSink.java 1187591
        ./src/java/com/cloudera/sqoop/util/ErrorableThread.java 1187591
        ./src/java/com/cloudera/sqoop/util/Executor.java 1187591
        ./src/java/com/cloudera/sqoop/util/ExitSecurityException.java 1187591
        ./src/java/com/cloudera/sqoop/util/ExportException.java 1187591
        ./src/java/com/cloudera/sqoop/util/FileListing.java 1187591
        ./src/java/com/cloudera/sqoop/util/ImportException.java 1187591
        ./src/java/com/cloudera/sqoop/util/Jars.java 1187591
        ./src/java/com/cloudera/sqoop/util/JdbcUrl.java 1187591
        ./src/java/com/cloudera/sqoop/util/LoggingAsyncSink.java 1187591
        ./src/java/com/cloudera/sqoop/util/LoggingUtils.java 1187591
        ./src/java/com/cloudera/sqoop/util/NullAsyncSink.java 1187591
        ./src/java/com/cloudera/sqoop/util/OptionsFileUtil.java 1187591
        ./src/java/com/cloudera/sqoop/util/PerfCounters.java 1187591
        ./src/java/com/cloudera/sqoop/util/RandomHash.java 1187591
        ./src/java/com/cloudera/sqoop/util/ResultSetPrinter.java 1187591
        ./src/java/com/cloudera/sqoop/util/StoredAsProperty.java 1187591
        ./src/java/com/cloudera/sqoop/util/SubprocessSecurityManager.java 1187591
        ./src/java/com/cloudera/sqoop/util/TaskId.java 1187591
        ./src/java/org/apache/sqoop/util/AppendUtils.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/AsyncSink.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/ClassLoaderStack.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/DirectImportUtils.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/ErrorableAsyncSink.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/ErrorableThread.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/Executor.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/ExitSecurityException.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/ExportException.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/FileListing.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/ImportException.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/Jars.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/JdbcUrl.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/LoggingAsyncSink.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/LoggingUtils.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/NullAsyncSink.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/OptionsFileUtil.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/PerfCounters.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/RandomHash.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/ResultSetPrinter.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/StoredAsProperty.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/SubprocessSecurityManager.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/TaskId.java PRE-CREATION
        ./src/test/checkstyle-java-header.txt 1187139

        Diff: https://reviews.apache.org/r/2519/diff

        Testing
        -------

        Thanks,

        Bilung

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2519/ ----------------------------------------------------------- (Updated 2011-10-24 21:51:42.925324) Review request for Sqoop and Arvind Prabhakar. Changes ------- 1. Update license header checkstyle to exclude copyright. 2. Keep static methods in util classes. Summary ------- 1. Create the new package under org.apache.sqoop namespace. 2. Move logics from com.cloudera.sqoop classes to org.apache.sqoop classes. 3. Let com.cloudera.sqoop classes inherit logics from org.apache.sqoop classes. 4. Deprecate classes under com.cloudera.sqoop namespace. This addresses bug SQOOP-371 . https://issues.apache.org/jira/browse/SQOOP-371 Diffs (updated) ./src/java/com/cloudera/sqoop/util/AppendUtils.java 1187591 ./src/java/com/cloudera/sqoop/util/AsyncSink.java 1187591 ./src/java/com/cloudera/sqoop/util/ClassLoaderStack.java 1187591 ./src/java/com/cloudera/sqoop/util/DirectImportUtils.java 1187591 ./src/java/com/cloudera/sqoop/util/ErrorableAsyncSink.java 1187591 ./src/java/com/cloudera/sqoop/util/ErrorableThread.java 1187591 ./src/java/com/cloudera/sqoop/util/Executor.java 1187591 ./src/java/com/cloudera/sqoop/util/ExitSecurityException.java 1187591 ./src/java/com/cloudera/sqoop/util/ExportException.java 1187591 ./src/java/com/cloudera/sqoop/util/FileListing.java 1187591 ./src/java/com/cloudera/sqoop/util/ImportException.java 1187591 ./src/java/com/cloudera/sqoop/util/Jars.java 1187591 ./src/java/com/cloudera/sqoop/util/JdbcUrl.java 1187591 ./src/java/com/cloudera/sqoop/util/LoggingAsyncSink.java 1187591 ./src/java/com/cloudera/sqoop/util/LoggingUtils.java 1187591 ./src/java/com/cloudera/sqoop/util/NullAsyncSink.java 1187591 ./src/java/com/cloudera/sqoop/util/OptionsFileUtil.java 1187591 ./src/java/com/cloudera/sqoop/util/PerfCounters.java 1187591 ./src/java/com/cloudera/sqoop/util/RandomHash.java 1187591 ./src/java/com/cloudera/sqoop/util/ResultSetPrinter.java 1187591 ./src/java/com/cloudera/sqoop/util/StoredAsProperty.java 1187591 ./src/java/com/cloudera/sqoop/util/SubprocessSecurityManager.java 1187591 ./src/java/com/cloudera/sqoop/util/TaskId.java 1187591 ./src/java/org/apache/sqoop/util/AppendUtils.java PRE-CREATION ./src/java/org/apache/sqoop/util/AsyncSink.java PRE-CREATION ./src/java/org/apache/sqoop/util/ClassLoaderStack.java PRE-CREATION ./src/java/org/apache/sqoop/util/DirectImportUtils.java PRE-CREATION ./src/java/org/apache/sqoop/util/ErrorableAsyncSink.java PRE-CREATION ./src/java/org/apache/sqoop/util/ErrorableThread.java PRE-CREATION ./src/java/org/apache/sqoop/util/Executor.java PRE-CREATION ./src/java/org/apache/sqoop/util/ExitSecurityException.java PRE-CREATION ./src/java/org/apache/sqoop/util/ExportException.java PRE-CREATION ./src/java/org/apache/sqoop/util/FileListing.java PRE-CREATION ./src/java/org/apache/sqoop/util/ImportException.java PRE-CREATION ./src/java/org/apache/sqoop/util/Jars.java PRE-CREATION ./src/java/org/apache/sqoop/util/JdbcUrl.java PRE-CREATION ./src/java/org/apache/sqoop/util/LoggingAsyncSink.java PRE-CREATION ./src/java/org/apache/sqoop/util/LoggingUtils.java PRE-CREATION ./src/java/org/apache/sqoop/util/NullAsyncSink.java PRE-CREATION ./src/java/org/apache/sqoop/util/OptionsFileUtil.java PRE-CREATION ./src/java/org/apache/sqoop/util/PerfCounters.java PRE-CREATION ./src/java/org/apache/sqoop/util/RandomHash.java PRE-CREATION ./src/java/org/apache/sqoop/util/ResultSetPrinter.java PRE-CREATION ./src/java/org/apache/sqoop/util/StoredAsProperty.java PRE-CREATION ./src/java/org/apache/sqoop/util/SubprocessSecurityManager.java PRE-CREATION ./src/java/org/apache/sqoop/util/TaskId.java PRE-CREATION ./src/test/checkstyle-java-header.txt 1187139 Diff: https://reviews.apache.org/r/2519/diff Testing ------- Thanks, Bilung
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2519/#review2800
        -----------------------------------------------------------

        Ship it!

        +1 - looks good to me.

        • Arvind

        On 2011-10-22 19:36:22, Bilung Lee wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2519/

        -----------------------------------------------------------

        (Updated 2011-10-22 19:36:22)

        Review request for Sqoop and Arvind Prabhakar.

        Summary

        -------

        1. Create the new package under org.apache.sqoop namespace.

        2. Move logics from com.cloudera.sqoop classes to org.apache.sqoop classes.

        3. Let com.cloudera.sqoop classes inherit logics from org.apache.sqoop classes.

        4. Deprecate classes under com.cloudera.sqoop namespace.

        This addresses bug SQOOP-371.

        https://issues.apache.org/jira/browse/SQOOP-371

        Diffs

        -----

        ./src/java/com/cloudera/sqoop/util/AppendUtils.java 1187591

        ./src/java/com/cloudera/sqoop/util/AsyncSink.java 1187591

        ./src/java/com/cloudera/sqoop/util/ClassLoaderStack.java 1187591

        ./src/java/com/cloudera/sqoop/util/DirectImportUtils.java 1187591

        ./src/java/com/cloudera/sqoop/util/ErrorableAsyncSink.java 1187591

        ./src/java/com/cloudera/sqoop/util/ErrorableThread.java 1187591

        ./src/java/com/cloudera/sqoop/util/Executor.java 1187591

        ./src/java/com/cloudera/sqoop/util/ExitSecurityException.java 1187591

        ./src/java/com/cloudera/sqoop/util/ExportException.java 1187591

        ./src/java/com/cloudera/sqoop/util/FileListing.java 1187591

        ./src/java/com/cloudera/sqoop/util/ImportException.java 1187591

        ./src/java/com/cloudera/sqoop/util/Jars.java 1187591

        ./src/java/com/cloudera/sqoop/util/JdbcUrl.java 1187591

        ./src/java/com/cloudera/sqoop/util/LoggingAsyncSink.java 1187591

        ./src/java/com/cloudera/sqoop/util/LoggingUtils.java 1187591

        ./src/java/com/cloudera/sqoop/util/NullAsyncSink.java 1187591

        ./src/java/com/cloudera/sqoop/util/OptionsFileUtil.java 1187591

        ./src/java/com/cloudera/sqoop/util/PerfCounters.java 1187591

        ./src/java/com/cloudera/sqoop/util/RandomHash.java 1187591

        ./src/java/com/cloudera/sqoop/util/ResultSetPrinter.java 1187591

        ./src/java/com/cloudera/sqoop/util/StoredAsProperty.java 1187591

        ./src/java/com/cloudera/sqoop/util/SubprocessSecurityManager.java 1187591

        ./src/java/com/cloudera/sqoop/util/TaskId.java 1187591

        ./src/java/org/apache/sqoop/util/AppendUtils.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/AsyncSink.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/ClassLoaderStack.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/DirectImportUtils.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/ErrorableAsyncSink.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/ErrorableThread.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/Executor.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/ExitSecurityException.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/ExportException.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/FileListing.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/ImportException.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/Jars.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/JdbcUrl.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/LoggingAsyncSink.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/LoggingUtils.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/NullAsyncSink.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/OptionsFileUtil.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/PerfCounters.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/RandomHash.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/ResultSetPrinter.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/StoredAsProperty.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/SubprocessSecurityManager.java PRE-CREATION

        ./src/java/org/apache/sqoop/util/TaskId.java PRE-CREATION

        Diff: https://reviews.apache.org/r/2519/diff

        Testing

        -------

        Thanks,

        Bilung

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2519/#review2800 ----------------------------------------------------------- Ship it! +1 - looks good to me. Arvind On 2011-10-22 19:36:22, Bilung Lee wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2519/ ----------------------------------------------------------- (Updated 2011-10-22 19:36:22) Review request for Sqoop and Arvind Prabhakar. Summary ------- 1. Create the new package under org.apache.sqoop namespace. 2. Move logics from com.cloudera.sqoop classes to org.apache.sqoop classes. 3. Let com.cloudera.sqoop classes inherit logics from org.apache.sqoop classes. 4. Deprecate classes under com.cloudera.sqoop namespace. This addresses bug SQOOP-371 . https://issues.apache.org/jira/browse/SQOOP-371 Diffs ----- ./src/java/com/cloudera/sqoop/util/AppendUtils.java 1187591 ./src/java/com/cloudera/sqoop/util/AsyncSink.java 1187591 ./src/java/com/cloudera/sqoop/util/ClassLoaderStack.java 1187591 ./src/java/com/cloudera/sqoop/util/DirectImportUtils.java 1187591 ./src/java/com/cloudera/sqoop/util/ErrorableAsyncSink.java 1187591 ./src/java/com/cloudera/sqoop/util/ErrorableThread.java 1187591 ./src/java/com/cloudera/sqoop/util/Executor.java 1187591 ./src/java/com/cloudera/sqoop/util/ExitSecurityException.java 1187591 ./src/java/com/cloudera/sqoop/util/ExportException.java 1187591 ./src/java/com/cloudera/sqoop/util/FileListing.java 1187591 ./src/java/com/cloudera/sqoop/util/ImportException.java 1187591 ./src/java/com/cloudera/sqoop/util/Jars.java 1187591 ./src/java/com/cloudera/sqoop/util/JdbcUrl.java 1187591 ./src/java/com/cloudera/sqoop/util/LoggingAsyncSink.java 1187591 ./src/java/com/cloudera/sqoop/util/LoggingUtils.java 1187591 ./src/java/com/cloudera/sqoop/util/NullAsyncSink.java 1187591 ./src/java/com/cloudera/sqoop/util/OptionsFileUtil.java 1187591 ./src/java/com/cloudera/sqoop/util/PerfCounters.java 1187591 ./src/java/com/cloudera/sqoop/util/RandomHash.java 1187591 ./src/java/com/cloudera/sqoop/util/ResultSetPrinter.java 1187591 ./src/java/com/cloudera/sqoop/util/StoredAsProperty.java 1187591 ./src/java/com/cloudera/sqoop/util/SubprocessSecurityManager.java 1187591 ./src/java/com/cloudera/sqoop/util/TaskId.java 1187591 ./src/java/org/apache/sqoop/util/AppendUtils.java PRE-CREATION ./src/java/org/apache/sqoop/util/AsyncSink.java PRE-CREATION ./src/java/org/apache/sqoop/util/ClassLoaderStack.java PRE-CREATION ./src/java/org/apache/sqoop/util/DirectImportUtils.java PRE-CREATION ./src/java/org/apache/sqoop/util/ErrorableAsyncSink.java PRE-CREATION ./src/java/org/apache/sqoop/util/ErrorableThread.java PRE-CREATION ./src/java/org/apache/sqoop/util/Executor.java PRE-CREATION ./src/java/org/apache/sqoop/util/ExitSecurityException.java PRE-CREATION ./src/java/org/apache/sqoop/util/ExportException.java PRE-CREATION ./src/java/org/apache/sqoop/util/FileListing.java PRE-CREATION ./src/java/org/apache/sqoop/util/ImportException.java PRE-CREATION ./src/java/org/apache/sqoop/util/Jars.java PRE-CREATION ./src/java/org/apache/sqoop/util/JdbcUrl.java PRE-CREATION ./src/java/org/apache/sqoop/util/LoggingAsyncSink.java PRE-CREATION ./src/java/org/apache/sqoop/util/LoggingUtils.java PRE-CREATION ./src/java/org/apache/sqoop/util/NullAsyncSink.java PRE-CREATION ./src/java/org/apache/sqoop/util/OptionsFileUtil.java PRE-CREATION ./src/java/org/apache/sqoop/util/PerfCounters.java PRE-CREATION ./src/java/org/apache/sqoop/util/RandomHash.java PRE-CREATION ./src/java/org/apache/sqoop/util/ResultSetPrinter.java PRE-CREATION ./src/java/org/apache/sqoop/util/StoredAsProperty.java PRE-CREATION ./src/java/org/apache/sqoop/util/SubprocessSecurityManager.java PRE-CREATION ./src/java/org/apache/sqoop/util/TaskId.java PRE-CREATION Diff: https://reviews.apache.org/r/2519/diff Testing ------- Thanks, Bilung
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2519/
        -----------------------------------------------------------

        (Updated 2011-10-22 19:36:22.827790)

        Review request for Sqoop and Arvind Prabhakar.

        Changes
        -------

        Remove copyright notice in the header.

        Summary
        -------

        1. Create the new package under org.apache.sqoop namespace.
        2. Move logics from com.cloudera.sqoop classes to org.apache.sqoop classes.
        3. Let com.cloudera.sqoop classes inherit logics from org.apache.sqoop classes.
        4. Deprecate classes under com.cloudera.sqoop namespace.

        This addresses bug SQOOP-371.
        https://issues.apache.org/jira/browse/SQOOP-371

        Diffs (updated)


        ./src/java/com/cloudera/sqoop/util/AppendUtils.java 1187591
        ./src/java/com/cloudera/sqoop/util/AsyncSink.java 1187591
        ./src/java/com/cloudera/sqoop/util/ClassLoaderStack.java 1187591
        ./src/java/com/cloudera/sqoop/util/DirectImportUtils.java 1187591
        ./src/java/com/cloudera/sqoop/util/ErrorableAsyncSink.java 1187591
        ./src/java/com/cloudera/sqoop/util/ErrorableThread.java 1187591
        ./src/java/com/cloudera/sqoop/util/Executor.java 1187591
        ./src/java/com/cloudera/sqoop/util/ExitSecurityException.java 1187591
        ./src/java/com/cloudera/sqoop/util/ExportException.java 1187591
        ./src/java/com/cloudera/sqoop/util/FileListing.java 1187591
        ./src/java/com/cloudera/sqoop/util/ImportException.java 1187591
        ./src/java/com/cloudera/sqoop/util/Jars.java 1187591
        ./src/java/com/cloudera/sqoop/util/JdbcUrl.java 1187591
        ./src/java/com/cloudera/sqoop/util/LoggingAsyncSink.java 1187591
        ./src/java/com/cloudera/sqoop/util/LoggingUtils.java 1187591
        ./src/java/com/cloudera/sqoop/util/NullAsyncSink.java 1187591
        ./src/java/com/cloudera/sqoop/util/OptionsFileUtil.java 1187591
        ./src/java/com/cloudera/sqoop/util/PerfCounters.java 1187591
        ./src/java/com/cloudera/sqoop/util/RandomHash.java 1187591
        ./src/java/com/cloudera/sqoop/util/ResultSetPrinter.java 1187591
        ./src/java/com/cloudera/sqoop/util/StoredAsProperty.java 1187591
        ./src/java/com/cloudera/sqoop/util/SubprocessSecurityManager.java 1187591
        ./src/java/com/cloudera/sqoop/util/TaskId.java 1187591
        ./src/java/org/apache/sqoop/util/AppendUtils.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/AsyncSink.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/ClassLoaderStack.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/DirectImportUtils.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/ErrorableAsyncSink.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/ErrorableThread.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/Executor.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/ExitSecurityException.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/ExportException.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/FileListing.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/ImportException.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/Jars.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/JdbcUrl.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/LoggingAsyncSink.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/LoggingUtils.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/NullAsyncSink.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/OptionsFileUtil.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/PerfCounters.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/RandomHash.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/ResultSetPrinter.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/StoredAsProperty.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/SubprocessSecurityManager.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/TaskId.java PRE-CREATION

        Diff: https://reviews.apache.org/r/2519/diff

        Testing
        -------

        Thanks,

        Bilung

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2519/ ----------------------------------------------------------- (Updated 2011-10-22 19:36:22.827790) Review request for Sqoop and Arvind Prabhakar. Changes ------- Remove copyright notice in the header. Summary ------- 1. Create the new package under org.apache.sqoop namespace. 2. Move logics from com.cloudera.sqoop classes to org.apache.sqoop classes. 3. Let com.cloudera.sqoop classes inherit logics from org.apache.sqoop classes. 4. Deprecate classes under com.cloudera.sqoop namespace. This addresses bug SQOOP-371 . https://issues.apache.org/jira/browse/SQOOP-371 Diffs (updated) ./src/java/com/cloudera/sqoop/util/AppendUtils.java 1187591 ./src/java/com/cloudera/sqoop/util/AsyncSink.java 1187591 ./src/java/com/cloudera/sqoop/util/ClassLoaderStack.java 1187591 ./src/java/com/cloudera/sqoop/util/DirectImportUtils.java 1187591 ./src/java/com/cloudera/sqoop/util/ErrorableAsyncSink.java 1187591 ./src/java/com/cloudera/sqoop/util/ErrorableThread.java 1187591 ./src/java/com/cloudera/sqoop/util/Executor.java 1187591 ./src/java/com/cloudera/sqoop/util/ExitSecurityException.java 1187591 ./src/java/com/cloudera/sqoop/util/ExportException.java 1187591 ./src/java/com/cloudera/sqoop/util/FileListing.java 1187591 ./src/java/com/cloudera/sqoop/util/ImportException.java 1187591 ./src/java/com/cloudera/sqoop/util/Jars.java 1187591 ./src/java/com/cloudera/sqoop/util/JdbcUrl.java 1187591 ./src/java/com/cloudera/sqoop/util/LoggingAsyncSink.java 1187591 ./src/java/com/cloudera/sqoop/util/LoggingUtils.java 1187591 ./src/java/com/cloudera/sqoop/util/NullAsyncSink.java 1187591 ./src/java/com/cloudera/sqoop/util/OptionsFileUtil.java 1187591 ./src/java/com/cloudera/sqoop/util/PerfCounters.java 1187591 ./src/java/com/cloudera/sqoop/util/RandomHash.java 1187591 ./src/java/com/cloudera/sqoop/util/ResultSetPrinter.java 1187591 ./src/java/com/cloudera/sqoop/util/StoredAsProperty.java 1187591 ./src/java/com/cloudera/sqoop/util/SubprocessSecurityManager.java 1187591 ./src/java/com/cloudera/sqoop/util/TaskId.java 1187591 ./src/java/org/apache/sqoop/util/AppendUtils.java PRE-CREATION ./src/java/org/apache/sqoop/util/AsyncSink.java PRE-CREATION ./src/java/org/apache/sqoop/util/ClassLoaderStack.java PRE-CREATION ./src/java/org/apache/sqoop/util/DirectImportUtils.java PRE-CREATION ./src/java/org/apache/sqoop/util/ErrorableAsyncSink.java PRE-CREATION ./src/java/org/apache/sqoop/util/ErrorableThread.java PRE-CREATION ./src/java/org/apache/sqoop/util/Executor.java PRE-CREATION ./src/java/org/apache/sqoop/util/ExitSecurityException.java PRE-CREATION ./src/java/org/apache/sqoop/util/ExportException.java PRE-CREATION ./src/java/org/apache/sqoop/util/FileListing.java PRE-CREATION ./src/java/org/apache/sqoop/util/ImportException.java PRE-CREATION ./src/java/org/apache/sqoop/util/Jars.java PRE-CREATION ./src/java/org/apache/sqoop/util/JdbcUrl.java PRE-CREATION ./src/java/org/apache/sqoop/util/LoggingAsyncSink.java PRE-CREATION ./src/java/org/apache/sqoop/util/LoggingUtils.java PRE-CREATION ./src/java/org/apache/sqoop/util/NullAsyncSink.java PRE-CREATION ./src/java/org/apache/sqoop/util/OptionsFileUtil.java PRE-CREATION ./src/java/org/apache/sqoop/util/PerfCounters.java PRE-CREATION ./src/java/org/apache/sqoop/util/RandomHash.java PRE-CREATION ./src/java/org/apache/sqoop/util/ResultSetPrinter.java PRE-CREATION ./src/java/org/apache/sqoop/util/StoredAsProperty.java PRE-CREATION ./src/java/org/apache/sqoop/util/SubprocessSecurityManager.java PRE-CREATION ./src/java/org/apache/sqoop/util/TaskId.java PRE-CREATION Diff: https://reviews.apache.org/r/2519/diff Testing ------- Thanks, Bilung
        Bilung Lee made changes -
        Description 1. Create the new package under org.apache.sqoop namespace.
        2. Move logics from com.cloudera.sqoop classes to org.apache.sqoop classes.
        3. Let com.cloudera.sqoop classes inherit logics from org.apache.sqoop classes.
        4. Deprecate classes under com.cloudera.sqoop namespace.
        1. Create the new package under org.apache.sqoop namespace.
        2. Move logics from com.cloudera.sqoop classes to org.apache.sqoop classes.
        3. Let com.cloudera.sqoop classes inherit logics from org.apache.sqoop classes.
        4. Deprecate classes under com.cloudera.sqoop namespace.

        Also remove copyright notice in the header.
        (http://www.apache.org/legal/src-headers.html)
        Bilung Lee made changes -
        Summary Migrate com.cloudera.sqoop.util package to new name space Migrate util package to new name space
        Bilung Lee made changes -
        Field Original Value New Value
        Assignee Bilung Lee [ bleeapache ]
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2519/
        -----------------------------------------------------------

        Review request for Sqoop and Arvind Prabhakar.

        Summary
        -------

        1. Create the new package under org.apache.sqoop namespace.
        2. Move logics from com.cloudera.sqoop classes to org.apache.sqoop classes.
        3. Let com.cloudera.sqoop classes inherit logics from org.apache.sqoop classes.
        4. Deprecate classes under com.cloudera.sqoop namespace.

        This addresses bug SQOOP-371.
        https://issues.apache.org/jira/browse/SQOOP-371

        Diffs


        ./src/java/com/cloudera/sqoop/util/AppendUtils.java 1187139
        ./src/java/com/cloudera/sqoop/util/AsyncSink.java 1187139
        ./src/java/com/cloudera/sqoop/util/ClassLoaderStack.java 1187139
        ./src/java/com/cloudera/sqoop/util/DirectImportUtils.java 1187139
        ./src/java/com/cloudera/sqoop/util/ErrorableAsyncSink.java 1187139
        ./src/java/com/cloudera/sqoop/util/ErrorableThread.java 1187139
        ./src/java/com/cloudera/sqoop/util/Executor.java 1187139
        ./src/java/com/cloudera/sqoop/util/ExitSecurityException.java 1187139
        ./src/java/com/cloudera/sqoop/util/ExportException.java 1187139
        ./src/java/com/cloudera/sqoop/util/FileListing.java 1187139
        ./src/java/com/cloudera/sqoop/util/ImportException.java 1187139
        ./src/java/com/cloudera/sqoop/util/Jars.java 1187139
        ./src/java/com/cloudera/sqoop/util/JdbcUrl.java 1187139
        ./src/java/com/cloudera/sqoop/util/LoggingAsyncSink.java 1187139
        ./src/java/com/cloudera/sqoop/util/LoggingUtils.java 1187139
        ./src/java/com/cloudera/sqoop/util/NullAsyncSink.java 1187139
        ./src/java/com/cloudera/sqoop/util/OptionsFileUtil.java 1187139
        ./src/java/com/cloudera/sqoop/util/PerfCounters.java 1187139
        ./src/java/com/cloudera/sqoop/util/RandomHash.java 1187139
        ./src/java/com/cloudera/sqoop/util/ResultSetPrinter.java 1187139
        ./src/java/com/cloudera/sqoop/util/StoredAsProperty.java 1187139
        ./src/java/com/cloudera/sqoop/util/SubprocessSecurityManager.java 1187139
        ./src/java/com/cloudera/sqoop/util/TaskId.java 1187139
        ./src/java/org/apache/sqoop/util/AppendUtils.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/AsyncSink.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/ClassLoaderStack.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/DirectImportUtils.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/ErrorableAsyncSink.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/ErrorableThread.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/Executor.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/ExitSecurityException.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/ExportException.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/FileListing.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/ImportException.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/Jars.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/JdbcUrl.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/LoggingAsyncSink.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/LoggingUtils.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/NullAsyncSink.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/OptionsFileUtil.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/PerfCounters.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/RandomHash.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/ResultSetPrinter.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/StoredAsProperty.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/SubprocessSecurityManager.java PRE-CREATION
        ./src/java/org/apache/sqoop/util/TaskId.java PRE-CREATION

        Diff: https://reviews.apache.org/r/2519/diff

        Testing
        -------

        Thanks,

        Bilung

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2519/ ----------------------------------------------------------- Review request for Sqoop and Arvind Prabhakar. Summary ------- 1. Create the new package under org.apache.sqoop namespace. 2. Move logics from com.cloudera.sqoop classes to org.apache.sqoop classes. 3. Let com.cloudera.sqoop classes inherit logics from org.apache.sqoop classes. 4. Deprecate classes under com.cloudera.sqoop namespace. This addresses bug SQOOP-371 . https://issues.apache.org/jira/browse/SQOOP-371 Diffs ./src/java/com/cloudera/sqoop/util/AppendUtils.java 1187139 ./src/java/com/cloudera/sqoop/util/AsyncSink.java 1187139 ./src/java/com/cloudera/sqoop/util/ClassLoaderStack.java 1187139 ./src/java/com/cloudera/sqoop/util/DirectImportUtils.java 1187139 ./src/java/com/cloudera/sqoop/util/ErrorableAsyncSink.java 1187139 ./src/java/com/cloudera/sqoop/util/ErrorableThread.java 1187139 ./src/java/com/cloudera/sqoop/util/Executor.java 1187139 ./src/java/com/cloudera/sqoop/util/ExitSecurityException.java 1187139 ./src/java/com/cloudera/sqoop/util/ExportException.java 1187139 ./src/java/com/cloudera/sqoop/util/FileListing.java 1187139 ./src/java/com/cloudera/sqoop/util/ImportException.java 1187139 ./src/java/com/cloudera/sqoop/util/Jars.java 1187139 ./src/java/com/cloudera/sqoop/util/JdbcUrl.java 1187139 ./src/java/com/cloudera/sqoop/util/LoggingAsyncSink.java 1187139 ./src/java/com/cloudera/sqoop/util/LoggingUtils.java 1187139 ./src/java/com/cloudera/sqoop/util/NullAsyncSink.java 1187139 ./src/java/com/cloudera/sqoop/util/OptionsFileUtil.java 1187139 ./src/java/com/cloudera/sqoop/util/PerfCounters.java 1187139 ./src/java/com/cloudera/sqoop/util/RandomHash.java 1187139 ./src/java/com/cloudera/sqoop/util/ResultSetPrinter.java 1187139 ./src/java/com/cloudera/sqoop/util/StoredAsProperty.java 1187139 ./src/java/com/cloudera/sqoop/util/SubprocessSecurityManager.java 1187139 ./src/java/com/cloudera/sqoop/util/TaskId.java 1187139 ./src/java/org/apache/sqoop/util/AppendUtils.java PRE-CREATION ./src/java/org/apache/sqoop/util/AsyncSink.java PRE-CREATION ./src/java/org/apache/sqoop/util/ClassLoaderStack.java PRE-CREATION ./src/java/org/apache/sqoop/util/DirectImportUtils.java PRE-CREATION ./src/java/org/apache/sqoop/util/ErrorableAsyncSink.java PRE-CREATION ./src/java/org/apache/sqoop/util/ErrorableThread.java PRE-CREATION ./src/java/org/apache/sqoop/util/Executor.java PRE-CREATION ./src/java/org/apache/sqoop/util/ExitSecurityException.java PRE-CREATION ./src/java/org/apache/sqoop/util/ExportException.java PRE-CREATION ./src/java/org/apache/sqoop/util/FileListing.java PRE-CREATION ./src/java/org/apache/sqoop/util/ImportException.java PRE-CREATION ./src/java/org/apache/sqoop/util/Jars.java PRE-CREATION ./src/java/org/apache/sqoop/util/JdbcUrl.java PRE-CREATION ./src/java/org/apache/sqoop/util/LoggingAsyncSink.java PRE-CREATION ./src/java/org/apache/sqoop/util/LoggingUtils.java PRE-CREATION ./src/java/org/apache/sqoop/util/NullAsyncSink.java PRE-CREATION ./src/java/org/apache/sqoop/util/OptionsFileUtil.java PRE-CREATION ./src/java/org/apache/sqoop/util/PerfCounters.java PRE-CREATION ./src/java/org/apache/sqoop/util/RandomHash.java PRE-CREATION ./src/java/org/apache/sqoop/util/ResultSetPrinter.java PRE-CREATION ./src/java/org/apache/sqoop/util/StoredAsProperty.java PRE-CREATION ./src/java/org/apache/sqoop/util/SubprocessSecurityManager.java PRE-CREATION ./src/java/org/apache/sqoop/util/TaskId.java PRE-CREATION Diff: https://reviews.apache.org/r/2519/diff Testing ------- Thanks, Bilung
        Bilung Lee created issue -

          People

          • Assignee:
            Bilung Lee
            Reporter:
            Bilung Lee
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development