Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4.0-incubating
    • Component/s: None
    • Labels:
      None

      Description

      Refer to SQOOP-371 for details.

        Activity

        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2574/
        -----------------------------------------------------------

        Review request for Sqoop and Bilung Lee.

        Summary
        -------

        Please check whether this is something that we're looking for.

        Just let me firstly explain the weirdness in inheritance between com.cloudera.sqoop.tool.(Base)SqoopTool and org.apache.sqoop.tool.(Base)SqoopTool (and other children). I initially followed specification in master JIRA, but I've end up with not backward compatible code that I have to fix on several places to get it compiled. Problem was in broken inheritance topology - in old com.cloudera.sqoop package there was main parent SqoopTool with child BaseSqoopTool and additional children (ImportTool for example). With my original changes, ImportTool was no longer child of com.cloudera.sqoop.tool.(Base)SqoopTool because it was child of org.apache.sqoop.tool.(Base)SqoopTool instead. I wasn't able to find better solution for this problem than having this weird inheritance in place.

        If you have better idea how to get the job done, please don't hesitate to advise.

        Jarcec

        This addresses bug SQOOP-374.
        https://issues.apache.org/jira/browse/SQOOP-374

        Diffs


        /src/java/com/cloudera/sqoop/orm/AvroSchemaGenerator.java 1189333
        /src/java/com/cloudera/sqoop/orm/ClassWriter.java 1189333
        /src/java/com/cloudera/sqoop/orm/CompilationManager.java 1189333
        /src/java/com/cloudera/sqoop/orm/TableClassName.java 1189333
        /src/java/com/cloudera/sqoop/tool/BaseSqoopTool.java 1189333
        /src/java/com/cloudera/sqoop/tool/CodeGenTool.java 1189333
        /src/java/com/cloudera/sqoop/tool/CreateHiveTableTool.java 1189333
        /src/java/com/cloudera/sqoop/tool/EvalSqlTool.java 1189333
        /src/java/com/cloudera/sqoop/tool/ExportTool.java 1189333
        /src/java/com/cloudera/sqoop/tool/HelpTool.java 1189333
        /src/java/com/cloudera/sqoop/tool/ImportAllTablesTool.java 1189333
        /src/java/com/cloudera/sqoop/tool/ImportTool.java 1189333
        /src/java/com/cloudera/sqoop/tool/JobTool.java 1189333
        /src/java/com/cloudera/sqoop/tool/ListDatabasesTool.java 1189333
        /src/java/com/cloudera/sqoop/tool/ListTablesTool.java 1189333
        /src/java/com/cloudera/sqoop/tool/MergeTool.java 1189333
        /src/java/com/cloudera/sqoop/tool/MetastoreTool.java 1189333
        /src/java/com/cloudera/sqoop/tool/SqoopTool.java 1189333
        /src/java/com/cloudera/sqoop/tool/ToolDesc.java 1189333
        /src/java/com/cloudera/sqoop/tool/ToolPlugin.java 1189333
        /src/java/com/cloudera/sqoop/tool/VersionTool.java 1189333
        /src/java/org/apache/sqoop/orm/AvroSchemaGenerator.java PRE-CREATION
        /src/java/org/apache/sqoop/orm/ClassWriter.java PRE-CREATION
        /src/java/org/apache/sqoop/orm/CompilationManager.java PRE-CREATION
        /src/java/org/apache/sqoop/orm/TableClassName.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/BaseSqoopTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/CodeGenTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/CreateHiveTableTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/EvalSqlTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/ExportTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/HelpTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/ImportAllTablesTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/ImportTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/JobTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/ListDatabasesTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/ListTablesTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/MergeTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/MetastoreTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/SqoopTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/ToolDesc.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/ToolPlugin.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/VersionTool.java PRE-CREATION
        /src/test/com/cloudera/sqoop/orm/TestClassWriter.java 1189333
        /src/test/com/cloudera/sqoop/orm/TestParseMethods.java 1189333
        /src/test/com/cloudera/sqoop/tool/TestToolPlugin.java 1189333

        Diff: https://reviews.apache.org/r/2574/diff

        Testing
        -------

        Thanks,

        Jarek

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2574/ ----------------------------------------------------------- Review request for Sqoop and Bilung Lee. Summary ------- Please check whether this is something that we're looking for. Just let me firstly explain the weirdness in inheritance between com.cloudera.sqoop.tool.(Base)SqoopTool and org.apache.sqoop.tool.(Base)SqoopTool (and other children). I initially followed specification in master JIRA, but I've end up with not backward compatible code that I have to fix on several places to get it compiled. Problem was in broken inheritance topology - in old com.cloudera.sqoop package there was main parent SqoopTool with child BaseSqoopTool and additional children (ImportTool for example). With my original changes, ImportTool was no longer child of com.cloudera.sqoop.tool.(Base)SqoopTool because it was child of org.apache.sqoop.tool.(Base)SqoopTool instead. I wasn't able to find better solution for this problem than having this weird inheritance in place. If you have better idea how to get the job done, please don't hesitate to advise. Jarcec This addresses bug SQOOP-374 . https://issues.apache.org/jira/browse/SQOOP-374 Diffs /src/java/com/cloudera/sqoop/orm/AvroSchemaGenerator.java 1189333 /src/java/com/cloudera/sqoop/orm/ClassWriter.java 1189333 /src/java/com/cloudera/sqoop/orm/CompilationManager.java 1189333 /src/java/com/cloudera/sqoop/orm/TableClassName.java 1189333 /src/java/com/cloudera/sqoop/tool/BaseSqoopTool.java 1189333 /src/java/com/cloudera/sqoop/tool/CodeGenTool.java 1189333 /src/java/com/cloudera/sqoop/tool/CreateHiveTableTool.java 1189333 /src/java/com/cloudera/sqoop/tool/EvalSqlTool.java 1189333 /src/java/com/cloudera/sqoop/tool/ExportTool.java 1189333 /src/java/com/cloudera/sqoop/tool/HelpTool.java 1189333 /src/java/com/cloudera/sqoop/tool/ImportAllTablesTool.java 1189333 /src/java/com/cloudera/sqoop/tool/ImportTool.java 1189333 /src/java/com/cloudera/sqoop/tool/JobTool.java 1189333 /src/java/com/cloudera/sqoop/tool/ListDatabasesTool.java 1189333 /src/java/com/cloudera/sqoop/tool/ListTablesTool.java 1189333 /src/java/com/cloudera/sqoop/tool/MergeTool.java 1189333 /src/java/com/cloudera/sqoop/tool/MetastoreTool.java 1189333 /src/java/com/cloudera/sqoop/tool/SqoopTool.java 1189333 /src/java/com/cloudera/sqoop/tool/ToolDesc.java 1189333 /src/java/com/cloudera/sqoop/tool/ToolPlugin.java 1189333 /src/java/com/cloudera/sqoop/tool/VersionTool.java 1189333 /src/java/org/apache/sqoop/orm/AvroSchemaGenerator.java PRE-CREATION /src/java/org/apache/sqoop/orm/ClassWriter.java PRE-CREATION /src/java/org/apache/sqoop/orm/CompilationManager.java PRE-CREATION /src/java/org/apache/sqoop/orm/TableClassName.java PRE-CREATION /src/java/org/apache/sqoop/tool/BaseSqoopTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/CodeGenTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/CreateHiveTableTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/EvalSqlTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ExportTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/HelpTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ImportAllTablesTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ImportTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/JobTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ListDatabasesTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ListTablesTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/MergeTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/MetastoreTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/SqoopTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ToolDesc.java PRE-CREATION /src/java/org/apache/sqoop/tool/ToolPlugin.java PRE-CREATION /src/java/org/apache/sqoop/tool/VersionTool.java PRE-CREATION /src/test/com/cloudera/sqoop/orm/TestClassWriter.java 1189333 /src/test/com/cloudera/sqoop/orm/TestParseMethods.java 1189333 /src/test/com/cloudera/sqoop/tool/TestToolPlugin.java 1189333 Diff: https://reviews.apache.org/r/2574/diff Testing ------- Thanks, Jarek
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2574/
        -----------------------------------------------------------

        (Updated 2011-10-26 21:08:58.252476)

        Review request for Sqoop and Bilung Lee.

        Changes
        -------

        I've added public constants to old classes as Arvind has described on his migration wiki. Also I've obviously had same idea as Arvind regarding the inheritance topology, so feel free to ignore my second paragraph.

        Jarcec

        Summary
        -------

        Please check whether this is something that we're looking for.

        Just let me firstly explain the weirdness in inheritance between com.cloudera.sqoop.tool.(Base)SqoopTool and org.apache.sqoop.tool.(Base)SqoopTool (and other children). I initially followed specification in master JIRA, but I've end up with not backward compatible code that I have to fix on several places to get it compiled. Problem was in broken inheritance topology - in old com.cloudera.sqoop package there was main parent SqoopTool with child BaseSqoopTool and additional children (ImportTool for example). With my original changes, ImportTool was no longer child of com.cloudera.sqoop.tool.(Base)SqoopTool because it was child of org.apache.sqoop.tool.(Base)SqoopTool instead. I wasn't able to find better solution for this problem than having this weird inheritance in place.

        If you have better idea how to get the job done, please don't hesitate to advise.

        Jarcec

        This addresses bug SQOOP-374.
        https://issues.apache.org/jira/browse/SQOOP-374

        Diffs (updated)


        /src/java/com/cloudera/sqoop/orm/AvroSchemaGenerator.java 1189333
        /src/java/com/cloudera/sqoop/orm/ClassWriter.java 1189333
        /src/java/com/cloudera/sqoop/orm/CompilationManager.java 1189333
        /src/java/com/cloudera/sqoop/orm/TableClassName.java 1189333
        /src/java/com/cloudera/sqoop/tool/BaseSqoopTool.java 1189333
        /src/java/com/cloudera/sqoop/tool/CodeGenTool.java 1189333
        /src/java/com/cloudera/sqoop/tool/CreateHiveTableTool.java 1189333
        /src/java/com/cloudera/sqoop/tool/EvalSqlTool.java 1189333
        /src/java/com/cloudera/sqoop/tool/ExportTool.java 1189333
        /src/java/com/cloudera/sqoop/tool/HelpTool.java 1189333
        /src/java/com/cloudera/sqoop/tool/ImportAllTablesTool.java 1189333
        /src/java/com/cloudera/sqoop/tool/ImportTool.java 1189333
        /src/java/com/cloudera/sqoop/tool/JobTool.java 1189333
        /src/java/com/cloudera/sqoop/tool/ListDatabasesTool.java 1189333
        /src/java/com/cloudera/sqoop/tool/ListTablesTool.java 1189333
        /src/java/com/cloudera/sqoop/tool/MergeTool.java 1189333
        /src/java/com/cloudera/sqoop/tool/MetastoreTool.java 1189333
        /src/java/com/cloudera/sqoop/tool/SqoopTool.java 1189333
        /src/java/com/cloudera/sqoop/tool/ToolDesc.java 1189333
        /src/java/com/cloudera/sqoop/tool/ToolPlugin.java 1189333
        /src/java/com/cloudera/sqoop/tool/VersionTool.java 1189333
        /src/java/org/apache/sqoop/orm/AvroSchemaGenerator.java PRE-CREATION
        /src/java/org/apache/sqoop/orm/ClassWriter.java PRE-CREATION
        /src/java/org/apache/sqoop/orm/CompilationManager.java PRE-CREATION
        /src/java/org/apache/sqoop/orm/TableClassName.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/BaseSqoopTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/CodeGenTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/CreateHiveTableTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/EvalSqlTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/ExportTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/HelpTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/ImportAllTablesTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/ImportTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/JobTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/ListDatabasesTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/ListTablesTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/MergeTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/MetastoreTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/SqoopTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/ToolDesc.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/ToolPlugin.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/VersionTool.java PRE-CREATION
        /src/test/com/cloudera/sqoop/orm/TestClassWriter.java 1189333
        /src/test/com/cloudera/sqoop/orm/TestParseMethods.java 1189333
        /src/test/com/cloudera/sqoop/tool/TestToolPlugin.java 1189333

        Diff: https://reviews.apache.org/r/2574/diff

        Testing
        -------

        Thanks,

        Jarek

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2574/ ----------------------------------------------------------- (Updated 2011-10-26 21:08:58.252476) Review request for Sqoop and Bilung Lee. Changes ------- I've added public constants to old classes as Arvind has described on his migration wiki. Also I've obviously had same idea as Arvind regarding the inheritance topology, so feel free to ignore my second paragraph. Jarcec Summary ------- Please check whether this is something that we're looking for. Just let me firstly explain the weirdness in inheritance between com.cloudera.sqoop.tool.(Base)SqoopTool and org.apache.sqoop.tool.(Base)SqoopTool (and other children). I initially followed specification in master JIRA, but I've end up with not backward compatible code that I have to fix on several places to get it compiled. Problem was in broken inheritance topology - in old com.cloudera.sqoop package there was main parent SqoopTool with child BaseSqoopTool and additional children (ImportTool for example). With my original changes, ImportTool was no longer child of com.cloudera.sqoop.tool.(Base)SqoopTool because it was child of org.apache.sqoop.tool.(Base)SqoopTool instead. I wasn't able to find better solution for this problem than having this weird inheritance in place. If you have better idea how to get the job done, please don't hesitate to advise. Jarcec This addresses bug SQOOP-374 . https://issues.apache.org/jira/browse/SQOOP-374 Diffs (updated) /src/java/com/cloudera/sqoop/orm/AvroSchemaGenerator.java 1189333 /src/java/com/cloudera/sqoop/orm/ClassWriter.java 1189333 /src/java/com/cloudera/sqoop/orm/CompilationManager.java 1189333 /src/java/com/cloudera/sqoop/orm/TableClassName.java 1189333 /src/java/com/cloudera/sqoop/tool/BaseSqoopTool.java 1189333 /src/java/com/cloudera/sqoop/tool/CodeGenTool.java 1189333 /src/java/com/cloudera/sqoop/tool/CreateHiveTableTool.java 1189333 /src/java/com/cloudera/sqoop/tool/EvalSqlTool.java 1189333 /src/java/com/cloudera/sqoop/tool/ExportTool.java 1189333 /src/java/com/cloudera/sqoop/tool/HelpTool.java 1189333 /src/java/com/cloudera/sqoop/tool/ImportAllTablesTool.java 1189333 /src/java/com/cloudera/sqoop/tool/ImportTool.java 1189333 /src/java/com/cloudera/sqoop/tool/JobTool.java 1189333 /src/java/com/cloudera/sqoop/tool/ListDatabasesTool.java 1189333 /src/java/com/cloudera/sqoop/tool/ListTablesTool.java 1189333 /src/java/com/cloudera/sqoop/tool/MergeTool.java 1189333 /src/java/com/cloudera/sqoop/tool/MetastoreTool.java 1189333 /src/java/com/cloudera/sqoop/tool/SqoopTool.java 1189333 /src/java/com/cloudera/sqoop/tool/ToolDesc.java 1189333 /src/java/com/cloudera/sqoop/tool/ToolPlugin.java 1189333 /src/java/com/cloudera/sqoop/tool/VersionTool.java 1189333 /src/java/org/apache/sqoop/orm/AvroSchemaGenerator.java PRE-CREATION /src/java/org/apache/sqoop/orm/ClassWriter.java PRE-CREATION /src/java/org/apache/sqoop/orm/CompilationManager.java PRE-CREATION /src/java/org/apache/sqoop/orm/TableClassName.java PRE-CREATION /src/java/org/apache/sqoop/tool/BaseSqoopTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/CodeGenTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/CreateHiveTableTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/EvalSqlTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ExportTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/HelpTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ImportAllTablesTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ImportTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/JobTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ListDatabasesTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ListTablesTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/MergeTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/MetastoreTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/SqoopTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ToolDesc.java PRE-CREATION /src/java/org/apache/sqoop/tool/ToolPlugin.java PRE-CREATION /src/java/org/apache/sqoop/tool/VersionTool.java PRE-CREATION /src/test/com/cloudera/sqoop/orm/TestClassWriter.java 1189333 /src/test/com/cloudera/sqoop/orm/TestParseMethods.java 1189333 /src/test/com/cloudera/sqoop/tool/TestToolPlugin.java 1189333 Diff: https://reviews.apache.org/r/2574/diff Testing ------- Thanks, Jarek
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2574/#review2895
        -----------------------------------------------------------

        Thanks for the patch, Jarcec! There seems to be a problem for those new classes under apache namespace to show diff on review board. Could you double check and submit a new one? Thanks.

        • Bilung

        On 2011-10-26 21:08:58, Jarek Jarcec wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2574/

        -----------------------------------------------------------

        (Updated 2011-10-26 21:08:58)

        Review request for Sqoop and Bilung Lee.

        Summary

        -------

        Please check whether this is something that we're looking for.

        Just let me firstly explain the weirdness in inheritance between com.cloudera.sqoop.tool.(Base)SqoopTool and org.apache.sqoop.tool.(Base)SqoopTool (and other children). I initially followed specification in master JIRA, but I've end up with not backward compatible code that I have to fix on several places to get it compiled. Problem was in broken inheritance topology - in old com.cloudera.sqoop package there was main parent SqoopTool with child BaseSqoopTool and additional children (ImportTool for example). With my original changes, ImportTool was no longer child of com.cloudera.sqoop.tool.(Base)SqoopTool because it was child of org.apache.sqoop.tool.(Base)SqoopTool instead. I wasn't able to find better solution for this problem than having this weird inheritance in place.

        If you have better idea how to get the job done, please don't hesitate to advise.

        Jarcec

        This addresses bug SQOOP-374.

        https://issues.apache.org/jira/browse/SQOOP-374

        Diffs

        -----

        /src/java/com/cloudera/sqoop/orm/AvroSchemaGenerator.java 1189333

        /src/java/com/cloudera/sqoop/orm/ClassWriter.java 1189333

        /src/java/com/cloudera/sqoop/orm/CompilationManager.java 1189333

        /src/java/com/cloudera/sqoop/orm/TableClassName.java 1189333

        /src/java/com/cloudera/sqoop/tool/BaseSqoopTool.java 1189333

        /src/java/com/cloudera/sqoop/tool/CodeGenTool.java 1189333

        /src/java/com/cloudera/sqoop/tool/CreateHiveTableTool.java 1189333

        /src/java/com/cloudera/sqoop/tool/EvalSqlTool.java 1189333

        /src/java/com/cloudera/sqoop/tool/ExportTool.java 1189333

        /src/java/com/cloudera/sqoop/tool/HelpTool.java 1189333

        /src/java/com/cloudera/sqoop/tool/ImportAllTablesTool.java 1189333

        /src/java/com/cloudera/sqoop/tool/ImportTool.java 1189333

        /src/java/com/cloudera/sqoop/tool/JobTool.java 1189333

        /src/java/com/cloudera/sqoop/tool/ListDatabasesTool.java 1189333

        /src/java/com/cloudera/sqoop/tool/ListTablesTool.java 1189333

        /src/java/com/cloudera/sqoop/tool/MergeTool.java 1189333

        /src/java/com/cloudera/sqoop/tool/MetastoreTool.java 1189333

        /src/java/com/cloudera/sqoop/tool/SqoopTool.java 1189333

        /src/java/com/cloudera/sqoop/tool/ToolDesc.java 1189333

        /src/java/com/cloudera/sqoop/tool/ToolPlugin.java 1189333

        /src/java/com/cloudera/sqoop/tool/VersionTool.java 1189333

        /src/java/org/apache/sqoop/orm/AvroSchemaGenerator.java PRE-CREATION

        /src/java/org/apache/sqoop/orm/ClassWriter.java PRE-CREATION

        /src/java/org/apache/sqoop/orm/CompilationManager.java PRE-CREATION

        /src/java/org/apache/sqoop/orm/TableClassName.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/BaseSqoopTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/CodeGenTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/CreateHiveTableTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/EvalSqlTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/ExportTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/HelpTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/ImportAllTablesTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/ImportTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/JobTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/ListDatabasesTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/ListTablesTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/MergeTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/MetastoreTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/SqoopTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/ToolDesc.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/ToolPlugin.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/VersionTool.java PRE-CREATION

        /src/test/com/cloudera/sqoop/orm/TestClassWriter.java 1189333

        /src/test/com/cloudera/sqoop/orm/TestParseMethods.java 1189333

        /src/test/com/cloudera/sqoop/tool/TestToolPlugin.java 1189333

        Diff: https://reviews.apache.org/r/2574/diff

        Testing

        -------

        Thanks,

        Jarek

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2574/#review2895 ----------------------------------------------------------- Thanks for the patch, Jarcec! There seems to be a problem for those new classes under apache namespace to show diff on review board. Could you double check and submit a new one? Thanks. Bilung On 2011-10-26 21:08:58, Jarek Jarcec wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2574/ ----------------------------------------------------------- (Updated 2011-10-26 21:08:58) Review request for Sqoop and Bilung Lee. Summary ------- Please check whether this is something that we're looking for. Just let me firstly explain the weirdness in inheritance between com.cloudera.sqoop.tool.(Base)SqoopTool and org.apache.sqoop.tool.(Base)SqoopTool (and other children). I initially followed specification in master JIRA, but I've end up with not backward compatible code that I have to fix on several places to get it compiled. Problem was in broken inheritance topology - in old com.cloudera.sqoop package there was main parent SqoopTool with child BaseSqoopTool and additional children (ImportTool for example). With my original changes, ImportTool was no longer child of com.cloudera.sqoop.tool.(Base)SqoopTool because it was child of org.apache.sqoop.tool.(Base)SqoopTool instead. I wasn't able to find better solution for this problem than having this weird inheritance in place. If you have better idea how to get the job done, please don't hesitate to advise. Jarcec This addresses bug SQOOP-374 . https://issues.apache.org/jira/browse/SQOOP-374 Diffs ----- /src/java/com/cloudera/sqoop/orm/AvroSchemaGenerator.java 1189333 /src/java/com/cloudera/sqoop/orm/ClassWriter.java 1189333 /src/java/com/cloudera/sqoop/orm/CompilationManager.java 1189333 /src/java/com/cloudera/sqoop/orm/TableClassName.java 1189333 /src/java/com/cloudera/sqoop/tool/BaseSqoopTool.java 1189333 /src/java/com/cloudera/sqoop/tool/CodeGenTool.java 1189333 /src/java/com/cloudera/sqoop/tool/CreateHiveTableTool.java 1189333 /src/java/com/cloudera/sqoop/tool/EvalSqlTool.java 1189333 /src/java/com/cloudera/sqoop/tool/ExportTool.java 1189333 /src/java/com/cloudera/sqoop/tool/HelpTool.java 1189333 /src/java/com/cloudera/sqoop/tool/ImportAllTablesTool.java 1189333 /src/java/com/cloudera/sqoop/tool/ImportTool.java 1189333 /src/java/com/cloudera/sqoop/tool/JobTool.java 1189333 /src/java/com/cloudera/sqoop/tool/ListDatabasesTool.java 1189333 /src/java/com/cloudera/sqoop/tool/ListTablesTool.java 1189333 /src/java/com/cloudera/sqoop/tool/MergeTool.java 1189333 /src/java/com/cloudera/sqoop/tool/MetastoreTool.java 1189333 /src/java/com/cloudera/sqoop/tool/SqoopTool.java 1189333 /src/java/com/cloudera/sqoop/tool/ToolDesc.java 1189333 /src/java/com/cloudera/sqoop/tool/ToolPlugin.java 1189333 /src/java/com/cloudera/sqoop/tool/VersionTool.java 1189333 /src/java/org/apache/sqoop/orm/AvroSchemaGenerator.java PRE-CREATION /src/java/org/apache/sqoop/orm/ClassWriter.java PRE-CREATION /src/java/org/apache/sqoop/orm/CompilationManager.java PRE-CREATION /src/java/org/apache/sqoop/orm/TableClassName.java PRE-CREATION /src/java/org/apache/sqoop/tool/BaseSqoopTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/CodeGenTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/CreateHiveTableTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/EvalSqlTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ExportTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/HelpTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ImportAllTablesTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ImportTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/JobTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ListDatabasesTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ListTablesTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/MergeTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/MetastoreTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/SqoopTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ToolDesc.java PRE-CREATION /src/java/org/apache/sqoop/tool/ToolPlugin.java PRE-CREATION /src/java/org/apache/sqoop/tool/VersionTool.java PRE-CREATION /src/test/com/cloudera/sqoop/orm/TestClassWriter.java 1189333 /src/test/com/cloudera/sqoop/orm/TestParseMethods.java 1189333 /src/test/com/cloudera/sqoop/tool/TestToolPlugin.java 1189333 Diff: https://reviews.apache.org/r/2574/diff Testing ------- Thanks, Jarek
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2574/
        -----------------------------------------------------------

        (Updated 2011-10-28 06:51:43.282101)

        Review request for Sqoop and Bilung Lee.

        Changes
        -------

        I'm attaching updated version Bilung.

        Seems like SVN is little buggy - I've used SVN move to move files around and in such case, generated diff seems to be invalid.

        Jarcec

        Summary
        -------

        Please check whether this is something that we're looking for.

        Just let me firstly explain the weirdness in inheritance between com.cloudera.sqoop.tool.(Base)SqoopTool and org.apache.sqoop.tool.(Base)SqoopTool (and other children). I initially followed specification in master JIRA, but I've end up with not backward compatible code that I have to fix on several places to get it compiled. Problem was in broken inheritance topology - in old com.cloudera.sqoop package there was main parent SqoopTool with child BaseSqoopTool and additional children (ImportTool for example). With my original changes, ImportTool was no longer child of com.cloudera.sqoop.tool.(Base)SqoopTool because it was child of org.apache.sqoop.tool.(Base)SqoopTool instead. I wasn't able to find better solution for this problem than having this weird inheritance in place.

        If you have better idea how to get the job done, please don't hesitate to advise.

        Jarcec

        This addresses bug SQOOP-374.
        https://issues.apache.org/jira/browse/SQOOP-374

        Diffs (updated)


        /src/java/com/cloudera/sqoop/orm/AvroSchemaGenerator.java 1190173
        /src/java/com/cloudera/sqoop/orm/ClassWriter.java 1190173
        /src/java/com/cloudera/sqoop/orm/CompilationManager.java 1190173
        /src/java/com/cloudera/sqoop/orm/TableClassName.java 1190173
        /src/java/com/cloudera/sqoop/tool/BaseSqoopTool.java 1190173
        /src/java/com/cloudera/sqoop/tool/CodeGenTool.java 1190173
        /src/java/com/cloudera/sqoop/tool/CreateHiveTableTool.java 1190173
        /src/java/com/cloudera/sqoop/tool/EvalSqlTool.java 1190173
        /src/java/com/cloudera/sqoop/tool/ExportTool.java 1190173
        /src/java/com/cloudera/sqoop/tool/HelpTool.java 1190173
        /src/java/com/cloudera/sqoop/tool/ImportAllTablesTool.java 1190173
        /src/java/com/cloudera/sqoop/tool/ImportTool.java 1190173
        /src/java/com/cloudera/sqoop/tool/JobTool.java 1190173
        /src/java/com/cloudera/sqoop/tool/ListDatabasesTool.java 1190173
        /src/java/com/cloudera/sqoop/tool/ListTablesTool.java 1190173
        /src/java/com/cloudera/sqoop/tool/MergeTool.java 1190173
        /src/java/com/cloudera/sqoop/tool/MetastoreTool.java 1190173
        /src/java/com/cloudera/sqoop/tool/SqoopTool.java 1190173
        /src/java/com/cloudera/sqoop/tool/ToolDesc.java 1190173
        /src/java/com/cloudera/sqoop/tool/ToolPlugin.java 1190173
        /src/java/com/cloudera/sqoop/tool/VersionTool.java 1190173
        /src/java/org/apache/sqoop/orm/AvroSchemaGenerator.java PRE-CREATION
        /src/java/org/apache/sqoop/orm/ClassWriter.java PRE-CREATION
        /src/java/org/apache/sqoop/orm/CompilationManager.java PRE-CREATION
        /src/java/org/apache/sqoop/orm/TableClassName.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/BaseSqoopTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/CodeGenTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/CreateHiveTableTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/EvalSqlTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/ExportTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/HelpTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/ImportAllTablesTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/ImportTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/JobTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/ListDatabasesTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/ListTablesTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/MergeTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/MetastoreTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/SqoopTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/ToolDesc.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/ToolPlugin.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/VersionTool.java PRE-CREATION
        /src/test/com/cloudera/sqoop/orm/TestClassWriter.java 1190173
        /src/test/com/cloudera/sqoop/orm/TestParseMethods.java 1190173
        /src/test/com/cloudera/sqoop/tool/TestToolPlugin.java 1190173

        Diff: https://reviews.apache.org/r/2574/diff

        Testing
        -------

        Thanks,

        Jarek

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2574/ ----------------------------------------------------------- (Updated 2011-10-28 06:51:43.282101) Review request for Sqoop and Bilung Lee. Changes ------- I'm attaching updated version Bilung. Seems like SVN is little buggy - I've used SVN move to move files around and in such case, generated diff seems to be invalid. Jarcec Summary ------- Please check whether this is something that we're looking for. Just let me firstly explain the weirdness in inheritance between com.cloudera.sqoop.tool.(Base)SqoopTool and org.apache.sqoop.tool.(Base)SqoopTool (and other children). I initially followed specification in master JIRA, but I've end up with not backward compatible code that I have to fix on several places to get it compiled. Problem was in broken inheritance topology - in old com.cloudera.sqoop package there was main parent SqoopTool with child BaseSqoopTool and additional children (ImportTool for example). With my original changes, ImportTool was no longer child of com.cloudera.sqoop.tool.(Base)SqoopTool because it was child of org.apache.sqoop.tool.(Base)SqoopTool instead. I wasn't able to find better solution for this problem than having this weird inheritance in place. If you have better idea how to get the job done, please don't hesitate to advise. Jarcec This addresses bug SQOOP-374 . https://issues.apache.org/jira/browse/SQOOP-374 Diffs (updated) /src/java/com/cloudera/sqoop/orm/AvroSchemaGenerator.java 1190173 /src/java/com/cloudera/sqoop/orm/ClassWriter.java 1190173 /src/java/com/cloudera/sqoop/orm/CompilationManager.java 1190173 /src/java/com/cloudera/sqoop/orm/TableClassName.java 1190173 /src/java/com/cloudera/sqoop/tool/BaseSqoopTool.java 1190173 /src/java/com/cloudera/sqoop/tool/CodeGenTool.java 1190173 /src/java/com/cloudera/sqoop/tool/CreateHiveTableTool.java 1190173 /src/java/com/cloudera/sqoop/tool/EvalSqlTool.java 1190173 /src/java/com/cloudera/sqoop/tool/ExportTool.java 1190173 /src/java/com/cloudera/sqoop/tool/HelpTool.java 1190173 /src/java/com/cloudera/sqoop/tool/ImportAllTablesTool.java 1190173 /src/java/com/cloudera/sqoop/tool/ImportTool.java 1190173 /src/java/com/cloudera/sqoop/tool/JobTool.java 1190173 /src/java/com/cloudera/sqoop/tool/ListDatabasesTool.java 1190173 /src/java/com/cloudera/sqoop/tool/ListTablesTool.java 1190173 /src/java/com/cloudera/sqoop/tool/MergeTool.java 1190173 /src/java/com/cloudera/sqoop/tool/MetastoreTool.java 1190173 /src/java/com/cloudera/sqoop/tool/SqoopTool.java 1190173 /src/java/com/cloudera/sqoop/tool/ToolDesc.java 1190173 /src/java/com/cloudera/sqoop/tool/ToolPlugin.java 1190173 /src/java/com/cloudera/sqoop/tool/VersionTool.java 1190173 /src/java/org/apache/sqoop/orm/AvroSchemaGenerator.java PRE-CREATION /src/java/org/apache/sqoop/orm/ClassWriter.java PRE-CREATION /src/java/org/apache/sqoop/orm/CompilationManager.java PRE-CREATION /src/java/org/apache/sqoop/orm/TableClassName.java PRE-CREATION /src/java/org/apache/sqoop/tool/BaseSqoopTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/CodeGenTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/CreateHiveTableTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/EvalSqlTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ExportTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/HelpTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ImportAllTablesTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ImportTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/JobTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ListDatabasesTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ListTablesTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/MergeTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/MetastoreTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/SqoopTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ToolDesc.java PRE-CREATION /src/java/org/apache/sqoop/tool/ToolPlugin.java PRE-CREATION /src/java/org/apache/sqoop/tool/VersionTool.java PRE-CREATION /src/test/com/cloudera/sqoop/orm/TestClassWriter.java 1190173 /src/test/com/cloudera/sqoop/orm/TestParseMethods.java 1190173 /src/test/com/cloudera/sqoop/tool/TestToolPlugin.java 1190173 Diff: https://reviews.apache.org/r/2574/diff Testing ------- Thanks, Jarek
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2574/#review2908
        -----------------------------------------------------------

        Look good to me, Jarcec! Just some comments.

        /src/java/com/cloudera/sqoop/orm/ClassWriter.java
        <https://reviews.apache.org/r/2574/#comment6519>

        Similar to public static fields, also keep the signature in subclass and then call into superclass.

        /src/java/com/cloudera/sqoop/orm/ClassWriter.java
        <https://reviews.apache.org/r/2574/#comment6520>

        Same as above.

        /src/java/com/cloudera/sqoop/tool/SqoopTool.java
        <https://reviews.apache.org/r/2574/#comment6505>

        Remove trailing whitespace.

        • Bilung

        On 2011-10-28 06:51:43, Jarek Jarcec wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2574/

        -----------------------------------------------------------

        (Updated 2011-10-28 06:51:43)

        Review request for Sqoop and Bilung Lee.

        Summary

        -------

        Please check whether this is something that we're looking for.

        Just let me firstly explain the weirdness in inheritance between com.cloudera.sqoop.tool.(Base)SqoopTool and org.apache.sqoop.tool.(Base)SqoopTool (and other children). I initially followed specification in master JIRA, but I've end up with not backward compatible code that I have to fix on several places to get it compiled. Problem was in broken inheritance topology - in old com.cloudera.sqoop package there was main parent SqoopTool with child BaseSqoopTool and additional children (ImportTool for example). With my original changes, ImportTool was no longer child of com.cloudera.sqoop.tool.(Base)SqoopTool because it was child of org.apache.sqoop.tool.(Base)SqoopTool instead. I wasn't able to find better solution for this problem than having this weird inheritance in place.

        If you have better idea how to get the job done, please don't hesitate to advise.

        Jarcec

        This addresses bug SQOOP-374.

        https://issues.apache.org/jira/browse/SQOOP-374

        Diffs

        -----

        /src/java/com/cloudera/sqoop/orm/AvroSchemaGenerator.java 1190173

        /src/java/com/cloudera/sqoop/orm/ClassWriter.java 1190173

        /src/java/com/cloudera/sqoop/orm/CompilationManager.java 1190173

        /src/java/com/cloudera/sqoop/orm/TableClassName.java 1190173

        /src/java/com/cloudera/sqoop/tool/BaseSqoopTool.java 1190173

        /src/java/com/cloudera/sqoop/tool/CodeGenTool.java 1190173

        /src/java/com/cloudera/sqoop/tool/CreateHiveTableTool.java 1190173

        /src/java/com/cloudera/sqoop/tool/EvalSqlTool.java 1190173

        /src/java/com/cloudera/sqoop/tool/ExportTool.java 1190173

        /src/java/com/cloudera/sqoop/tool/HelpTool.java 1190173

        /src/java/com/cloudera/sqoop/tool/ImportAllTablesTool.java 1190173

        /src/java/com/cloudera/sqoop/tool/ImportTool.java 1190173

        /src/java/com/cloudera/sqoop/tool/JobTool.java 1190173

        /src/java/com/cloudera/sqoop/tool/ListDatabasesTool.java 1190173

        /src/java/com/cloudera/sqoop/tool/ListTablesTool.java 1190173

        /src/java/com/cloudera/sqoop/tool/MergeTool.java 1190173

        /src/java/com/cloudera/sqoop/tool/MetastoreTool.java 1190173

        /src/java/com/cloudera/sqoop/tool/SqoopTool.java 1190173

        /src/java/com/cloudera/sqoop/tool/ToolDesc.java 1190173

        /src/java/com/cloudera/sqoop/tool/ToolPlugin.java 1190173

        /src/java/com/cloudera/sqoop/tool/VersionTool.java 1190173

        /src/java/org/apache/sqoop/orm/AvroSchemaGenerator.java PRE-CREATION

        /src/java/org/apache/sqoop/orm/ClassWriter.java PRE-CREATION

        /src/java/org/apache/sqoop/orm/CompilationManager.java PRE-CREATION

        /src/java/org/apache/sqoop/orm/TableClassName.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/BaseSqoopTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/CodeGenTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/CreateHiveTableTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/EvalSqlTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/ExportTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/HelpTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/ImportAllTablesTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/ImportTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/JobTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/ListDatabasesTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/ListTablesTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/MergeTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/MetastoreTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/SqoopTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/ToolDesc.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/ToolPlugin.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/VersionTool.java PRE-CREATION

        /src/test/com/cloudera/sqoop/orm/TestClassWriter.java 1190173

        /src/test/com/cloudera/sqoop/orm/TestParseMethods.java 1190173

        /src/test/com/cloudera/sqoop/tool/TestToolPlugin.java 1190173

        Diff: https://reviews.apache.org/r/2574/diff

        Testing

        -------

        Thanks,

        Jarek

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2574/#review2908 ----------------------------------------------------------- Look good to me, Jarcec! Just some comments. /src/java/com/cloudera/sqoop/orm/ClassWriter.java < https://reviews.apache.org/r/2574/#comment6519 > Similar to public static fields, also keep the signature in subclass and then call into superclass. /src/java/com/cloudera/sqoop/orm/ClassWriter.java < https://reviews.apache.org/r/2574/#comment6520 > Same as above. /src/java/com/cloudera/sqoop/tool/SqoopTool.java < https://reviews.apache.org/r/2574/#comment6505 > Remove trailing whitespace. Bilung On 2011-10-28 06:51:43, Jarek Jarcec wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2574/ ----------------------------------------------------------- (Updated 2011-10-28 06:51:43) Review request for Sqoop and Bilung Lee. Summary ------- Please check whether this is something that we're looking for. Just let me firstly explain the weirdness in inheritance between com.cloudera.sqoop.tool.(Base)SqoopTool and org.apache.sqoop.tool.(Base)SqoopTool (and other children). I initially followed specification in master JIRA, but I've end up with not backward compatible code that I have to fix on several places to get it compiled. Problem was in broken inheritance topology - in old com.cloudera.sqoop package there was main parent SqoopTool with child BaseSqoopTool and additional children (ImportTool for example). With my original changes, ImportTool was no longer child of com.cloudera.sqoop.tool.(Base)SqoopTool because it was child of org.apache.sqoop.tool.(Base)SqoopTool instead. I wasn't able to find better solution for this problem than having this weird inheritance in place. If you have better idea how to get the job done, please don't hesitate to advise. Jarcec This addresses bug SQOOP-374 . https://issues.apache.org/jira/browse/SQOOP-374 Diffs ----- /src/java/com/cloudera/sqoop/orm/AvroSchemaGenerator.java 1190173 /src/java/com/cloudera/sqoop/orm/ClassWriter.java 1190173 /src/java/com/cloudera/sqoop/orm/CompilationManager.java 1190173 /src/java/com/cloudera/sqoop/orm/TableClassName.java 1190173 /src/java/com/cloudera/sqoop/tool/BaseSqoopTool.java 1190173 /src/java/com/cloudera/sqoop/tool/CodeGenTool.java 1190173 /src/java/com/cloudera/sqoop/tool/CreateHiveTableTool.java 1190173 /src/java/com/cloudera/sqoop/tool/EvalSqlTool.java 1190173 /src/java/com/cloudera/sqoop/tool/ExportTool.java 1190173 /src/java/com/cloudera/sqoop/tool/HelpTool.java 1190173 /src/java/com/cloudera/sqoop/tool/ImportAllTablesTool.java 1190173 /src/java/com/cloudera/sqoop/tool/ImportTool.java 1190173 /src/java/com/cloudera/sqoop/tool/JobTool.java 1190173 /src/java/com/cloudera/sqoop/tool/ListDatabasesTool.java 1190173 /src/java/com/cloudera/sqoop/tool/ListTablesTool.java 1190173 /src/java/com/cloudera/sqoop/tool/MergeTool.java 1190173 /src/java/com/cloudera/sqoop/tool/MetastoreTool.java 1190173 /src/java/com/cloudera/sqoop/tool/SqoopTool.java 1190173 /src/java/com/cloudera/sqoop/tool/ToolDesc.java 1190173 /src/java/com/cloudera/sqoop/tool/ToolPlugin.java 1190173 /src/java/com/cloudera/sqoop/tool/VersionTool.java 1190173 /src/java/org/apache/sqoop/orm/AvroSchemaGenerator.java PRE-CREATION /src/java/org/apache/sqoop/orm/ClassWriter.java PRE-CREATION /src/java/org/apache/sqoop/orm/CompilationManager.java PRE-CREATION /src/java/org/apache/sqoop/orm/TableClassName.java PRE-CREATION /src/java/org/apache/sqoop/tool/BaseSqoopTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/CodeGenTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/CreateHiveTableTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/EvalSqlTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ExportTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/HelpTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ImportAllTablesTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ImportTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/JobTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ListDatabasesTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ListTablesTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/MergeTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/MetastoreTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/SqoopTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ToolDesc.java PRE-CREATION /src/java/org/apache/sqoop/tool/ToolPlugin.java PRE-CREATION /src/java/org/apache/sqoop/tool/VersionTool.java PRE-CREATION /src/test/com/cloudera/sqoop/orm/TestClassWriter.java 1190173 /src/test/com/cloudera/sqoop/orm/TestParseMethods.java 1190173 /src/test/com/cloudera/sqoop/tool/TestToolPlugin.java 1190173 Diff: https://reviews.apache.org/r/2574/diff Testing ------- Thanks, Jarek
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2574/
        -----------------------------------------------------------

        (Updated 2011-10-29 08:37:37.583603)

        Review request for Sqoop and Bilung Lee.

        Changes
        -------

        I've applied your suggestions/comments.

        Summary
        -------

        Please check whether this is something that we're looking for.

        Just let me firstly explain the weirdness in inheritance between com.cloudera.sqoop.tool.(Base)SqoopTool and org.apache.sqoop.tool.(Base)SqoopTool (and other children). I initially followed specification in master JIRA, but I've end up with not backward compatible code that I have to fix on several places to get it compiled. Problem was in broken inheritance topology - in old com.cloudera.sqoop package there was main parent SqoopTool with child BaseSqoopTool and additional children (ImportTool for example). With my original changes, ImportTool was no longer child of com.cloudera.sqoop.tool.(Base)SqoopTool because it was child of org.apache.sqoop.tool.(Base)SqoopTool instead. I wasn't able to find better solution for this problem than having this weird inheritance in place.

        If you have better idea how to get the job done, please don't hesitate to advise.

        Jarcec

        This addresses bug SQOOP-374.
        https://issues.apache.org/jira/browse/SQOOP-374

        Diffs (updated)


        /src/java/com/cloudera/sqoop/orm/AvroSchemaGenerator.java 1190173
        /src/java/com/cloudera/sqoop/orm/ClassWriter.java 1190173
        /src/java/com/cloudera/sqoop/orm/CompilationManager.java 1190173
        /src/java/com/cloudera/sqoop/orm/TableClassName.java 1190173
        /src/java/com/cloudera/sqoop/tool/BaseSqoopTool.java 1190173
        /src/java/com/cloudera/sqoop/tool/CodeGenTool.java 1190173
        /src/java/com/cloudera/sqoop/tool/CreateHiveTableTool.java 1190173
        /src/java/com/cloudera/sqoop/tool/EvalSqlTool.java 1190173
        /src/java/com/cloudera/sqoop/tool/ExportTool.java 1190173
        /src/java/com/cloudera/sqoop/tool/HelpTool.java 1190173
        /src/java/com/cloudera/sqoop/tool/ImportAllTablesTool.java 1190173
        /src/java/com/cloudera/sqoop/tool/ImportTool.java 1190173
        /src/java/com/cloudera/sqoop/tool/JobTool.java 1190173
        /src/java/com/cloudera/sqoop/tool/ListDatabasesTool.java 1190173
        /src/java/com/cloudera/sqoop/tool/ListTablesTool.java 1190173
        /src/java/com/cloudera/sqoop/tool/MergeTool.java 1190173
        /src/java/com/cloudera/sqoop/tool/MetastoreTool.java 1190173
        /src/java/com/cloudera/sqoop/tool/SqoopTool.java 1190173
        /src/java/com/cloudera/sqoop/tool/ToolDesc.java 1190173
        /src/java/com/cloudera/sqoop/tool/ToolPlugin.java 1190173
        /src/java/com/cloudera/sqoop/tool/VersionTool.java 1190173
        /src/java/org/apache/sqoop/orm/AvroSchemaGenerator.java PRE-CREATION
        /src/java/org/apache/sqoop/orm/ClassWriter.java PRE-CREATION
        /src/java/org/apache/sqoop/orm/CompilationManager.java PRE-CREATION
        /src/java/org/apache/sqoop/orm/TableClassName.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/BaseSqoopTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/CodeGenTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/CreateHiveTableTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/EvalSqlTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/ExportTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/HelpTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/ImportAllTablesTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/ImportTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/JobTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/ListDatabasesTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/ListTablesTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/MergeTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/MetastoreTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/SqoopTool.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/ToolDesc.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/ToolPlugin.java PRE-CREATION
        /src/java/org/apache/sqoop/tool/VersionTool.java PRE-CREATION
        /src/test/com/cloudera/sqoop/orm/TestClassWriter.java 1190173
        /src/test/com/cloudera/sqoop/orm/TestParseMethods.java 1190173
        /src/test/com/cloudera/sqoop/tool/TestToolPlugin.java 1190173

        Diff: https://reviews.apache.org/r/2574/diff

        Testing
        -------

        Thanks,

        Jarek

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2574/ ----------------------------------------------------------- (Updated 2011-10-29 08:37:37.583603) Review request for Sqoop and Bilung Lee. Changes ------- I've applied your suggestions/comments. Summary ------- Please check whether this is something that we're looking for. Just let me firstly explain the weirdness in inheritance between com.cloudera.sqoop.tool.(Base)SqoopTool and org.apache.sqoop.tool.(Base)SqoopTool (and other children). I initially followed specification in master JIRA, but I've end up with not backward compatible code that I have to fix on several places to get it compiled. Problem was in broken inheritance topology - in old com.cloudera.sqoop package there was main parent SqoopTool with child BaseSqoopTool and additional children (ImportTool for example). With my original changes, ImportTool was no longer child of com.cloudera.sqoop.tool.(Base)SqoopTool because it was child of org.apache.sqoop.tool.(Base)SqoopTool instead. I wasn't able to find better solution for this problem than having this weird inheritance in place. If you have better idea how to get the job done, please don't hesitate to advise. Jarcec This addresses bug SQOOP-374 . https://issues.apache.org/jira/browse/SQOOP-374 Diffs (updated) /src/java/com/cloudera/sqoop/orm/AvroSchemaGenerator.java 1190173 /src/java/com/cloudera/sqoop/orm/ClassWriter.java 1190173 /src/java/com/cloudera/sqoop/orm/CompilationManager.java 1190173 /src/java/com/cloudera/sqoop/orm/TableClassName.java 1190173 /src/java/com/cloudera/sqoop/tool/BaseSqoopTool.java 1190173 /src/java/com/cloudera/sqoop/tool/CodeGenTool.java 1190173 /src/java/com/cloudera/sqoop/tool/CreateHiveTableTool.java 1190173 /src/java/com/cloudera/sqoop/tool/EvalSqlTool.java 1190173 /src/java/com/cloudera/sqoop/tool/ExportTool.java 1190173 /src/java/com/cloudera/sqoop/tool/HelpTool.java 1190173 /src/java/com/cloudera/sqoop/tool/ImportAllTablesTool.java 1190173 /src/java/com/cloudera/sqoop/tool/ImportTool.java 1190173 /src/java/com/cloudera/sqoop/tool/JobTool.java 1190173 /src/java/com/cloudera/sqoop/tool/ListDatabasesTool.java 1190173 /src/java/com/cloudera/sqoop/tool/ListTablesTool.java 1190173 /src/java/com/cloudera/sqoop/tool/MergeTool.java 1190173 /src/java/com/cloudera/sqoop/tool/MetastoreTool.java 1190173 /src/java/com/cloudera/sqoop/tool/SqoopTool.java 1190173 /src/java/com/cloudera/sqoop/tool/ToolDesc.java 1190173 /src/java/com/cloudera/sqoop/tool/ToolPlugin.java 1190173 /src/java/com/cloudera/sqoop/tool/VersionTool.java 1190173 /src/java/org/apache/sqoop/orm/AvroSchemaGenerator.java PRE-CREATION /src/java/org/apache/sqoop/orm/ClassWriter.java PRE-CREATION /src/java/org/apache/sqoop/orm/CompilationManager.java PRE-CREATION /src/java/org/apache/sqoop/orm/TableClassName.java PRE-CREATION /src/java/org/apache/sqoop/tool/BaseSqoopTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/CodeGenTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/CreateHiveTableTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/EvalSqlTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ExportTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/HelpTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ImportAllTablesTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ImportTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/JobTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ListDatabasesTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ListTablesTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/MergeTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/MetastoreTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/SqoopTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ToolDesc.java PRE-CREATION /src/java/org/apache/sqoop/tool/ToolPlugin.java PRE-CREATION /src/java/org/apache/sqoop/tool/VersionTool.java PRE-CREATION /src/test/com/cloudera/sqoop/orm/TestClassWriter.java 1190173 /src/test/com/cloudera/sqoop/orm/TestParseMethods.java 1190173 /src/test/com/cloudera/sqoop/tool/TestToolPlugin.java 1190173 Diff: https://reviews.apache.org/r/2574/diff Testing ------- Thanks, Jarek
        Hide
        Bilung Lee added a comment -

        Patch committed. Thanks, Jarcec!

        Show
        Bilung Lee added a comment - Patch committed. Thanks, Jarcec!
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2574/#review2978
        -----------------------------------------------------------

        Ship it!

        +1. Thanks!

        • Bilung

        On 2011-10-29 08:37:37, Jarek Jarcec wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2574/

        -----------------------------------------------------------

        (Updated 2011-10-29 08:37:37)

        Review request for Sqoop and Bilung Lee.

        Summary

        -------

        Please check whether this is something that we're looking for.

        Just let me firstly explain the weirdness in inheritance between com.cloudera.sqoop.tool.(Base)SqoopTool and org.apache.sqoop.tool.(Base)SqoopTool (and other children). I initially followed specification in master JIRA, but I've end up with not backward compatible code that I have to fix on several places to get it compiled. Problem was in broken inheritance topology - in old com.cloudera.sqoop package there was main parent SqoopTool with child BaseSqoopTool and additional children (ImportTool for example). With my original changes, ImportTool was no longer child of com.cloudera.sqoop.tool.(Base)SqoopTool because it was child of org.apache.sqoop.tool.(Base)SqoopTool instead. I wasn't able to find better solution for this problem than having this weird inheritance in place.

        If you have better idea how to get the job done, please don't hesitate to advise.

        Jarcec

        This addresses bug SQOOP-374.

        https://issues.apache.org/jira/browse/SQOOP-374

        Diffs

        -----

        /src/java/com/cloudera/sqoop/orm/AvroSchemaGenerator.java 1190173

        /src/java/com/cloudera/sqoop/orm/ClassWriter.java 1190173

        /src/java/com/cloudera/sqoop/orm/CompilationManager.java 1190173

        /src/java/com/cloudera/sqoop/orm/TableClassName.java 1190173

        /src/java/com/cloudera/sqoop/tool/BaseSqoopTool.java 1190173

        /src/java/com/cloudera/sqoop/tool/CodeGenTool.java 1190173

        /src/java/com/cloudera/sqoop/tool/CreateHiveTableTool.java 1190173

        /src/java/com/cloudera/sqoop/tool/EvalSqlTool.java 1190173

        /src/java/com/cloudera/sqoop/tool/ExportTool.java 1190173

        /src/java/com/cloudera/sqoop/tool/HelpTool.java 1190173

        /src/java/com/cloudera/sqoop/tool/ImportAllTablesTool.java 1190173

        /src/java/com/cloudera/sqoop/tool/ImportTool.java 1190173

        /src/java/com/cloudera/sqoop/tool/JobTool.java 1190173

        /src/java/com/cloudera/sqoop/tool/ListDatabasesTool.java 1190173

        /src/java/com/cloudera/sqoop/tool/ListTablesTool.java 1190173

        /src/java/com/cloudera/sqoop/tool/MergeTool.java 1190173

        /src/java/com/cloudera/sqoop/tool/MetastoreTool.java 1190173

        /src/java/com/cloudera/sqoop/tool/SqoopTool.java 1190173

        /src/java/com/cloudera/sqoop/tool/ToolDesc.java 1190173

        /src/java/com/cloudera/sqoop/tool/ToolPlugin.java 1190173

        /src/java/com/cloudera/sqoop/tool/VersionTool.java 1190173

        /src/java/org/apache/sqoop/orm/AvroSchemaGenerator.java PRE-CREATION

        /src/java/org/apache/sqoop/orm/ClassWriter.java PRE-CREATION

        /src/java/org/apache/sqoop/orm/CompilationManager.java PRE-CREATION

        /src/java/org/apache/sqoop/orm/TableClassName.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/BaseSqoopTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/CodeGenTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/CreateHiveTableTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/EvalSqlTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/ExportTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/HelpTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/ImportAllTablesTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/ImportTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/JobTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/ListDatabasesTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/ListTablesTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/MergeTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/MetastoreTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/SqoopTool.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/ToolDesc.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/ToolPlugin.java PRE-CREATION

        /src/java/org/apache/sqoop/tool/VersionTool.java PRE-CREATION

        /src/test/com/cloudera/sqoop/orm/TestClassWriter.java 1190173

        /src/test/com/cloudera/sqoop/orm/TestParseMethods.java 1190173

        /src/test/com/cloudera/sqoop/tool/TestToolPlugin.java 1190173

        Diff: https://reviews.apache.org/r/2574/diff

        Testing

        -------

        Thanks,

        Jarek

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2574/#review2978 ----------------------------------------------------------- Ship it! +1. Thanks! Bilung On 2011-10-29 08:37:37, Jarek Jarcec wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2574/ ----------------------------------------------------------- (Updated 2011-10-29 08:37:37) Review request for Sqoop and Bilung Lee. Summary ------- Please check whether this is something that we're looking for. Just let me firstly explain the weirdness in inheritance between com.cloudera.sqoop.tool.(Base)SqoopTool and org.apache.sqoop.tool.(Base)SqoopTool (and other children). I initially followed specification in master JIRA, but I've end up with not backward compatible code that I have to fix on several places to get it compiled. Problem was in broken inheritance topology - in old com.cloudera.sqoop package there was main parent SqoopTool with child BaseSqoopTool and additional children (ImportTool for example). With my original changes, ImportTool was no longer child of com.cloudera.sqoop.tool.(Base)SqoopTool because it was child of org.apache.sqoop.tool.(Base)SqoopTool instead. I wasn't able to find better solution for this problem than having this weird inheritance in place. If you have better idea how to get the job done, please don't hesitate to advise. Jarcec This addresses bug SQOOP-374 . https://issues.apache.org/jira/browse/SQOOP-374 Diffs ----- /src/java/com/cloudera/sqoop/orm/AvroSchemaGenerator.java 1190173 /src/java/com/cloudera/sqoop/orm/ClassWriter.java 1190173 /src/java/com/cloudera/sqoop/orm/CompilationManager.java 1190173 /src/java/com/cloudera/sqoop/orm/TableClassName.java 1190173 /src/java/com/cloudera/sqoop/tool/BaseSqoopTool.java 1190173 /src/java/com/cloudera/sqoop/tool/CodeGenTool.java 1190173 /src/java/com/cloudera/sqoop/tool/CreateHiveTableTool.java 1190173 /src/java/com/cloudera/sqoop/tool/EvalSqlTool.java 1190173 /src/java/com/cloudera/sqoop/tool/ExportTool.java 1190173 /src/java/com/cloudera/sqoop/tool/HelpTool.java 1190173 /src/java/com/cloudera/sqoop/tool/ImportAllTablesTool.java 1190173 /src/java/com/cloudera/sqoop/tool/ImportTool.java 1190173 /src/java/com/cloudera/sqoop/tool/JobTool.java 1190173 /src/java/com/cloudera/sqoop/tool/ListDatabasesTool.java 1190173 /src/java/com/cloudera/sqoop/tool/ListTablesTool.java 1190173 /src/java/com/cloudera/sqoop/tool/MergeTool.java 1190173 /src/java/com/cloudera/sqoop/tool/MetastoreTool.java 1190173 /src/java/com/cloudera/sqoop/tool/SqoopTool.java 1190173 /src/java/com/cloudera/sqoop/tool/ToolDesc.java 1190173 /src/java/com/cloudera/sqoop/tool/ToolPlugin.java 1190173 /src/java/com/cloudera/sqoop/tool/VersionTool.java 1190173 /src/java/org/apache/sqoop/orm/AvroSchemaGenerator.java PRE-CREATION /src/java/org/apache/sqoop/orm/ClassWriter.java PRE-CREATION /src/java/org/apache/sqoop/orm/CompilationManager.java PRE-CREATION /src/java/org/apache/sqoop/orm/TableClassName.java PRE-CREATION /src/java/org/apache/sqoop/tool/BaseSqoopTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/CodeGenTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/CreateHiveTableTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/EvalSqlTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ExportTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/HelpTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ImportAllTablesTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ImportTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/JobTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ListDatabasesTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ListTablesTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/MergeTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/MetastoreTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/SqoopTool.java PRE-CREATION /src/java/org/apache/sqoop/tool/ToolDesc.java PRE-CREATION /src/java/org/apache/sqoop/tool/ToolPlugin.java PRE-CREATION /src/java/org/apache/sqoop/tool/VersionTool.java PRE-CREATION /src/test/com/cloudera/sqoop/orm/TestClassWriter.java 1190173 /src/test/com/cloudera/sqoop/orm/TestParseMethods.java 1190173 /src/test/com/cloudera/sqoop/tool/TestToolPlugin.java 1190173 Diff: https://reviews.apache.org/r/2574/diff Testing ------- Thanks, Jarek
        Hide
        Hudson added a comment -

        Integrated in Sqoop-jdk-1.6 #50 (See https://builds.apache.org/job/Sqoop-jdk-1.6/50/)
        SQOOP-374: Migrate tool and orm packages to new name space

        blee : http://svn.apache.org/viewvc/?view=rev&rev=1195852
        Files :

        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/orm/AvroSchemaGenerator.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/orm/ClassWriter.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/orm/CompilationManager.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/orm/TableClassName.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/tool/BaseSqoopTool.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/tool/CodeGenTool.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/tool/CreateHiveTableTool.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/tool/EvalSqlTool.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/tool/ExportTool.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/tool/HelpTool.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/tool/ImportAllTablesTool.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/tool/ImportTool.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/tool/JobTool.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/tool/ListDatabasesTool.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/tool/ListTablesTool.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/tool/MergeTool.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/tool/MetastoreTool.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/tool/SqoopTool.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/tool/ToolDesc.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/tool/ToolPlugin.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/tool/VersionTool.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/orm
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/orm/AvroSchemaGenerator.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/orm/ClassWriter.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/orm/CompilationManager.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/orm/TableClassName.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/tool
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/tool/BaseSqoopTool.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/tool/CodeGenTool.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/tool/CreateHiveTableTool.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/tool/EvalSqlTool.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/tool/ExportTool.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/tool/HelpTool.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/tool/ImportAllTablesTool.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/tool/ImportTool.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/tool/JobTool.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/tool/ListDatabasesTool.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/tool/ListTablesTool.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/tool/MergeTool.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/tool/MetastoreTool.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/tool/SqoopTool.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/tool/ToolDesc.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/tool/ToolPlugin.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/tool/VersionTool.java
        Show
        Hudson added a comment - Integrated in Sqoop-jdk-1.6 #50 (See https://builds.apache.org/job/Sqoop-jdk-1.6/50/ ) SQOOP-374 : Migrate tool and orm packages to new name space blee : http://svn.apache.org/viewvc/?view=rev&rev=1195852 Files : /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/orm/AvroSchemaGenerator.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/orm/ClassWriter.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/orm/CompilationManager.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/orm/TableClassName.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/tool/BaseSqoopTool.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/tool/CodeGenTool.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/tool/CreateHiveTableTool.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/tool/EvalSqlTool.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/tool/ExportTool.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/tool/HelpTool.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/tool/ImportAllTablesTool.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/tool/ImportTool.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/tool/JobTool.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/tool/ListDatabasesTool.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/tool/ListTablesTool.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/tool/MergeTool.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/tool/MetastoreTool.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/tool/SqoopTool.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/tool/ToolDesc.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/tool/ToolPlugin.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/tool/VersionTool.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/orm /incubator/sqoop/trunk/src/java/org/apache/sqoop/orm/AvroSchemaGenerator.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/orm/ClassWriter.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/orm/CompilationManager.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/orm/TableClassName.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/tool /incubator/sqoop/trunk/src/java/org/apache/sqoop/tool/BaseSqoopTool.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/tool/CodeGenTool.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/tool/CreateHiveTableTool.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/tool/EvalSqlTool.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/tool/ExportTool.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/tool/HelpTool.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/tool/ImportAllTablesTool.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/tool/ImportTool.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/tool/JobTool.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/tool/ListDatabasesTool.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/tool/ListTablesTool.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/tool/MergeTool.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/tool/MetastoreTool.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/tool/SqoopTool.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/tool/ToolDesc.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/tool/ToolPlugin.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/tool/VersionTool.java

          People

          • Assignee:
            Jarek Jarcec Cecho
            Reporter:
            Bilung Lee
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development